librenms / librenmsv2

app/Providers/RouteServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
      */
     public function map(Router $router)
     {
-        $router->group(['namespace' => $this->namespace], function ($router) {
+        $router->group(['namespace' => $this->namespace], function($router) {
             require app_path('Http/routes.php');
         });
     }

app/Api/Controllers/APIController.php

Braces +1 added lines, -2 removed lines

@@ -17,8 +17,7 @@
     public function list_devices(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Devices::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->devices()->get();
         }
     }

Indentation +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
         $versions['db_schema'] = DB::select('SELECT `version` FROM `dbSchema` LIMIT 1')[0]->version;
         $versions['php']       = phpversion();
         $versions['db_driver'] = strtoupper(DB::connection()->getDriverName());
-	if ($versions['db_driver'] == 'SQLITE') {
+    if ($versions['db_driver'] == 'SQLITE') {
             $versions['db_version'] = DB::select('SELECT sqlite_version() AS version')[0]->version;
         }
         else {

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
         $stats['ports']      = \App\Port::all()->count();
         $stats['syslog']     = \App\Syslog::all()->count();
         $stats['eventlog']   = \App\Eventlog::all()->count();
-        $stats['apps']       = DB::table('applications')->count();;
+        $stats['apps']       = DB::table('applications')->count(); ;
         $stats['services']   = DB::table('services')->count();
         $stats['storage']    = DB::table('storage')->count();
         $stats['diskio']     = DB::table('ucd_diskio')->count();

app/Api/Controllers/DeviceController.php

Braces +2 added lines, -4 removed lines

@@ -19,8 +19,7 @@ 
     public function list_devices(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Device::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->devices()->get();
         }
     }
@@ -31,8 +30,7 @@ 
     public function list_ports(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Port::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->ports()->get();
         }
     }

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         }
         else {
             $user = User::find($request->user()->user_id);
-            $device =  $user->devices()->find($id);
+            $device = $user->devices()->find($id);
         }
         // morph the data as required
         if ($request->query('displayFormat') == 'link') {

app/Api/Controllers/PortController.php

Braces +2 added lines, -4 removed lines

@@ -19,8 +19,7 @@ 
     public function list_devices(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Device::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->devices()->get();
         }
     }
@@ -31,8 +30,7 @@ 
     public function list_ports(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Port::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->ports()->get();
         }
     }

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use App\User;
 use App\Port;
 use App\Api\Transformers\PortTransformer;
-
 use Illuminate\Http\Request;
 use Dingo\Api\Routing\Helpers;
 use Illuminate\Support\Facades\Input;

app/User.php

Doc Comments +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
     /**
      * Test if the User is an admin or demo.
      *
-     * @return \Illuminate\Database\Eloquent\Builder
+     * @return boolean
      */
     public function isAdmin()
     {
@@ -42,7 +42,7 @@ 
      * Test if this user has global read access
      * these users have a level of 5, 10 or 11 (demo).
      *
-     * @return \Illuminate\Database\Eloquent\Builder
+     * @return boolean
      */
     public function hasGlobalRead()
     {

app/Http/Controllers/NotificationController.php

Braces +1 added lines, -2 removed lines

@@ -17,8 +17,7 @@
     public function list_devices(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Devices::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->devices()->get();
         }
     }

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Illuminate\Contracts\Auth\Guard;
 use Dingo\Api\Http;
 use Dingo\Api\Routing\Helpers;
-use Illuminate\Http\Request;
 
 class SetViewVariable
 {

app/Notification.php

Spacing +2 added lines, -2 removed lines

@@ -41,11 +41,11 @@
 
     public function scopeLimit($query)
     {
-        return $query->select('notifications.*','key');
+        return $query->select('notifications.*', 'key');
     }
 
     public function users() {
-        return $this->belongsToMany('App\User')->withPivot('notifications_id','user_id');
+        return $this->belongsToMany('App\User')->withPivot('notifications_id', 'user_id');
     }
 
 }

Doc Comments +3 added lines

@@ -42,6 +42,9 @@
         $this->setAttrib('sticky', $enabled);
     }
 
+    /**
+     * @param string $name
+     */
     private function setAttrib($name, $enabled) {
         if ($enabled === true) {
             $read = new NotificationAttrib;

Braces +1 added lines, -2 removed lines

@@ -17,8 +17,7 @@
     public function list_devices(Request $request) {
         if ($request->user()->level >= 10 || $request->user()->level == 5) {
             return Devices::all();
-        }
-        else {
+        } else {
             return User::find($request->user()->user_id)->devices()->get();
         }
     }

app/Api/Controllers/NotificationController.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Dingo\Api\Http;
 use Dingo\Api\Routing\Helpers;
 use App\Notification;
-use App\NotificationAttrib;
 use Illuminate\Http\Request;
 
 class NotificationController extends Controller

Indentation +2 added lines, -2 removed lines

@@ -43,10 +43,10 @@
         }
 
         if ($action == 'read') {
-           $result = $notification->markRead($enable);
+            $result = $notification->markRead($enable);
         }
         elseif ($action == 'sticky') {
-           $result = $notification->markSticky(false);
+            $result = $notification->markSticky(false);
         }
 
         if ($result === false) {

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 
         $notification = Notification::find($id);
         $enable = strpos($action, 'un') === false;
-        if(!$enable) {
+        if (!$enable) {
             $action = substr($action, 2);
         }
 

Braces +3 added lines, -6 removed lines

@@ -26,8 +26,7 @@ 
         if ($type === 'archive')
         {
             $notifications = Notification::IsArchived($request)->get();
-        }
-        else {
+        } else {
             $notifications = Notification::IsUnread()->get();
         }
         return $notifications;
@@ -44,15 +43,13 @@ 
 
         if ($action == 'read') {
            $result = $notification->markRead($enable);
-        }
-        elseif ($action == 'sticky') {
+        } elseif ($action == 'sticky') {
            $result = $notification->markSticky(false);
         }
 
         if ($result === false) {
             return $this->response->errorInternal();
-        }
-        else {
+        } else {
             return $this->response->array(array('statusText'=>'OK'));
         }
     }

app/Api/Transformers/PortTransformer.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     /**
      * Include Device
      *
-     * @return League\Fractal\ItemResource
+     * @return Fractal\Resource\Item
      */
     public function includeDevice(Port $port)
     {