Completed
Pull Request — develop (#57)
by Tony
06:32
created
app/Http/Controllers/SettingsController.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -17,8 +17,6 @@
 block discarded – undo
17 17
 
18 18
 namespace App\Http\Controllers;
19 19
 
20
-use App\Http\Requests;
21
-use App\Models\DbConfig;
22 20
 use Illuminate\Http\Request;
23 21
 use Settings;
24 22
 
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@
 block discarded – undo
15 15
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
16 16
  */
17 17
 /**
18
- * SettingsController.php
19
- *
20
- * @package    LibreNMS
21
- * @author     Tony Murray <[email protected]>
22
- * @copyright  2016 Tony Murray
23
- * @license    @license http://opensource.org/licenses/GPL-3.0 GNU Public License v3 or later
24
- */
18
+     * SettingsController.php
19
+     *
20
+     * @package    LibreNMS
21
+     * @author     Tony Murray <[email protected]>
22
+     * @copyright  2016 Tony Murray
23
+     * @license    @license http://opensource.org/licenses/GPL-3.0 GNU Public License v3 or later
24
+     */
25 25
 
26 26
 namespace App\Http\Controllers;
27 27
 
Please login to merge, or discard this patch.
app/Models/DbConfig.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 
50 50
     public function scopeKey($query, $key)
51 51
     {
52
-        return $query->where('config_name', 'LIKE', $key . '%');
52
+        return $query->where('config_name', 'LIKE', $key.'%');
53 53
     }
54 54
 
55 55
     public function scopeExactKey($query, $key)
Please login to merge, or discard this patch.
app/Settings.php 3 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@
 block discarded – undo
15 15
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
16 16
  */
17 17
 /**
18
- * Settings.php
19
- *
20
- * @package    LibreNMS
21
- * @author     Tony Murray <[email protected]>
22
- * @copyright  2016 Tony Murray
23
- * @license    @license http://opensource.org/licenses/GPL-3.0 GNU Public License v3 or later
24
- */
18
+     * Settings.php
19
+     *
20
+     * @package    LibreNMS
21
+     * @author     Tony Murray <[email protected]>
22
+     * @copyright  2016 Tony Murray
23
+     * @license    @license http://opensource.org/licenses/GPL-3.0 GNU Public License v3 or later
24
+     */
25 25
 namespace App\Settings;
26 26
 
27 27
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -8 removed lines patch added patch discarded remove patch
@@ -50,8 +50,7 @@  discard block
 block discarded – undo
50 50
                 DbConfig::updateOrCreate(['config_name' => $k], ['config_value' => $v]);
51 51
                 Cache::put($k, $v, $this->cache_time);
52 52
             }
53
-        }
54
-        else {
53
+        } else {
55 54
             DbConfig::updateOrCreate(['config_name' => $key], ['config_value' => $value]);
56 55
             Cache::put($key, $value, $this->cache_time);
57 56
         }
@@ -68,16 +67,14 @@  discard block
 block discarded – undo
68 67
             if (count($db_data) == 1 && $db_data->first()->config_name == $key) {
69 68
                 // return a bare value if we are getting one item
70 69
                 return $db_data->first()->config_value;
71
-            }
72
-            elseif (count($db_data) >= 1) {
70
+            } elseif (count($db_data) >= 1) {
73 71
                 $result = self::collectionToArray($db_data, $key);
74 72
                 $config = Config::get('config.' . $key, $default);
75 73
                 if (!is_null($config)) {
76 74
                     $result = array_replace_recursive($config, $result);
77 75
                 }
78 76
                 return $result;
79
-            }
80
-            else {
77
+            } else {
81 78
                 return Config::get('config.' . $key, $default);
82 79
             }
83 80
 
@@ -166,8 +163,7 @@  discard block
 block discarded – undo
166 163
             $currentPath = array_merge($path, array($key));
167 164
             if (is_array($val)) {
168 165
                 $result = array_merge($result, self::recursive_keys($val, $prefix, $currentPath));
169
-            }
170
-            else {
166
+            } else {
171 167
                 $result[$prefix . join('.', $currentPath)] = $val;
172 168
             }
173 169
         }
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 use App\Models\DbConfig;
29 29
 use Cache;
30 30
 use Config;
31
-use Illuminate\Contracts\Config\Repository as ConfigContract;  // adds the possibility to replace the default Config facade
31
+use Illuminate\Contracts\Config\Repository as ConfigContract; // adds the possibility to replace the default Config facade
32 32
 
33 33
 class Settings implements ConfigContract
34 34
 {
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     public function get($key, $default = null)
86 86
     {
87 87
         // return value from cache or fetch it and return it
88
-        return Cache::remember($key, $this->cache_time, function () use ($key, $default) {
88
+        return Cache::remember($key, $this->cache_time, function() use ($key, $default) {
89 89
             $db_data = DbConfig::key($key)->get(['config_name', 'config_value']);
90 90
 
91 91
             if (count($db_data) == 1 && $db_data->first()->config_name == $key) {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
             elseif (count($db_data) >= 1) {
96 96
                 // convert collection to an array and merge with the config fallback
97 97
                 $result = self::collectionToArray($db_data, $key);
98
-                $config = Config::get('config.' . $key, $default);
98
+                $config = Config::get('config.'.$key, $default);
99 99
                 if (!is_null($config) && is_array($config)) {
100 100
                     $result = array_replace_recursive($config, $result);
101 101
                 }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
             }
104 104
             else {
105 105
                 // fallback to the config or return the default value
106
-                return Config::get('config.' . $key, $default);
106
+                return Config::get('config.'.$key, $default);
107 107
             }
108 108
 
109 109
         });
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
     private static function recursive_keys(array $array, $prefix = "", array $path = array())
213 213
     {
214 214
         if ($prefix != "") {
215
-            $prefix = trim($prefix, '.') . '.';
215
+            $prefix = trim($prefix, '.').'.';
216 216
         }
217 217
         $result = array();
218 218
         foreach ($array as $key => $val) {
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
                 $result = array_merge($result, self::recursive_keys($val, $prefix, $currentPath));
222 222
             }
223 223
             else {
224
-                $result[$prefix . join('.', $currentPath)] = $val;
224
+                $result[$prefix.join('.', $currentPath)] = $val;
225 225
             }
226 226
         }
227 227
         return $result;
Please login to merge, or discard this patch.
app/Providers/SettingsServiceProvider.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@
 block discarded – undo
15 15
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
16 16
  */
17 17
 /**
18
- * SettingsServiceProvider.php
19
- *
20
- * @package    LibreNMS
21
- * @author     Tony Murray <[email protected]>
22
- * @copyright  2016 Tony Murray
23
- * @license    @license http://opensource.org/licenses/GPL-3.0 GNU Public License v3 or later
24
- */
18
+     * SettingsServiceProvider.php
19
+     *
20
+     * @package    LibreNMS
21
+     * @author     Tony Murray <[email protected]>
22
+     * @copyright  2016 Tony Murray
23
+     * @license    @license http://opensource.org/licenses/GPL-3.0 GNU Public License v3 or later
24
+     */
25 25
 
26 26
 namespace App\Providers;
27 27
 
Please login to merge, or discard this patch.