libgraviton / import-export

src/Command/CoreImportCommand.php

Doc Comments +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
     /**
      * import a single file into a collection
      *
-     * @param SplFileInfo     $file   file
+     * @param \SplFileInfo     $file   file
      * @param InputInterface  $input  User input on console
      * @param OutputInterface $output Output of the command
      *

src/Command/ImportCommand.php

Doc Comments +1 added lines, -1 removed lines

@@ -344,7 +344,7 @@
      *
      * @param Document $doc        Data source for import data
      * @param string   $originFile Original full filename used toimport
-     * @return bool|mixed
+     * @return false|string
      */
     private function validateUploadFile(Document $doc, $originFile)
     {

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace Graviton\ImportExport\Command;
 
 use Graviton\ImportExport\Exception\MissingTargetException;
-use Graviton\ImportExport\Exception\JsonParseException;
 use Graviton\ImportExport\Exception\ParseException;
 use Graviton\ImportExport\Exception\UnknownFileTypeException;
 use Graviton\ImportExport\Service\HttpClient;

Spacing +6 added lines, -6 removed lines

@@ -244,7 +244,7 @@ 
             $this->logger->info("Loading data from ${file}");
 
             if (!array_key_exists('target', $doc->getData())) {
-                throw new MissingTargetException('Missing target in \'' . $file . '\'');
+                throw new MissingTargetException('Missing target in \''.$file.'\'');
             }
 
             $targetUrl = sprintf('%s%s', $host, $doc->getData()['target']);
@@ -292,7 +292,7 @@ 
 
         // Authentication or custom headers.
         if ($this->headerBasicAuth) {
-            $data['headers']['Authorization'] = 'Basic '. base64_encode($this->headerBasicAuth);
+            $data['headers']['Authorization'] = 'Basic '.base64_encode($this->headerBasicAuth);
         }
         if ($this->customHeaders) {
             foreach ($this->customHeaders as $headers) {
@@ -342,7 +342,7 @@ 
                 $data
             );
 
-            $this->logger->info('Wrote ' . $response->getHeader('Link')[0]);
+            $this->logger->info('Wrote '.$response->getHeader('Link')[0]);
         } catch (\Exception $e) {
             $this->errors[$file] = $e->getMessage();
             $this->logger->error(
@@ -359,10 +359,10 @@ 
                     $this->cloner->cloneVar(
                         $this->parser->parse($e->getResponse()->getBody(), Yaml::PARSE_OBJECT_FOR_MAP)
                     ),
-                    function ($line, $depth) use ($output) {
+                    function($line, $depth) use ($output) {
                         if ($depth > 0) {
                             $output->writeln(
-                                '<error>' . str_pad(str_repeat('  ', $depth) . $line, 140, ' ') . '</error>'
+                                '<error>'.str_pad(str_repeat('  ', $depth).$line, 140, ' ').'</error>'
                             );
                         }
                     }
@@ -431,7 +431,7 @@ 
         }
 
         // Find file
-        $fileName = dirname($originFile) . DIRECTORY_SEPARATOR . $documentData['file'];
+        $fileName = dirname($originFile).DIRECTORY_SEPARATOR.$documentData['file'];
         $fileName = str_replace('//', '/', $fileName);
         if (!file_exists($fileName)) {
             return false;

src/Command/ValidationCommand.php

Spacing +3 added lines, -3 removed lines

@@ -84,15 +84,15 @@
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $files = $input->getArgument('file');
-        $finder =  new Finder();
+        $finder = new Finder();
         $finder = $finder->files();
 
         /**
          * @param SplFileInfo $file
          * @return bool
          */
-        $filter = function (SplFileInfo $file) {
-            if (!in_array($file->getExtension(), ['yml','json']) || $file->isDir()) {
+        $filter = function(SplFileInfo $file) {
+            if (!in_array($file->getExtension(), ['yml', 'json']) || $file->isDir()) {
                 return false;
             }
             return true;

src/Command/ImportCommandAbstract.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
      *
      * @param InputInterface $input User input on console
      *
-     * @return Finder|SplFileInfo[] finder
+     * @return Finder finder
      */
     protected function getFinder($input)
     {

Spacing +4 added lines, -4 removed lines

@@ -49,7 +49,7 @@ 
         try {
             $exitCode = $this->doImport($this->getFinder($input), $input, $output);
         } catch (MissingTargetException $e) {
-            $output->writeln('<error>' . $e->getMessage() . '</error>');
+            $output->writeln('<error>'.$e->getMessage().'</error>');
         }
         return $exitCode;
     }
@@ -76,8 +76,8 @@ 
          * @param SplFileInfo $file
          * @return bool
          */
-        $filter = function (SplFileInfo $file) {
-            if (!in_array($file->getExtension(), ['yml','json']) || $file->isDir()) {
+        $filter = function(SplFileInfo $file) {
+            if (!in_array($file->getExtension(), ['yml', 'json']) || $file->isDir()) {
                 return false;
             }
             return true;
@@ -102,7 +102,7 @@ 
 
             $fileList = array_filter(
                 $fileList,
-                function ($val) {
+                function($val) {
                     if (!empty($val)) {
                         return true;
                     }

src/Command/CoreExportCommand.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Graviton\ImportExport\Util\JsonSerializer;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
-
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;

test/Command/CoreImportCommandTest.php

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
         $clientMock = $this->getMockBuilder('\MongoClient')->disableOriginalConstructor()->getMock();
 
         $collectionMock = $this->getMockBuilder('\MongoCollection')->disableOriginalConstructor()->getMock();
-        $collectionMock->method('save')->will($this->returnCallback(array($this,'saveCollectionCallback')));
+        $collectionMock->method('save')->will($this->returnCallback(array($this, 'saveCollectionCallback')));
 
         $dbMock = $this->getMockBuilder('\MongoDB')->disableOriginalConstructor()->getMock();
         $dbMock->method('selectCollection')->willReturn($collectionMock);
@@ -126,7 +126,7 @@ 
 
         // fail in output?
         $this->assertContains(
-            'Error in <' . $this->sourceDir . '/Dudess/Invalid.json>: Invalid JSON to unserialize.',
+            'Error in <'.$this->sourceDir.'/Dudess/Invalid.json>: Invalid JSON to unserialize.',
             $this->cmdTester->getDisplay()
         );
         $this->assertEquals(1, $this->cmdTester->getStatusCode());

test/Util/TestUtils.php

Spacing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     public static function getFullStringFromLog(TestHandler $handler)
     {
         $entries = array_map(
-            function ($val) {
+            function($val) {
                 return $val['formatted'];
             },
             $handler->getRecords()

test/Command/ImportCommandTest.php

Spacing +14 added lines, -14 removed lines

@@ -46,7 +46,7 @@ 
         $responseMock
             ->method('getHeader')
             ->with('Link')
-            ->willReturn(['<' . $host . $path . '>; rel="self"']);
+            ->willReturn(['<'.$host.$path.'>; rel="self"']);
 
         $clientMock
             ->method('request')
@@ -67,8 +67,8 @@ 
         $cmdTester = $this->getTester($sut, $file);
         $display = TestUtils::getFullStringFromLog($logger->getHandlers()[0]);
 
-        $this->assertContains('Loading data from ' . $file, $display);
-        $this->assertContains('Wrote <' . $host . $path . '>; rel="self"', $display);
+        $this->assertContains('Loading data from '.$file, $display);
+        $this->assertContains('Wrote <'.$host.$path.'>; rel="self"', $display);
         $this->assertEquals(0, $cmdTester->getStatusCode());
     }
 
@@ -80,12 +80,12 @@ 
         return [
             'basic valid file' => [
                 'http://localhost',
-                __DIR__ . '/fixtures/set-01/test-2.json',
+                __DIR__.'/fixtures/set-01/test-2.json',
                 '/core/app/test',
             ],
             'basic valid image file' => [
                 'http://localhost',
-                __DIR__ . '/fixtures/file',
+                __DIR__.'/fixtures/file',
                 '/core/app/test',
             ],
         ];
@@ -112,12 +112,12 @@ 
         $responseMock
             ->method('getHeader')
             ->with('Link')
-            ->willReturn(['<' . $host . $file . '>; rel="self"']);
+            ->willReturn(['<'.$host.$file.'>; rel="self"']);
 
         $requestMock = $this->createMock('Psr\Http\Message\RequestInterface');
         $requestMock
             ->method('getUri')
-            ->willReturn($host . '/core/app/test');
+            ->willReturn($host.'/core/app/test');
 
         $exceptionMock = $this->getMockBuilder('GuzzleHttp\Exception\RequestException')
             ->setConstructorArgs(['Client error: 400', $requestMock, $responseMock])
@@ -150,7 +150,7 @@ 
         $cmdTester = $this->getTester($sut, $file);
         $display = TestUtils::getFullStringFromLog($logger->getHandlers()[0]);
 
-        $this->assertContains('Loading data from ' . $file, $display);
+        $this->assertContains('Loading data from '.$file, $display);
         foreach ($errors as $error) {
             $this->assertContains(
                 $error,
@@ -168,18 +168,18 @@ 
         return [
             'invalid file (server side)' => [
                 'http://localhost',
-                __DIR__ . '/fixtures/set-01/test.json',
+                __DIR__.'/fixtures/set-01/test.json',
                 [
-                    'Failed to write <http://localhost/core/app/test> from \'' .
-                    __DIR__ . '/fixtures/set-01/test.json\' with message \'Client error: 400\'',
+                    'Failed to write <http://localhost/core/app/test> from \''.
+                    __DIR__.'/fixtures/set-01/test.json\' with message \'Client error: 400\'',
                     '"message": "invalid"',
                 ],
             ],
             'missing target in file (user error)' => [
                 'http://localhost',
-                __DIR__ . '/fixtures/set-01/test-3.json',
+                __DIR__.'/fixtures/set-01/test-3.json',
                 [
-                    'Missing target in \'' . __DIR__ . '/fixtures/set-01/test-3.json\'',
+                    'Missing target in \''.__DIR__.'/fixtures/set-01/test-3.json\'',
                 ],
             ]
         ];
@@ -229,7 +229,7 @@ 
 
         $cmdTester = $this->getTester(
             $sut,
-            __DIR__ . '/fixtures/set-01/test-4.json',
+            __DIR__.'/fixtures/set-01/test-4.json',
             [
                 'host' => 'http://example.com',
                 '--rewrite-host' => 'http://localhost'