NodePriorityQueueMin::lookup() - Code Metrics - letournel/path-finder - Measure and Improve Code Quality continuously with Scrutinizer

NodePriorityQueueMin::lookup() A
last analyzed 2017-07-23 14:48 UTC

↳ Parent: NodePriorityQueueMin

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1

<?php

namespace Letournel\PathFinder\Core;

class NodePriorityQueueMin implements \Countable
{
    private
        $map,
class A {
    var $property;
}
        $queue;
    
    public function __contruct()
    {
        $this->map = array();
        $this->queue = array();
    }
    
    public function count()
    {
        return count($this->queue);
    }
    
    public function isEmpty()
    {
        return empty($this->queue);
    }
    
    public function lookup(Node $node)

    {
        $id = $node->getId();
        
        if(array_key_exists($id, $this->queue))
        {
            return $this->queue[$id];
        }
        
        return null;
    }
    
    public function extract()
    {
        reset($this->queue);
        $id = key($this->queue);
        $node = $this->map[$id];
        
        unset($this->map[$id]);
        unset($this->queue[$id]);
        
        return $node;
    }
    
    public function insert(Node $node, $priority)
    {
        $this->queue[$node->getId()] = $priority;
        $this->map[$node->getId()] = $node;
        asort($this->queue);
    }
}


1		<?php
2
3		namespace Letournel\PathFinder\Core;
4
5		class NodePriorityQueueMin implements \Countable
6		{
7		private
8		$map,
		0 ignored issues – show Coding Style introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history... Coding Style introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$map`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
9		$queue;
10
11		public function __contruct()
12		{
13		$this->map = array();
14		$this->queue = array();
15		}
16
17		public function count()
18		{
19		return count($this->queue);
20		}
21
22		public function isEmpty()
23		{
24		return empty($this->queue);
25		}
26
27	View Code Duplication	public function lookup(Node $node)
		0 ignored issues – show Duplication introduced 2015-12-08 23:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$id = $node->getId();
30
31		if(array_key_exists($id, $this->queue))
32		{
33		return $this->queue[$id];
34		}
35
36		return null;
37		}
38
39		public function extract()
40		{
41		reset($this->queue);
42		$id = key($this->queue);
43		$node = $this->map[$id];
44
45		unset($this->map[$id]);
46		unset($this->queue[$id]);
47
48		return $node;
49		}
50
51		public function insert(Node $node, $priority)
52		{
53		$this->queue[$node->getId()] = $priority;
54		$this->map[$node->getId()] = $node;
55		asort($this->queue);
56		}
57		}
58

letournel / path-finder

GitHub Access Token became invalid

NodePriorityQueueMin::lookup() A last analyzed 2017-07-23 14:48 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

NodePriorityQueueMin::lookup() A
last analyzed 2017-07-23 14:48 UTC