Letournel\PathFinder\Core\NodePriorityQueueMin

Complexity

Total Complexity

7

Size/Duplication

Total Lines	53
Duplicated Lines	20.75 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__contruct()	0	5	1
A	count()	0	4	1
A	isEmpty()	0	4	1
A	lookup()	11	11	2
A	extract()	0	11	1
A	insert()	0	6	1

<?php

namespace Letournel\PathFinder\Core;

class NodePriorityQueueMin implements \Countable
{
    private
        $map,

It is generally advisable to only define one property per statement.

The visibility should be declared for property $map.

        $queue;
    
    public function __contruct()
    {
        $this->map = array();
        $this->queue = array();
    }
    
    public function count()
    {
        return count($this->queue);
    }
    
    public function isEmpty()
    {
        return empty($this->queue);
    }
    
    public function lookup(Node $node)

This method seems to be duplicated in your project.

    {
        $id = $node->getId();
        
        if(array_key_exists($id, $this->queue))
        {
            return $this->queue[$id];
        }
        
        return null;
    }
    
    public function extract()
    {
        reset($this->queue);
        $id = key($this->queue);
        $node = $this->map[$id];
        
        unset($this->map[$id]);
        unset($this->queue[$id]);
        
        return $node;
    }
    
    public function insert(Node $node, $priority)
    {
        $this->queue[$node->getId()] = $priority;
        $this->map[$node->getId()] = $node;
        asort($this->queue);
    }
}