JiraRestApi\Priority\PriorityService::getAll()

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getAll()
    {
        $queryParam = '?'.http_build_query();

The assignment to $queryParam is dead and can be removed.

The call to http_build_query() has too few arguments starting with query_data.

        $ret = $this->exec($this->uri, null);

        $this->log->addInfo("Result=\n".$ret);

        $priorityData = json_decode($ret);
        $priorities = [];

        foreach ($priorityData as $priority) {
            $priorities[] = $this->json_mapper->map($priority, new Priority());
        }

        return $priorities;

The expression return $priorities returns the type array|array<mixed,object> which is incompatible with the documented return type object|JiraRestApi\Priority\Priority.

    }