JiraRestApi\Priority\PriorityService

Complexity

Total Complexity

2

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getAll()	0	16	2

<?php

namespace JiraRestApi\Priority;

/**
 * Class to query priority.
 */
class PriorityService extends \JiraRestApi\JiraClient
{
    private $uri = '/priority';

    /**
     * Function to get all priorities.
     *
     * @throws \JiraRestApi\JiraException
     * @throws \JsonMapper_Exception
     *
     * @return Priority|object Priority class
     */
    public function getAll()
    {
        $queryParam = '?'.http_build_query();

The assignment to $queryParam is dead and can be removed.

The call to http_build_query() has too few arguments starting with query_data.

        $ret = $this->exec($this->uri, null);

        $this->log->addInfo("Result=\n".$ret);

        $priorityData = json_decode($ret);
        $priorities = [];

        foreach ($priorityData as $priority) {
            $priorities[] = $this->json_mapper->map($priority, new Priority());
        }

        return $priorities;

The expression return $priorities returns the type array|array<mixed,object> which is incompatible with the documented return type object|JiraRestApi\Priority\Priority.

    }
}