JiraRestApi\Status\StatusService::getAll()

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function getAll()
    {
        if ($this->isRestApiV3()) {
            throw new JiraException('V3 is currently not supported');
        }

        else {
            $statusObject = new Status();

The assignment to $statusObject is dead and can be removed.

        }

        $ret = $this->exec($this->uri.'/', null);
        $this->log->info("Result=\n".$ret);

Are you sure $ret of type string|true can be used in concatenation?

        return $this->json_mapper->mapArray(
            json_decode($ret, false),

It seems like $ret can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            new \ArrayObject(),
            '\JiraRestApi\Status\status'
        );