JiraRestApi\Status\StatusService

Complexity

Total Complexity

2

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	getAll()	0	18	2

<?php

namespace JiraRestApi\Status;


use JiraRestApi\JiraException;
use JsonMapper_Exception;

class StatusService extends \JiraRestApi\JiraClient
{
    private $uri = '/status';

    /**
     * get all statuses
     * @throws JiraException
     * @throws JsonMapper_Exception
     *
     * @return Status[] array of Project class
     */
    public function getAll()
    {
        if ($this->isRestApiV3()) {
            throw new JiraException('V3 is currently not supported');
        }

        else {
            $statusObject = new Status();

The assignment to $statusObject is dead and can be removed.

        }

        $ret = $this->exec($this->uri.'/', null);
        $this->log->info("Result=\n".$ret);

Are you sure $ret of type string|true can be used in concatenation?

        return $this->json_mapper->mapArray(
            json_decode($ret, false),

It seems like $ret can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

            new \ArrayObject(),
            '\JiraRestApi\Status\status'
        );
    }
}