leo108 / laravel_cas_server

src/Repositories/TicketRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
     /**
      * @param integer $totalLength
      * @param string  $prefix
-     * @return bool|string
+     * @return string|false
      */
     protected function getAvailableTicket($totalLength, $prefix)
     {

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
      * @throws CasException
      * @return \Leo108\CAS\Models\Ticket
      */
-    public function applyTicket(UserModel $user, $serviceUrl, $proxies = [])
+    public function applyTicket(UserModel $user, $serviceUrl, $proxies = [ ])
     {
         $service = $this->serviceRepository->getServiceByUrl($serviceUrl);
         if (!$service) {
@@ -111,7 +111,7 @@ 
         return $this->ticketGenerator->generate(
             $totalLength,
             $prefix,
-            function ($ticket) {
+            function($ticket) {
                 return $this->getByTicket($ticket, false);
             },
             10

tests/Http/Controllers/ValidateControllerTest.php

Doc Comments +3 added lines

@@ -936,6 +936,9 @@
         $method->invokeArgs($controller, [$code, $desc, 'XML']);
     }
 
+    /**
+     * @param string $pgt
+     */
     protected function getValidRequest($pgt = null)
     {
         $mock = Mockery::mock(Request::class)

Unused Use Statements -2 removed lines

@@ -21,8 +21,6 @@
 use Leo108\CAS\Responses\XmlAuthenticationSuccessResponse;
 use Leo108\CAS\Services\PGTCaller;
 use Leo108\CAS\Services\TicketGenerator;
-use SerializableModel;
-use SimpleXMLElement;
 use TestCase;
 use Mockery;
 use User;

Spacing +82 added lines, -82 removed lines

@@ -47,13 +47,13 @@ 
     {
         $request = Mockery::mock(Request::class)
             ->shouldReceive('get')
-            ->withArgs(['ticket', ''])
+            ->withArgs([ 'ticket', '' ])
             ->andReturnNull()
             ->shouldReceive('get')
-            ->withArgs(['service', ''])
+            ->withArgs([ 'service', '' ])
             ->andReturnNull()
             ->getMock();
-        $resp    = app()->make(ValidateController::class)->v1ValidateAction($request);
+        $resp = app()->make(ValidateController::class)->v1ValidateAction($request);
         $this->assertInstanceOf(Response::class, $resp);
         $this->assertEquals('no', $resp->getOriginalContent());
     }
@@ -67,7 +67,7 @@ 
             ->shouldReceive('lockTicket')
             ->andReturn(false)
             ->getMock();
-        $resp       = $controller->v1ValidateAction($request);
+        $resp = $controller->v1ValidateAction($request);
         $this->assertInstanceOf(Response::class, $resp);
         $this->assertEquals('no', $resp->getOriginalContent());
     }
@@ -87,7 +87,7 @@ 
             ->andReturn(true)
             ->shouldReceive('unlockTicket')
             ->getMock();
-        $resp       = $controller->v1ValidateAction($request);
+        $resp = $controller->v1ValidateAction($request);
         $this->assertInstanceOf(Response::class, $resp);
         $this->assertEquals('no', $resp->getOriginalContent());
     }
@@ -109,7 +109,7 @@ 
             ->andReturn(true)
             ->shouldReceive('unlockTicket')
             ->getMock();
-        $resp       = $controller->v1ValidateAction($request);
+        $resp = $controller->v1ValidateAction($request);
         $this->assertInstanceOf(Response::class, $resp);
         $this->assertEquals('no', $resp->getOriginalContent());
     }
@@ -119,7 +119,7 @@ 
         $request          = $this->getValidRequest();
         $ticket           = Mockery::mock(Ticket::class)
             ->shouldReceive('getAttribute')
-            ->withArgs(['service_url'])
+            ->withArgs([ 'service_url' ])
             ->andReturn('http://leo108.com')
             ->getMock();
         $ticketRepository = Mockery::mock(TicketRepository::class)
@@ -135,7 +135,7 @@ 
             ->andReturn(true)
             ->shouldReceive('unlockTicket')
             ->getMock();
-        $resp       = $controller->v1ValidateAction($request);
+        $resp = $controller->v1ValidateAction($request);
         $this->assertInstanceOf(Response::class, $resp);
         $this->assertEquals('yes', $resp->getOriginalContent());
     }
@@ -147,7 +147,7 @@ 
             ->shouldAllowMockingProtectedMethods()
             ->shouldReceive('casValidate')
             ->andReturnUsing(
-                function ($request, $returnAttr, $allowProxy) {
+                function($request, $returnAttr, $allowProxy) {
                     $this->assertFalse($returnAttr);
                     $this->assertFalse($allowProxy);
 
@@ -156,7 +156,7 @@ 
             )
             ->once()
             ->getMock();
-        $request    = Mockery::mock(Request::class);
+        $request = Mockery::mock(Request::class);
         $this->assertEquals('casValidate called', $controller->v2ServiceValidateAction($request));
     }
 
@@ -167,7 +167,7 @@ 
             ->shouldAllowMockingProtectedMethods()
             ->shouldReceive('casValidate')
             ->andReturnUsing(
-                function ($request, $returnAttr, $allowProxy) {
+                function($request, $returnAttr, $allowProxy) {
                     $this->assertFalse($returnAttr);
                     $this->assertTrue($allowProxy);
 
@@ -176,7 +176,7 @@ 
             )
             ->once()
             ->getMock();
-        $request    = Mockery::mock(Request::class);
+        $request = Mockery::mock(Request::class);
         $this->assertEquals('casValidate called', $controller->v2ProxyValidateAction($request));
     }
 
@@ -187,7 +187,7 @@ 
             ->shouldAllowMockingProtectedMethods()
             ->shouldReceive('casValidate')
             ->andReturnUsing(
-                function ($request, $returnAttr, $allowProxy) {
+                function($request, $returnAttr, $allowProxy) {
                     $this->assertTrue($returnAttr);
                     $this->assertFalse($allowProxy);
 
@@ -196,7 +196,7 @@ 
             )
             ->once()
             ->getMock();
-        $request    = Mockery::mock(Request::class);
+        $request = Mockery::mock(Request::class);
         $this->assertEquals('casValidate called', $controller->v3ServiceValidateAction($request));
     }
 
@@ -207,7 +207,7 @@ 
             ->shouldAllowMockingProtectedMethods()
             ->shouldReceive('casValidate')
             ->andReturnUsing(
-                function ($request, $returnAttr, $allowProxy) {
+                function($request, $returnAttr, $allowProxy) {
                     $this->assertTrue($returnAttr);
                     $this->assertTrue($allowProxy);
 
@@ -216,13 +216,13 @@ 
             )
             ->once()
             ->getMock();
-        $request    = Mockery::mock(Request::class);
+        $request = Mockery::mock(Request::class);
         $this->assertEquals('casValidate called', $controller->v3ProxyValidateAction($request));
     }
 
     public function testProxyActionWithInvalidRequest()
     {
-        $request    = Mockery::mock(Request::class)
+        $request = Mockery::mock(Request::class)
             ->shouldReceive('get')
             ->with('pgt', '')
             ->andReturn('')
@@ -241,7 +241,7 @@ 
             ->shouldAllowMockingProtectedMethods()
             ->shouldReceive('proxyFailureResponse')
             ->andReturnUsing(
-                function ($code, $desc, $format) {
+                function($code, $desc, $format) {
                     $this->assertEquals(CasException::INVALID_REQUEST, $code);
                     $this->assertEquals('param pgt and targetService can not be empty', $desc);
                     $this->assertEquals('XML', $format);
@@ -258,15 +258,15 @@ 
     {
         $request = Mockery::mock(Request::class)
             ->shouldReceive('get')
-            ->withArgs(['ticket', ''])
+            ->withArgs([ 'ticket', '' ])
             ->andReturn('')
             ->once()
             ->shouldReceive('get')
-            ->withArgs(['service', ''])
+            ->withArgs([ 'service', '' ])
             ->andReturn('')
             ->once()
             ->shouldReceive('get')
-            ->withArgs(['format', 'XML'])
+            ->withArgs([ 'format', 'XML' ])
             ->andReturn('JSON')
             ->once()
             ->getMock();
@@ -276,7 +276,7 @@ 
             ->shouldAllowMockingProtectedMethods()
             ->shouldReceive('authFailureResponse')
             ->andReturnUsing(
-                function ($code, $desc, $format) {
+                function($code, $desc, $format) {
                     $this->assertEquals(CasException::INVALID_REQUEST, $code);
                     $this->assertEquals('param service and ticket can not be empty', $desc);
                     $this->assertEquals('JSON', $format);
@@ -286,8 +286,8 @@ 
             )
             ->once()
             ->getMock();
-        $method     = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $method = self::getNonPublicMethod($controller, 'casValidate');
+        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateAndLockTicketFailed()
@@ -301,7 +301,7 @@ 
             ->once()
             ->shouldReceive('authFailureResponse')
             ->andReturnUsing(
-                function ($code, $desc, $format) {
+                function($code, $desc, $format) {
                     $this->assertEquals(CasException::INTERNAL_ERROR, $code);
                     $this->assertEquals('try to lock ticket failed', $desc);
                     $this->assertEquals('JSON', $format);
@@ -311,8 +311,8 @@ 
             )
             ->once()
             ->getMock();
-        $method     = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $method = self::getNonPublicMethod($controller, 'casValidate');
+        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateWithInvalidTicket()
@@ -334,7 +334,7 @@ 
             ->once()
             ->shouldReceive('authFailureResponse')
             ->andReturnUsing(
-                function ($code, $desc, $format) {
+                function($code, $desc, $format) {
                     $this->assertEquals(CasException::INVALID_TICKET, $code);
                     $this->assertEquals('ticket is not valid', $desc);
                     $this->assertEquals('JSON', $format);
@@ -344,8 +344,8 @@ 
             )
             ->once()
             ->getMock();
-        $method     = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $method = self::getNonPublicMethod($controller, 'casValidate');
+        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateWithValidTicketButServiceMismatch()
@@ -353,7 +353,7 @@ 
         $request          = $this->getValidRequest();
         $ticket           = Mockery::mock(Ticket::class)
             ->shouldReceive('getAttribute')
-            ->withArgs(['service_url'])
+            ->withArgs([ 'service_url' ])
             ->andReturn('http://github.com')
             ->once()
             ->shouldReceive('isProxy')
@@ -378,7 +378,7 @@ 
             ->once()
             ->shouldReceive('authFailureResponse')
             ->andReturnUsing(
-                function ($code, $desc, $format) {
+                function($code, $desc, $format) {
                     $this->assertEquals(CasException::INVALID_SERVICE, $code);
                     $this->assertEquals('service is not valid', $desc);
                     $this->assertEquals('JSON', $format);
@@ -388,8 +388,8 @@ 
             )
             ->once()
             ->getMock();
-        $method     = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $method = self::getNonPublicMethod($controller, 'casValidate');
+        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateWithValidProxyTicketButNotAllowProxy()
@@ -418,7 +418,7 @@ 
             ->once()
             ->shouldReceive('authFailureResponse')
             ->andReturnUsing(
-                function ($code, $desc, $format) {
+                function($code, $desc, $format) {
                     $this->assertEquals(CasException::INVALID_TICKET, $code);
                     $this->assertEquals('ticket is not valid', $desc);
                     $this->assertEquals('JSON', $format);
@@ -428,20 +428,20 @@ 
             )
             ->once()
             ->getMock();
-        $method     = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $method = self::getNonPublicMethod($controller, 'casValidate');
+        $this->assertEquals('authFailureResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateWithValidProxyTicketAndAllowProxy()
     {
-        $proxies          = ['http://proxy1.com', 'http://proxy2.com'];
+        $proxies          = [ 'http://proxy1.com', 'http://proxy2.com' ];
         $request          = $this->getValidRequest('');
         $user             = Mockery::mock(User::class)
             ->shouldReceive('getName')
             ->andReturn('test_user')
             ->once()
             ->getMock();
-        $ticket           = Mockery::mock(Ticket::class)
+        $ticket = Mockery::mock(Ticket::class)
             ->shouldReceive('isProxy')
             ->andReturn(true)
             ->once()
@@ -450,11 +450,11 @@ 
             ->andReturn($proxies)
             ->once()
             ->shouldReceive('getAttribute')
-            ->withArgs(['service_url'])
+            ->withArgs([ 'service_url' ])
             ->andReturn('http://leo108.com')
             ->once()
             ->shouldReceive('getAttribute')
-            ->withArgs(['user'])
+            ->withArgs([ 'user' ])
             ->andReturn($user)
             ->times(2)
             ->getMock();
@@ -476,7 +476,7 @@ 
             ->once()
             ->shouldReceive('authSuccessResponse')
             ->andReturnUsing(
-                function ($name, $format, $attributes, $proxiesParam, $iou) use ($proxies) {
+                function($name, $format, $attributes, $proxiesParam, $iou) use ($proxies) {
                     $this->assertEquals('test_user', $name);
                     $this->assertEmpty($attributes);
                     $this->assertEquals('JSON', $format);
@@ -488,8 +488,8 @@ 
             )
             ->once()
             ->getMock();
-        $method     = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [$request, false, true]));
+        $method = self::getNonPublicMethod($controller, 'casValidate');
+        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [ $request, false, true ]));
     }
 
     public function testCasValidateWithValidTicketAndServiceAndNoPgt()
@@ -500,16 +500,16 @@ 
             ->andReturn('test_user')
             ->once()
             ->getMock();
-        $ticket           = Mockery::mock(Ticket::class)
+        $ticket = Mockery::mock(Ticket::class)
             ->shouldReceive('isProxy')
             ->andReturn(false)
             ->times(2)
             ->shouldReceive('getAttribute')
-            ->withArgs(['service_url'])
+            ->withArgs([ 'service_url' ])
             ->andReturn('http://leo108.com')
             ->once()
             ->shouldReceive('getAttribute')
-            ->withArgs(['user'])
+            ->withArgs([ 'user' ])
             ->andReturn($user)
             ->times(2)
             ->getMock();
@@ -531,7 +531,7 @@ 
             ->once()
             ->shouldReceive('authSuccessResponse')
             ->andReturnUsing(
-                function ($name, $format, $attributes, $proxies, $iou) {
+                function($name, $format, $attributes, $proxies, $iou) {
                     $this->assertEquals('test_user', $name);
                     $this->assertEmpty($attributes);
                     $this->assertEquals('JSON', $format);
@@ -545,7 +545,7 @@ 
             ->getMock();
 
         $method = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateWithValidTicketAndServiceAndPgtButApplyPGTFailed()
@@ -556,16 +556,16 @@ 
             ->andReturn('test_user')
             ->once()
             ->getMock();
-        $ticket           = Mockery::mock(Ticket::class)
+        $ticket = Mockery::mock(Ticket::class)
             ->shouldReceive('isProxy')
             ->andReturn(false)
             ->times(2)
             ->shouldReceive('getAttribute')
-            ->withArgs(['service_url'])
+            ->withArgs([ 'service_url' ])
             ->andReturn('http://leo108.com')
             ->once()
             ->shouldReceive('getAttribute')
-            ->withArgs(['user'])
+            ->withArgs([ 'user' ])
             ->andReturn($user)
             ->times(2)
             ->getMock();
@@ -593,7 +593,7 @@ 
             ->once()
             ->shouldReceive('authSuccessResponse')
             ->andReturnUsing(
-                function ($name, $format, $attributes, $proxies, $iou) {
+                function($name, $format, $attributes, $proxies, $iou) {
                     $this->assertEquals('test_user', $name);
                     $this->assertEmpty($attributes);
                     $this->assertEquals('JSON', $format);
@@ -607,7 +607,7 @@ 
             ->getMock();
 
         $method = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateWithValidTicketAndServiceAndPgtButCallPgtUrlFailed()
@@ -618,16 +618,16 @@ 
             ->andReturn('test_user')
             ->once()
             ->getMock();
-        $ticket           = Mockery::mock(Ticket::class)
+        $ticket = Mockery::mock(Ticket::class)
             ->shouldReceive('isProxy')
             ->andReturn(false)
             ->times(2)
             ->shouldReceive('getAttribute')
-            ->withArgs(['service_url'])
+            ->withArgs([ 'service_url' ])
             ->andReturn('http://leo108.com')
             ->once()
             ->shouldReceive('getAttribute')
-            ->withArgs(['user'])
+            ->withArgs([ 'user' ])
             ->andReturn($user)
             ->times(2)
             ->getMock();
@@ -667,7 +667,7 @@ 
             ->once()
             ->shouldReceive('authSuccessResponse')
             ->andReturnUsing(
-                function ($name, $format, $attributes, $proxies, $iou) {
+                function($name, $format, $attributes, $proxies, $iou) {
                     $this->assertEquals('test_user', $name);
                     $this->assertEmpty($attributes);
                     $this->assertEquals('JSON', $format);
@@ -681,7 +681,7 @@ 
             ->getMock();
 
         $method = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateWithValidTicketAndServiceAndPgtButCallPgtUrlSuccess()
@@ -692,16 +692,16 @@ 
             ->andReturn('test_user')
             ->once()
             ->getMock();
-        $ticket           = Mockery::mock(Ticket::class)
+        $ticket = Mockery::mock(Ticket::class)
             ->shouldReceive('isProxy')
             ->andReturn(false)
             ->times(2)
             ->shouldReceive('getAttribute')
-            ->withArgs(['service_url'])
+            ->withArgs([ 'service_url' ])
             ->andReturn('http://leo108.com')
             ->once()
             ->shouldReceive('getAttribute')
-            ->withArgs(['user'])
+            ->withArgs([ 'user' ])
             ->andReturn($user)
             ->times(2)
             ->getMock();
@@ -741,7 +741,7 @@ 
             ->once()
             ->shouldReceive('authSuccessResponse')
             ->andReturnUsing(
-                function ($name, $format, $attributes, $proxies, $iou) {
+                function($name, $format, $attributes, $proxies, $iou) {
                     $this->assertEquals('test_user', $name);
                     $this->assertEmpty($attributes);
                     $this->assertEquals('JSON', $format);
@@ -755,7 +755,7 @@ 
             ->getMock();
 
         $method = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testCasValidateWithValidProxyTicketAndServiceAndPgtButCallPgtUrlSuccess()
@@ -766,16 +766,16 @@ 
             ->andReturn('test_user')
             ->once()
             ->getMock();
-        $ticket           = Mockery::mock(Ticket::class)
+        $ticket = Mockery::mock(Ticket::class)
             ->shouldReceive('isProxy')
             ->andReturn(false)
             ->times(2)
             ->shouldReceive('getAttribute')
-            ->withArgs(['service_url'])
+            ->withArgs([ 'service_url' ])
             ->andReturn('http://leo108.com')
             ->once()
             ->shouldReceive('getAttribute')
-            ->withArgs(['user'])
+            ->withArgs([ 'user' ])
             ->andReturn($user)
             ->times(2)
             ->getMock();
@@ -815,7 +815,7 @@ 
             ->once()
             ->shouldReceive('authSuccessResponse')
             ->andReturnUsing(
-                function ($name, $format, $attributes, $proxies, $iou) {
+                function($name, $format, $attributes, $proxies, $iou) {
                     $this->assertEquals('test_user', $name);
                     $this->assertEmpty($attributes);
                     $this->assertEquals('JSON', $format);
@@ -829,7 +829,7 @@ 
             ->getMock();
 
         $method = self::getNonPublicMethod($controller, 'casValidate');
-        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [$request, false, false]));
+        $this->assertEquals('authSuccessResponse called', $method->invokeArgs($controller, [ $request, false, false ]));
     }
 
     public function testLockTicket()
@@ -843,7 +843,7 @@ 
         $controller = $this->initController()
             ->makePartial();
         $method     = self::getNonPublicMethod($controller, 'lockTicket');
-        $this->assertEquals('acquireLock called', $method->invokeArgs($controller, ['str', 30]));
+        $this->assertEquals('acquireLock called', $method->invokeArgs($controller, [ 'str', 30 ]));
     }
 
     public function testUnlockTicket()
@@ -857,7 +857,7 @@ 
         $controller = $this->initController()
             ->makePartial();
         $method     = self::getNonPublicMethod($controller, 'unlockTicket');
-        $this->assertEquals('releaseLock called', $method->invokeArgs($controller, ['str', 30]));
+        $this->assertEquals('releaseLock called', $method->invokeArgs($controller, [ 'str', 30 ]));
     }
 
     public function testAuthSuccessResponse()
@@ -870,7 +870,7 @@ 
         $attributes = [
             'real_name' => 'real_name',
         ];
-        $proxies    = ['http://proxy1.com'];
+        $proxies    = [ 'http://proxy1.com' ];
         $pgt        = 'ticket';
         $jsonResp   = Mockery::mock(JsonAuthenticationSuccessResponse::class)
             ->shouldReceive('setUser')
@@ -886,7 +886,7 @@ 
             ->once()
             ->getMock();
         app()->instance(JsonAuthenticationSuccessResponse::class, $jsonResp);
-        $method->invokeArgs($controller, ['test_name', 'JSON', $attributes, $proxies, []]);
+        $method->invokeArgs($controller, [ 'test_name', 'JSON', $attributes, $proxies, [ ] ]);
 
         $xmlResp = Mockery::mock(XmlAuthenticationSuccessResponse::class)
             ->shouldReceive('setUser')
@@ -905,7 +905,7 @@ 
             ->once()
             ->getMock();
         app()->instance(XmlAuthenticationSuccessResponse::class, $xmlResp);
-        $method->invokeArgs($controller, ['test_name', 'XML', $attributes, $proxies, $pgt]);
+        $method->invokeArgs($controller, [ 'test_name', 'XML', $attributes, $proxies, $pgt ]);
     }
 
     public function testAuthFailureResponse()
@@ -917,40 +917,40 @@ 
         $desc       = 'desc';
         $jsonResp   = Mockery::mock(JsonAuthenticationFailureResponse::class)
             ->shouldReceive('setFailure')
-            ->withArgs([$code, $desc])
+            ->withArgs([ $code, $desc ])
             ->once()
             ->shouldReceive('toResponse')
             ->once()
             ->getMock();
         app()->instance(JsonAuthenticationFailureResponse::class, $jsonResp);
-        $method->invokeArgs($controller, [$code, $desc, 'JSON']);
+        $method->invokeArgs($controller, [ $code, $desc, 'JSON' ]);
 
         $xmlResp = Mockery::mock(XmlAuthenticationFailureResponse::class)
             ->shouldReceive('setFailure')
-            ->withArgs([$code, $desc])
+            ->withArgs([ $code, $desc ])
             ->once()
             ->shouldReceive('toResponse')
             ->once()
             ->getMock();
         app()->instance(XmlAuthenticationFailureResponse::class, $xmlResp);
-        $method->invokeArgs($controller, [$code, $desc, 'XML']);
+        $method->invokeArgs($controller, [ $code, $desc, 'XML' ]);
     }
 
     protected function getValidRequest($pgt = null)
     {
         $mock = Mockery::mock(Request::class)
             ->shouldReceive('get')
-            ->withArgs(['ticket', ''])
+            ->withArgs([ 'ticket', '' ])
             ->andReturn('ticket')
             ->shouldReceive('get')
-            ->withArgs(['service', ''])
+            ->withArgs([ 'service', '' ])
             ->andReturn('http://leo108.com')
             ->shouldReceive('get')
-            ->withArgs(['format', 'XML'])
+            ->withArgs([ 'format', 'XML' ])
             ->andReturn('JSON');
         if (!is_null($pgt)) {
             $mock->shouldReceive('get')
-                ->withArgs(['pgtUrl', ''])
+                ->withArgs([ 'pgtUrl', '' ])
                 ->andReturn($pgt);
         }
 

tests/Repositories/TicketRepositoryTest.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use Leo108\CAS\Models\Ticket;
 use Leo108\CAS\Services\TicketGenerator;
 use Mockery;
-use ReflectionClass;
 use TestCase;
 use User;
 

Spacing +11 added lines, -11 removed lines

@@ -24,7 +24,7 @@ 
         //test if service url is not valid
         $user = Mockery::mock(User::class)
             ->shouldReceive('getAttribute')
-            ->withArgs(['id'])
+            ->withArgs([ 'id' ])
             ->andReturn(1)
             ->shouldReceive('getEloquentModel')
             ->andReturn(Mockery::self())
@@ -43,9 +43,9 @@ 
         }
 
         //test if get available ticket failed
-        $service           = Mockery::mock(Service::class)
+        $service = Mockery::mock(Service::class)
             ->shouldReceive('getAttribute')
-            ->withArgs(['id'])
+            ->withArgs([ 'id' ])
             ->andReturn(1)
             ->getMock();
         $serviceRepository = Mockery::mock(ServiceRepository::class)
@@ -73,7 +73,7 @@ 
         $serviceUrl        = 'what ever';
         $service           = Mockery::mock(Service::class)
             ->shouldReceive('getAttribute')
-            ->withArgs(['id'])
+            ->withArgs([ 'id' ])
             ->andReturn(1)
             ->getMock();
         $serviceRepository = Mockery::mock(ServiceRepository::class)
@@ -84,13 +84,13 @@ 
         $ticket = Mockery::mock(Ticket::class)
             ->shouldReceive('newInstance')
             ->andReturnUsing(
-                function ($param) {
+                function($param) {
                     $obj = Mockery::mock();
                     $obj->shouldReceive('user->associate');
                     $obj->shouldReceive('service->associate');
                     $obj->shouldReceive('save');
-                    $obj->ticket      = $param['ticket'];
-                    $obj->service_url = $param['service_url'];
+                    $obj->ticket      = $param[ 'ticket' ];
+                    $obj->service_url = $param[ 'service_url' ];
 
                     return $obj;
                 }
@@ -118,7 +118,7 @@ 
 
         $mockTicket = Mockery::mock(Ticket::class)
             ->shouldReceive('isExpired')
-            ->andReturnValues([false, true])
+            ->andReturnValues([ false, true ])
             ->getMock();
 
         $ticket = Mockery::mock(Ticket::class);
@@ -146,10 +146,10 @@ 
         $ticketGenerator = Mockery::mock(TicketGenerator::class)
             ->shouldReceive('generate')
             ->andReturnUsing(
-                function ($totalLength, $paramPrefix, callable $checkFunc, $maxRetry) use ($length, $prefix, $ticket) {
+                function($totalLength, $paramPrefix, callable $checkFunc, $maxRetry) use ($length, $prefix, $ticket) {
                     $this->assertEquals($length, $totalLength);
                     $this->assertEquals($prefix, $paramPrefix);
-                    $this->assertEquals('getByTicket called', call_user_func_array($checkFunc, [$ticket]));
+                    $this->assertEquals('getByTicket called', call_user_func_array($checkFunc, [ $ticket ]));
                     $this->assertEquals(10, $maxRetry);
 
                     return 'generate called';
@@ -183,7 +183,7 @@ 
     {
         return Mockery::mock(
             TicketRepository::class,
-            [app(Ticket::class), app(ServiceRepository::class), app(TicketGenerator::class)]
+            [ app(Ticket::class), app(ServiceRepository::class), app(TicketGenerator::class) ]
         );
     }
 }

src/Http/routes.php

Spacing +2 added lines, -2 removed lines

@@ -6,12 +6,12 @@
 ];
 
 if (config('cas.middleware.common')) {
-    $options['middleware'] = config('cas.middleware.common');
+    $options[ 'middleware' ] = config('cas.middleware.common');
 }
 
 Route::group(
     $options,
-    function () {
+    function() {
         $auth = config('cas.middleware.auth');
         $p    = config('cas.router.name_prefix');
         Route::get('login', 'SecurityController@showLogin')->name($p.'login.get');

src/Http/Controllers/ValidateController.php

Spacing +3 added lines, -3 removed lines

@@ -189,7 +189,7 @@ 
             return $this->authFailureResponse($e->getCasErrorCode(), $e->getMessage(), $format);
         }
 
-        $proxies = [];
+        $proxies = [ ];
         if ($record->isProxy()) {
             $proxies = $record->proxies;
         }
@@ -213,7 +213,7 @@ 
             }
         }
 
-        $attr = $returnAttr ? $record->user->getCASAttributes() : [];
+        $attr = $returnAttr ? $record->user->getCASAttributes() : [ ];
 
         return $this->authSuccessResponse($record->user->getName(), $format, $attr, $proxies, $iou);
     }
@@ -226,7 +226,7 @@ 
      * @param string|null $pgt
      * @return Response
      */
-    protected function authSuccessResponse($username, $format, $attributes, $proxies = [], $pgt = null)
+    protected function authSuccessResponse($username, $format, $attributes, $proxies = [ ], $pgt = null)
     {
         if (strtoupper($format) === 'JSON') {
             $resp = app(JsonAuthenticationSuccessResponse::class);

src/Models/PGTicket.php

Spacing +4 added lines, -4 removed lines

@@ -30,13 +30,13 @@ 
 {
     protected $table = 'cas_proxy_granting_tickets';
     public $timestamps = false;
-    protected $fillable = ['ticket', 'pgt_url', 'proxies', 'expire_at', 'created_at'];
+    protected $fillable = [ 'ticket', 'pgt_url', 'proxies', 'expire_at', 'created_at' ];
 
     public function getProxiesAttribute()
     {
-        $ret = json_decode($this->attributes['proxies'], true);
+        $ret = json_decode($this->attributes[ 'proxies' ], true);
         if (!$ret) {
-            return [];
+            return [ ];
         }
 
         return $ret;
@@ -44,7 +44,7 @@ 
 
     public function setProxiesAttribute($value)
     {
-        $this->attributes['proxies'] = json_encode($value);
+        $this->attributes[ 'proxies' ] = json_encode($value);
     }
 
     public function isExpired()

src/Models/Ticket.php

Spacing +4 added lines, -4 removed lines

@@ -30,7 +30,7 @@ 
 {
     protected $table = 'cas_tickets';
     public $timestamps = false;
-    protected $fillable = ['ticket', 'service_url', 'proxies', 'expire_at', 'created_at'];
+    protected $fillable = [ 'ticket', 'service_url', 'proxies', 'expire_at', 'created_at' ];
 
     public function getProxiesAttribute()
     {
@@ -38,7 +38,7 @@ 
             return null;
         }
 
-        return json_decode($this->attributes['proxies'], true);
+        return json_decode($this->attributes[ 'proxies' ], true);
     }
 
     public function setProxiesAttribute($value)
@@ -46,7 +46,7 @@ 
         if ($this->id && !$this->isProxy()) {
             return;
         }
-        $this->attributes['proxies'] = json_encode($value);
+        $this->attributes[ 'proxies' ] = json_encode($value);
     }
 
     public function isExpired()
@@ -66,6 +66,6 @@ 
 
     public function isProxy()
     {
-        return !is_null($this->attributes['proxies']);
+        return !is_null($this->attributes[ 'proxies' ]);
     }
 }

src/Repositories/PGTicketRepository.php

Spacing +2 added lines, -2 removed lines

@@ -68,7 +68,7 @@ 
      * @return PGTicket
      * @throws CasException
      */
-    public function applyTicket(UserModel $user, $pgtUrl, $proxies = [])
+    public function applyTicket(UserModel $user, $pgtUrl, $proxies = [ ])
     {
         $service = $this->serviceRepository->getServiceByUrl($pgtUrl);
         if (!$service || !$service->allow_proxy) {
@@ -104,7 +104,7 @@ 
         return $this->ticketGenerator->generate(
             $totalLength,
             'PGT-',
-            function ($ticket) {
+            function($ticket) {
                 return $this->getByTicket($ticket, false);
             },
             10

src/Services/TicketGenerator.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
         $flag   = false;
         for ($i = 0; $i < $maxRetry; $i++) {
             $ticket = $this->generateOne($totalLength, $prefix);
-            if (!call_user_func_array($checkFunc, [$ticket])) {
+            if (!call_user_func_array($checkFunc, [ $ticket ])) {
                 $flag = true;
                 break;
             }