User::getCASAttributes() - Code Metrics - Inspection of "add proxy" - leo108/laravel_cas_server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — proxy (a8ed88)

by leo

created 2016-10-26 10:11 UTC

User::getCASAttributes() A

↳ Parent: User

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	0
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php
use Illuminate\Database\Eloquent\Model;
use Leo108\CAS\Contracts\Models\UserModel;

/**
 * Created by PhpStorm.
 * User: leo108
 * Date: 2016/9/29
 * Time: 09:56
 */
class User extends Model implements UserModel
namespace YourVendor;

class YourClass { }
{
    protected $table = 'cas_users';
    protected $fillable = ['name'];

    public function getName()
    {
        return $this->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getCASAttributes()
    {
        return [
            'real_name' => $this->real_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        ];
    }

    public function getEloquentModel()
    {
        return $this;
    }
}


1			<?php
2			use Illuminate\Database\Eloquent\Model;
3			use Leo108\CAS\Contracts\Models\UserModel;
4
5			/**
6			* Created by PhpStorm.
7			* User: leo108
8			* Date: 2016/9/29
9			* Time: 09:56
10			*/
11			class User extends Model implements UserModel
			0 ignored issues – show Coding Style Compatibility introduced 2016-10-26 10:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12			{
13			protected $table = 'cas_users';
14			protected $fillable = ['name'];
15
16			public function getName()
17			{
18			return $this->name;
			0 ignored issues – show Documentation introduced 2016-10-26 10:20 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
19			}
20
21			public function getCASAttributes()
22			{
23			return [
24			'real_name' => $this->real_name,
			0 ignored issues – show Documentation introduced 2016-10-26 10:20 UTC by Report Bug Copy Issue Report The property `real_name` does not exist on `object<User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25			];
26			}
27
28			public function getEloquentModel()
29			{
30			return $this;
31			}
32			}
33

leo108 / laravel_cas_server

Branch — proxy (a8ed88)

User::getCASAttributes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like