lechimp-p / dicto.php

src/Rules/ContainText.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Lechimp\Dicto\Indexer\Insert;
 use Lechimp\Dicto\Indexer\Location;
 use Lechimp\Dicto\Analysis\Query;
-use Lechimp\Dicto\Analysis\Violation;
 use \Lechimp\Dicto\Variables\Variable;
 
 /**

Doc Comments +3 added lines

@@ -126,6 +126,9 @@
             );
     }
 
+    /**
+     * @param boolean $negate
+     */
     protected function regexp_source_filter($regexp, $negate) {
         assert('is_string($regexp)');
         assert('is_bool($negate)');

src/Definition/RuleParser.php

Doc Comments +3 added lines, -1 removed lines

@@ -210,6 +210,7 @@ 
     // IMPLEMENTATION OF Parser
 
     /**
+     * @param string $source
      * @return  Ruleset
      */
     public function parse($source) {
@@ -270,6 +271,7 @@ 
 
     /**
      * @param   string
+     * @param string $content
      * @return  string
      */
     protected function trim_explanation($content) {
@@ -338,7 +340,7 @@ 
     /**
      * Fetch a rule schema and its arguments from the stream.
      *
-     * @return  array   (R\Schema, array)
+     * @return  R\Schema   (R\Schema, array)
      */
     protected function schema() {
         $t = $this->current_symbol();

src/Graph/QueryImpl.php

Doc Comments +5 added lines, -5 removed lines

@@ -97,7 +97,7 @@ 
     }
 
     /**
-     * @return  Iterator <[Node,mixed]>
+     * @return  \Generator <[Node,mixed]>
      */
     protected function switch_run_command(\Iterator $nodes, $step) {
         list($cmd,$par) = $step;
@@ -116,7 +116,7 @@ 
     }
 
     /**
-     * @return  Iterator <[Node,mixed]>
+     * @return  \Generator <[Node,mixed]>
      */
     protected function run_expand(\Iterator $nodes, \Closure $clsr) {
         while ($nodes->valid()) {
@@ -130,7 +130,7 @@ 
     }
 
     /**
-     * @return  Iterator <[Node,mixed]>
+     * @return  \Generator <[Node,mixed]>
      */
     protected function run_extract(\Iterator $nodes, \Closure $clsr) {
         while ($nodes->valid()) {
@@ -145,7 +145,7 @@ 
     }
 
     /**
-     * @return  Iterator <[Node,mixed]>
+     * @return  \Generator <[Node,mixed]>
      */
     protected function run_filter(\Iterator $nodes, Predicate $predicate) {
         $clsr = $predicate->compile();
@@ -160,7 +160,7 @@ 
     }
 
     /**
-     * @return  Iterator <[Node,mixed]>
+     * @return  \Generator <[Node,mixed]>
      */
     protected function add_result(\Iterator $nodes, &$result) {
         while ($nodes->valid()) {

src/Indexer/ASTVisitor.php

Unused Use Statements -3 removed lines

@@ -10,9 +10,6 @@
 
 namespace Lechimp\Dicto\Indexer;
 
-use Lechimp\Dicto\Variables\Variable;
-use PhpParser\Node as N;
-
 /**
  * Interface to implement Rules that visit the AST.
  *

src/App/DIC.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 namespace Lechimp\Dicto\App;
 
 use Lechimp\Dicto\App\RuleLoader;
-use Lechimp\Dicto\Rules\Ruleset;
 use Symfony\Component\Yaml\Yaml;
 use Pimple\Container;
 use PhpParser\ParserFactory;

src/App/Engine.php

Doc Comments +2 added lines, -2 removed lines

@@ -162,7 +162,7 @@ 
     }
 
     /**
-     * @param   mixed   $index
+     * @param   Insert|null   $index
      * @return  Graph\IndexDB
      */
     protected function force_graph_index_db($index) {
@@ -177,7 +177,7 @@ 
     }
 
     /**
-     * @param   mixed   $index
+     * @param   Insert   $index
      * @return  IndexDB
      */
     protected function force_app_index_db($index) {

src/Report/Generator.php

Doc Comments +1 added lines

@@ -90,6 +90,7 @@
      * If that is also not the case, we assume the class is in the global
      * namespace.
      *
+     * @param string $name
      * @return  string
      */
     protected function fully_qualified_class_name($name) {

src/Report/Queries.php

Doc Comments +1 added lines, -1 removed lines

@@ -257,7 +257,7 @@
      * Get information about a rule.
      *
      * @param   int $rule
-     * @return  array<string,string>    with keys 'rule', 'explanation'
+     * @return  integer|null    with keys 'rule', 'explanation'
      */
     public function rule_info($rule) {
         $b = $this->result_db->builder();