Completed
Push — master ( 5bfa5e...03b9ab )
by Richard
03:43
created
src/Rules/ContainText.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@
 block discarded – undo
14 14
 use Lechimp\Dicto\Indexer\Insert;
15 15
 use Lechimp\Dicto\Indexer\Location;
16 16
 use Lechimp\Dicto\Analysis\Query;
17
-use Lechimp\Dicto\Analysis\Violation;
18 17
 use \Lechimp\Dicto\Variables\Variable;
19 18
 
20 19
 /**
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -126,6 +126,9 @@
 block discarded – undo
126 126
             );
127 127
     }
128 128
 
129
+    /**
130
+     * @param boolean $negate
131
+     */
129 132
     protected function regexp_source_filter($regexp, $negate) {
130 133
         assert('is_string($regexp)');
131 134
         assert('is_bool($negate)');
Please login to merge, or discard this patch.
src/Graph/QueryImpl.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     }
98 98
 
99 99
     /**
100
-     * @return  Iterator <[Node,mixed]>
100
+     * @return  \Generator <[Node,mixed]>
101 101
      */
102 102
     protected function switch_run_command(\Iterator $nodes, $step) {
103 103
         list($cmd,$par) = $step;
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
     }
117 117
 
118 118
     /**
119
-     * @return  Iterator <[Node,mixed]>
119
+     * @return  \Generator <[Node,mixed]>
120 120
      */
121 121
     protected function run_expand(\Iterator $nodes, \Closure $clsr) {
122 122
         while ($nodes->valid()) {
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
     }
131 131
 
132 132
     /**
133
-     * @return  Iterator <[Node,mixed]>
133
+     * @return  \Generator <[Node,mixed]>
134 134
      */
135 135
     protected function run_extract(\Iterator $nodes, \Closure $clsr) {
136 136
         while ($nodes->valid()) {
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     }
146 146
 
147 147
     /**
148
-     * @return  Iterator <[Node,mixed]>
148
+     * @return  \Generator <[Node,mixed]>
149 149
      */
150 150
     protected function run_filter(\Iterator $nodes, Predicate $predicate) {
151 151
         $clsr = $predicate->compile();
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
     }
161 161
 
162 162
     /**
163
-     * @return  Iterator <[Node,mixed]>
163
+     * @return  \Generator <[Node,mixed]>
164 164
      */
165 165
     protected function add_result(\Iterator $nodes, &$result) {
166 166
         while ($nodes->valid()) {
Please login to merge, or discard this patch.
src/Report/Generator.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -90,6 +90,7 @@
 block discarded – undo
90 90
      * If that is also not the case, we assume the class is in the global
91 91
      * namespace.
92 92
      *
93
+     * @param string $name
93 94
      * @return  string
94 95
      */
95 96
     protected function fully_qualified_class_name($name) {
Please login to merge, or discard this patch.
src/Report/Queries.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
      * Get information about a run.
109 109
      *
110 110
      * @param   int $run
111
-     * @return  array<string,string>     with keys 'commit_hash'
111
+     * @return  integer     with keys 'commit_hash'
112 112
      */
113 113
     public function run_info($run) {
114 114
         $b = $this->result_db->builder();
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
      * Get information about a rule.
258 258
      *
259 259
      * @param   int $rule
260
-     * @return  array<string,string>    with keys 'rule', 'explanation'
260
+     * @return  integer|null    with keys 'rule', 'explanation'
261 261
      */
262 262
     public function rule_info($rule) {
263 263
         $b = $this->result_db->builder();
Please login to merge, or discard this patch.
src/App/Config.php 2 patches
Doc Comments   +15 added lines patch added patch discarded remove patch
@@ -68,6 +68,9 @@  discard block
 block discarded – undo
68 68
         return $tree_builder;
69 69
     }
70 70
 
71
+    /**
72
+     * @param \Symfony\Component\Config\Definition\Builder\NodeBuilder $c
73
+     */
71 74
     protected function add_project_node($c) {
72 75
         $c->arrayNode("project")
73 76
             ->children()
@@ -84,6 +87,9 @@  discard block
 block discarded – undo
84 87
         ->end();
85 88
     }
86 89
 
90
+    /**
91
+     * @param \Symfony\Component\Config\Definition\Builder\NodeBuilder $c
92
+     */
87 93
     protected function add_analysis_node($c) {
88 94
         $c->arrayNode("analysis")
89 95
             ->children()
@@ -103,6 +109,9 @@  discard block
 block discarded – undo
103 109
         ->end();
104 110
     }
105 111
 
112
+    /**
113
+     * @param \Symfony\Component\Config\Definition\Builder\NodeBuilder $c
114
+     */
106 115
     protected function add_rules_node($c) {
107 116
         $c->arrayNode("rules")
108 117
             ->children()
@@ -146,6 +155,9 @@  discard block
 block discarded – undo
146 155
         ->end();
147 156
     }
148 157
 
158
+    /**
159
+     * @param \Symfony\Component\Config\Definition\Builder\NodeBuilder $c
160
+     */
149 161
     protected function add_runtime_node($c) {
150 162
         $c->arrayNode("runtime")
151 163
             ->children()
@@ -157,6 +169,9 @@  discard block
 block discarded – undo
157 169
         ->end();
158 170
     }
159 171
 
172
+    /**
173
+     * @param \Symfony\Component\Config\Definition\Builder\NodeBuilder $c
174
+     */
160 175
     protected function add_reports_node($c) {
161 176
         $c->arrayNode("reports")
162 177
             ->prototype("array")
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,6 @@
 block discarded – undo
11 11
 namespace Lechimp\Dicto\App;
12 12
 
13 13
 use Lechimp\Dicto\App\RuleFromFSLoader;
14
-
15 14
 use Symfony\Component\Yaml\Yaml;
16 15
 use Pimple\Container;
17 16
 use PhpParser\ParserFactory;
Please login to merge, or discard this patch.