Name::arguments_are_valid() - Code Metrics - Inspection of "usage of properties of variables is more dynamic n..." - lechimp-p/dicto.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bd87f9...9971b9 )

by Richard

created 2016-08-02 19:54 UTC

Name::arguments_are_valid() A

↳ Parent: Name

Complexity

Conditions	4
Paths	3

Size

Total Lines	10
Code Lines	7

Duplication

Lines	10
Ratio	100 %

Code Coverage

Tests	5
CRAP Score	4.3731

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	10
loc	10
ccs	5
cts	7
cp	0.7143
rs	9.2
cc	4
eloc	7
nc	3
nop	1
crap	4.3731

<?php
/******************************************************************************
 * An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
 * 
 * Copyright (c) 2016, 2015 Richard Klees <[email protected]>
 *
 * This software is licensed under The MIT License. You should have received 
 * a copy of the license along with the code.
 */

namespace Lechimp\Dicto\Variables;

use Lechimp\Dicto\Definition\ArgumentParser;
use Doctrine\DBAL\Query\Expression\ExpressionBuilder;

/**
 * Name is a property, right?
 */
class Name extends Property {
    /**
     * Name of the property.
     *
     * @return  string
     */
    public function name() {

        return "name";
    }

    /**
     * Fetch arguments for the Property from a stream of tokens during parsing.
     *
     * @param   ArgumentParser  $parser
     * @return  array
     */
    public function fetch_arguments(ArgumentParser $parser) {
        $regexp = $parser->fetch_string();
        return array($regexp);
    }

    /**
     * Check if the given arguments are valid for the property.
     *
     * @param   array   $arguments
     * @return  bool 
     */
    public function arguments_are_valid(array &$arguments) {

        if (count($arguments) != 1) {
            return false;
        }
        $regexp = $arguments[0];
        if (!is_string($regexp) || @preg_match("%$regexp%", "") === false) {
            return false;
        }
        return true;
    }

    /**
     * Compile the property to an SQL expression.
     *
     * @param   array               $argument
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   ExpressionBuilder   $builder
     * @param   string              $table_name
     * @param   bool                $negate
     * @return  string|CompositeExpression
     */
    public function compile(array &$arguments, ExpressionBuilder $builder, $table_name, $negate = false) {
        assert('$this->arguments_are_valid($arguments)');
        if (!$negate) {
            return "$table_name.name REGEXP ".$builder->literal('^'.$arguments[0].'$');
        }
        else {
            return "$table_name.name NOT REGEXP ".$builder->literal('^'.$arguments[0].'$');
        }
    }
}


1			<?php
2			/******************************************************************************
3			* An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
4			*
5			* Copyright (c) 2016, 2015 Richard Klees <[email protected]>
6			*
7			* This software is licensed under The MIT License. You should have received
8			* a copy of the license along with the code.
9			*/
10
11			namespace Lechimp\Dicto\Variables;
12
13			use Lechimp\Dicto\Definition\ArgumentParser;
14			use Doctrine\DBAL\Query\Expression\ExpressionBuilder;
15
16			/**
17			* Name is a property, right?
18			*/
19			class Name extends Property {
20			/**
21			* Name of the property.
22			*
23			* @return string
24			*/
25	34		public function name() {
			1 ignored issue – show Coding Style Best Practice introduced 2016-08-02 20:00 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
26	34		return "name";
27			}
28
29			/**
30			* Fetch arguments for the Property from a stream of tokens during parsing.
31			*
32			* @param ArgumentParser $parser
33			* @return array
34			*/
35	7		public function fetch_arguments(ArgumentParser $parser) {
36	7		$regexp = $parser->fetch_string();
37	7		return array($regexp);
38			}
39
40			/**
41			* Check if the given arguments are valid for the property.
42			*
43			* @param array $arguments
44			* @return bool
45			*/
46	36	View Code Duplication	public function arguments_are_valid(array &$arguments) {
			0 ignored issues – show Duplication introduced 2016-08-02 20:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47	36		if (count($arguments) != 1) {
48			return false;
49			}
50	36		$regexp = $arguments[0];
51	36		if (!is_string($regexp) \|\| @preg_match("%$regexp%", "") === false) {
52			return false;
53			}
54	36		return true;
55			}
56
57			/**
58			* Compile the property to an SQL expression.
59			*
60			* @param array $argument
			0 ignored issues – show Documentation introduced 2016-08-02 20:00 UTC by Report Bug Copy Issue Report There is no parameter named `$argument`. Did you maybe mean `$arguments`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
61			* @param ExpressionBuilder $builder
62			* @param string $table_name
63			* @param bool $negate
64			* @return string\|CompositeExpression
65			*/
66	29		public function compile(array &$arguments, ExpressionBuilder $builder, $table_name, $negate = false) {
67	29		assert('$this->arguments_are_valid($arguments)');
68	29		if (!$negate) {
69	11		return "$table_name.name REGEXP ".$builder->literal('^'.$arguments[0].'$');
70			}
71			else {
72	18		return "$table_name.name NOT REGEXP ".$builder->literal('^'.$arguments[0].'$');
73			}
74			}
75			}
76

lechimp-p / dicto.php

Push — master ( bd87f9...9971b9 )

Name::arguments_are_valid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like