Lechimp\Dicto\Variables\Name

Complexity

Total Complexity

8

Size/Duplication

Total Lines	57
Duplicated Lines	17.54 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

88.24%

Importance

Changes	2
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	name()	0	3	1
A	fetch_arguments()	0	4	1
A	arguments_are_valid()	10	10	4
A	compile()	0	9	2

<?php
/******************************************************************************
 * An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
 * 
 * Copyright (c) 2016, 2015 Richard Klees <richard.klees@rwth-aachen.de>
 *
 * This software is licensed under The MIT License. You should have received 
 * a copy of the license along with the code.
 */

namespace Lechimp\Dicto\Variables;

use Lechimp\Dicto\Definition\ArgumentParser;
use Doctrine\DBAL\Query\Expression\ExpressionBuilder;

/**
 * Name is a property, right?
 */
class Name extends Property {
    /**
     * Name of the property.
     *
     * @return  string
     */
    public function name() {

Please use __construct() instead of a PHP4-style constructor that is named after the class.

        return "name";
    }

    /**
     * Fetch arguments for the Property from a stream of tokens during parsing.
     *
     * @param   ArgumentParser  $parser
     * @return  array
     */
    public function fetch_arguments(ArgumentParser $parser) {
        $regexp = $parser->fetch_string();
        return array($regexp);
    }

    /**
     * Check if the given arguments are valid for the property.
     *
     * @param   array   $arguments
     * @return  bool 
     */
    public function arguments_are_valid(array &$arguments) {

This method seems to be duplicated in your project.

        if (count($arguments) != 1) {
            return false;
        }
        $regexp = $arguments[0];
        if (!is_string($regexp) || @preg_match("%$regexp%", "") === false) {
            return false;
        }
        return true;
    }

    /**
     * Compile the property to an SQL expression.
     *
     * @param   array               $argument

There is no parameter named $argument. Did you maybe mean $arguments?

     * @param   ExpressionBuilder   $builder
     * @param   string              $table_name
     * @param   bool                $negate
     * @return  string|CompositeExpression
     */
    public function compile(array &$arguments, ExpressionBuilder $builder, $table_name, $negate = false) {
        assert('$this->arguments_are_valid($arguments)');
        if (!$negate) {
            return "$table_name.name REGEXP ".$builder->literal('^'.$arguments[0].'$');
        }
        else {
            return "$table_name.name NOT REGEXP ".$builder->literal('^'.$arguments[0].'$');
        }
    }
}