Lavibi\Popoya\Validator

Complexity

Total Complexity

9

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	isOptional()	0	3	1
A	isRequired()	0	3	1
A	isValid()	0	13	5
A	add()	0	9	2

<?php

namespace Lavibi\Popoya;

class Validator
{
    const IS_REQUIRED = 1;

    const IS_OPTIONAL = 0;

    /**
     * @var ValidatorChain
     */
    protected $chain;

    /**
     * @var ValidatorChain[]
     */
    protected $dataValidatorChain;

    /**
     * Index array of data list need to validate
     *
     * 1 is required
     * 0 is optional
     *
     * @var []

The doc comment [] at position 0 could not be parsed: Unknown type name '[' at position 0 in [].

     */
    protected $data;

    /**
     * @var mixed
     */
    protected $values;

    /**
     * @param $name
     *
     * @return ValidatorChain
     */
    public function isRequired($name)
    {
        return $this->add($name, self::IS_REQUIRED);
    }

    /**
     * @param $name
     *
     * @return ValidatorChain
     */
    public function isOptional($name)
    {
        return $this->add($name, self::IS_OPTIONAL);
    }

    public function isValid($values)
    {
        foreach ($this->data as $name => $isRequired) {
            if ($isRequired && !isset($this->$values[$name])) {
                return false;
            }

            if (isset($this->$values[$name])) {
                $result = $this->dataValidatorChain[$name]->isValid($this->$values[$name]);

The assignment to $result is dead and can be removed.

            }
        }

        return true;
    }

    /**
     * @param $name
     * @param $isRequired
     *
     * @return ValidatorChain
     */
    public function add($name, $isRequired)
    {
        $this->data[$name] = $isRequired;

        if (!isset($dataValidatorChain[$name])) {

The variable $dataValidatorChain seems to never exist and therefore isset should always be false.

            $this->dataValidatorChain[$name] = new ValidatorChain();
        }

        return $this->dataValidatorChain[$name];
    }
}