Validator::isRequired() - Code Metrics - Inspection of "Rename UploadFile class to Upload" - lavibi/popoya - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 20faea...42b488 )

by Lee

created 2019-04-01 03:46 UTC

Validator::isRequired() A

↳ Parent: Validator

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace Lavibi\Popoya;

class Validator
{
    const IS_REQUIRED = 1;

    const IS_OPTIONAL = 0;

    /**
     * @var ValidatorChain
     */
    protected $chain;

    /**
     * @var ValidatorChain[]
     */
    protected $dataValidatorChain;

    /**
     * Index array of data list need to validate
     *
     * 1 is required
     * 0 is optional
     *
     * @var []

     */
    protected $data;

    /**
     * @var mixed
     */
    protected $values;

    /**
     * @param $name
     *
     * @return ValidatorChain
     */
    public function isRequired($name)
    {
        return $this->add($name, self::IS_REQUIRED);
    }

    /**
     * @param $name
     *
     * @return ValidatorChain
     */
    public function isOptional($name)
    {
        return $this->add($name, self::IS_OPTIONAL);
    }

    public function isValid($values)
    {
        foreach ($this->data as $name => $isRequired) {
            if ($isRequired && !isset($this->$values[$name])) {
                return false;
            }

            if (isset($this->$values[$name])) {
                $result = $this->dataValidatorChain[$name]->isValid($this->$values[$name]);

            }
        }

        return true;
    }

    /**
     * @param $name
     * @param $isRequired
     *
     * @return ValidatorChain
     */
    public function add($name, $isRequired)
    {
        $this->data[$name] = $isRequired;

        if (!isset($dataValidatorChain[$name])) {

            $this->dataValidatorChain[$name] = new ValidatorChain();
        }

        return $this->dataValidatorChain[$name];
    }
}


1			<?php
2
3			namespace Lavibi\Popoya;
4
5			class Validator
6			{
7			const IS_REQUIRED = 1;
8
9			const IS_OPTIONAL = 0;
10
11			/**
12			* @var ValidatorChain
13			*/
14			protected $chain;
15
16			/**
17			* @var ValidatorChain[]
18			*/
19			protected $dataValidatorChain;
20
21			/**
22			* Index array of data list need to validate
23			*
24			* 1 is required
25			* 0 is optional
26			*
27			* @var []
			0 ignored issues – show Documentation Bug introduced 2019-04-01 03:47 UTC by Report Bug Copy Issue Report The doc comment `[]` at position `0` could not be parsed: Unknown type name '[' at position 0 in []. Loading history...
28			*/
29			protected $data;
30
31			/**
32			* @var mixed
33			*/
34			protected $values;
35
36			/**
37			* @param $name
38			*
39			* @return ValidatorChain
40			*/
41			public function isRequired($name)
42			{
43			return $this->add($name, self::IS_REQUIRED);
44			}
45
46			/**
47			* @param $name
48			*
49			* @return ValidatorChain
50			*/
51			public function isOptional($name)
52			{
53			return $this->add($name, self::IS_OPTIONAL);
54			}
55
56			public function isValid($values)
57			{
58			foreach ($this->data as $name => $isRequired) {
59			if ($isRequired && !isset($this->$values[$name])) {
60			return false;
61			}
62
63			if (isset($this->$values[$name])) {
64			$result = $this->dataValidatorChain[$name]->isValid($this->$values[$name]);
			0 ignored issues – show Unused Code introduced 2019-04-01 03:47 UTC by Report Bug Copy Issue Report The assignment to `$result` is dead and can be removed. Loading history...
65			}
66			}
67
68			return true;
69			}
70
71			/**
72			* @param $name
73			* @param $isRequired
74			*
75			* @return ValidatorChain
76			*/
77			public function add($name, $isRequired)
78			{
79			$this->data[$name] = $isRequired;
80
81			if (!isset($dataValidatorChain[$name])) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-04-01 03:47 UTC by Report Bug Copy Issue Report The variable `$dataValidatorChain` seems to never exist and therefore `isset` should always be `false`. Loading history...
82			$this->dataValidatorChain[$name] = new ValidatorChain();
83			}
84
85			return $this->dataValidatorChain[$name];
86			}
87			}
88

lavibi / popoya

Push — master ( 20faea...42b488 )

Validator::isRequired() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like