laudeco / bbc-dolibarr-flightlog

Infrastructure/Common/Routes/guards.conf.php

Unused Use Statements -3 removed lines

@@ -1,9 +1,6 @@
 <?php
 
-use FlightLog\Http\Web\Controller\DamageController;
-use FlightLog\Http\Web\Controller\FlightController;
 use FlightLog\Infrastructure\Common\Routes\Guard;
-use FlightLog\Infrastructure\Common\Routes\Route;
 
 global $db;
 

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 global $db;
 
 return [
-    new Guard('get_one_damage', function(User $user){
+    new Guard('get_one_damage', function(User $user) {
         return $user->rights->flightlog->vol->financial;
     }),
 ];

Http/Web/Controller/AddFlightDamageController.php

Spacing +10 added lines, -10 removed lines

@@ -19,16 +19,16 @@ 
     /**
      * Display the form.
      */
-    public function view(){
+    public function view() {
         $id = $this->request->getParam('id');
 
-        if($id === null){
+        if ($id === null) {
             print '<p>Paramètre non fournis.</p>';
             return;
         }
 
         $flight = new \Bbcvols($this->db);
-        if($flight->fetch($id) <= 0){
+        if ($flight->fetch($id) <= 0) {
             print '<p>Vol non trouvé</p>';
             return;
         }
@@ -39,24 +39,24 @@ 
         $form = new DamageCreationForm('damage_creation', $this->db);
         $form->bind($command);
 
-        if($this->request->isPost()){
+        if ($this->request->isPost()) {
             $form->setData($this->request->getPostParameters());
 
-            if(!$form->validate()){
+            if (!$form->validate()) {
                 return $this->render('flight_damage/form.php', [
                     'form' => $form,
                 ]);
             }
 
-            try{
+            try {
                 $this->handle($form->getObject());
-            }catch(\Exception $e){
+            } catch (\Exception $e) {
                 print $e->getMessage();
                 dol_syslog($e->getMessage(), LOG_ERR);
             }
 
 
-            return $this->redirect($_SERVER["PHP_SELF"].'?id='.$id);
+            return $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $id);
         }
 
         return $this->render('flight_damage/form.php', [
@@ -77,14 +77,14 @@ 
     /**
      * @return CreateDamageCommandHandler
      */
-    private function getHandler(){
+    private function getHandler() {
         return new CreateDamageCommandHandler($this->db, $this->getDamageRepository());
     }
 
     /**
      * @return FlightDamageRepository
      */
-    private function getDamageRepository(){
+    private function getDamageRepository() {
         return new FlightDamageRepository($this->db);
     }
 

Http/Web/Controller/DamageController.php

Spacing +6 added lines, -6 removed lines

@@ -13,14 +13,14 @@ 
     /**
      * @return GetDamageQueryRepository
      */
-    private function getDamageRepository(){
+    private function getDamageRepository() {
         return new GetDamageQueryRepository($this->db);
     }
 
-    public function view(){
+    public function view() {
         $damageId = $this->request->getParam('id');
 
-        try{
+        try {
             $damage = $this->getDamageRepository()->query($damageId);
 
             $flight = new \Bbcvols($this->db);
@@ -31,16 +31,16 @@ 
                 'form' => new Form($this->db),
                 'flight' => $flight
             ]);
-        }catch (\Exception $e){
+        } catch (\Exception $e) {
             echo $e->getMessage();
         }
     }
 
-    public function invoice(){
+    public function invoice() {
         $damageId = $this->request->getParam('id');
 
 
 
-        return $this->redirect($_SERVER["PHP_SELF"].'?id='.$damageId);
+        return $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $damageId);
     }
 }
\ No newline at end of file

Http/Web/Controller/WebController.php

Spacing +4 added lines, -4 removed lines

@@ -32,19 +32,19 @@
      *
      * @return Response
      */
-    protected function render($template, array $variables = []){
+    protected function render($template, array $variables = []) {
 
-        foreach($variables as $variableName => $variableValue){
+        foreach ($variables as $variableName => $variableValue) {
             $GLOBALS[$variableName] = $variableValue;
         }
 
-        return new Response(__DIR__.'/../templates/'.$template);
+        return new Response(__DIR__ . '/../templates/' . $template);
     }
 
     /**
      * @param string $html
      */
-    protected function renderHtml($html){
+    protected function renderHtml($html) {
         print $html;
     }
 

Http/Web/Controller/FlightController.php

Spacing +2 added lines, -2 removed lines

@@ -6,9 +6,9 @@
 
 final class FlightController extends WebController
 {
-    public function view(){
+    public function view() {
         $id = $this->request->getParam('id');
-        return $this->redirect(DOL_URL_ROOT.'/flightlog/card.php?id='.$id);
+        return $this->redirect(DOL_URL_ROOT . '/flightlog/card.php?id=' . $id);
     }
 
 }
\ No newline at end of file

Http/Web/Response/Redirect.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      *
      * @return Redirect
      */
-    public static function create($url){
+    public static function create($url) {
         return new self($url);
     }
 

command/CreatePilotYearBillCommandHandler.php

Spacing +3 added lines, -3 removed lines

@@ -250,7 +250,7 @@ 
      */
     private function addOrderDiscount($order, $pilotFlightCount, $service, $year)
     {
-        $price = $pilotFlightCount->getCost()->getValue()/(1+$service->tva_tx/100);
+        $price = $pilotFlightCount->getCost()->getValue() / (1 + $service->tva_tx / 100);
         $pu_ht = price2num($price, 'MU');
         $desc = $year . " - " . $service->label . " - (" . $pilotFlightCount->getCount() . " * " . $pilotFlightCount->getFactor() . ")";
 
@@ -281,7 +281,7 @@ 
             return;
         }
 
-        $pointsHt = $command->getAdditionalBonus()/(1+6/100);
+        $pointsHt = $command->getAdditionalBonus() / (1 + 6 / 100);
         $desc = sprintf("%s - %s", $command->getYear(), $command->getBonusAdditionalMessage());
 
         $discountid = $this->getCompany($object->socid)->set_remise_except($pointsHt, $this->user, $desc, 6);
@@ -301,7 +301,7 @@ 
     {
         $price = $damage->getCost()->addCost($invoicedDamage->getCost())->getValue();
 
-        if($price <= 0 ){
+        if ($price <= 0) {
             return;
         }
 

card_tab_damage.php

Spacing +9 added lines, -9 removed lines

@@ -49,7 +49,7 @@ 
 
 $id = GETPOST('id', 'int') ?: GETPOST('idBBC_vols', 'int');
 $action = GETPOST('action', 'alpha');
-$permissiondellink=$user->rights->flightlog->vol->financial;
+$permissiondellink = $user->rights->flightlog->vol->financial;
 
 $object = new Bbcvols($db);
 
@@ -57,8 +57,8 @@ 
 $extralabels = $extrafields->fetch_name_optionals_label($object->table_element);
 
 // Load object
-include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php';  // Must be include, not include_once  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
-include DOL_DOCUMENT_ROOT.'/core/actions_dellink.inc.php';
+include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php'; // Must be include, not include_once  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
+include DOL_DOCUMENT_ROOT . '/core/actions_dellink.inc.php';
 
 // Initialize technical object to manage hooks of modules. Note that conf->hooks_modules contains array array
 $hookmanager->initHooks(array('bbcvols'));
@@ -85,13 +85,13 @@ 
         FLIGHTLOG_ACTION_HANDLE_ADD_DAMAGE => [AddFlightDamageController::class, 'view'],
     ];
 
-    if(isset($routes[$action])){
+    if (isset($routes[$action])) {
         $controllerName = $routes[$action][0];
         $actionName = $routes[$action][1];
 
         $response = call_user_func([new $controllerName($db), $actionName]);
 
-        if($response instanceof \FlightLog\Http\Web\Response\Redirect){
+        if ($response instanceof \FlightLog\Http\Web\Response\Redirect) {
             if (headers_sent()) {
                 echo(sprintf("<script>location.href='%s'</script>", $response->getUrl()));
                 exit;
@@ -102,7 +102,7 @@ 
         }
 
         include $response->getTemplate();
-    }else{
+    } else {
         echo 'Route non trouvée.';
     }
 ?>
@@ -114,13 +114,13 @@ 
 // Buttons
 print '<div class="tabsAction">' . "\n";
 
-if($user->rights->flightlog->vol->financial){
-    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/card_tab_damage.php?id=' . $object->id.'&action='.FLIGHTLOG_ACTION_ADD_DAMAGE.'">' . $langs->trans("Ajouter") . '</a></div>' . "\n";
+if ($user->rights->flightlog->vol->financial) {
+    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/card_tab_damage.php?id=' . $object->id . '&action=' . FLIGHTLOG_ACTION_ADD_DAMAGE . '">' . $langs->trans("Ajouter") . '</a></div>' . "\n";
 }
 
 print '</div>' . "\n";
 
-if($user->rights->flightlog->vol->financial){
+if ($user->rights->flightlog->vol->financial) {
     print '<div class="fichecenter"><div class="fichehalfleft">';
     $form->showLinkedObjectBlock($object);
     print '</div></div>';

Braces +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
         }
 
         include $response->getTemplate();
-    }else{
+    } else{
         echo 'Route non trouvée.';
     }
 ?>

index.php

Spacing +3 added lines, -3 removed lines

@@ -53,7 +53,7 @@ 
 $routesGuards = require './Infrastructure/Common/Routes/guards.conf.php';
 
 $response = null;
-try{
+try {
     $routeName = GETPOST('r');
 
     $routeManager = new \FlightLog\Infrastructure\Common\Routes\RouteManager($db);
@@ -62,7 +62,7 @@ 
 
     $response = $routeManager->__invoke($routeName, $user);
 
-    if($response instanceof \FlightLog\Http\Web\Response\Redirect){
+    if ($response instanceof \FlightLog\Http\Web\Response\Redirect) {
         if (headers_sent()) {
             echo(sprintf("<script>location.href='%s'</script>", $response->getUrl()));
             exit;
@@ -72,7 +72,7 @@ 
         exit;
     }
 
-}catch (\Exception $e){
+} catch (\Exception $e) {
     dol_syslog($e->getMessage(), LOG_ERR);
     $response = new \FlightLog\Http\Web\Response\Response($e->getMessage());
 }

Braces +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
         exit;
     }
 
-}catch (\Exception $e){
+} catch (\Exception $e){
     dol_syslog($e->getMessage(), LOG_ERR);
     $response = new \FlightLog\Http\Web\Response\Response($e->getMessage());
 }