laudeco / bbc-dolibarr-flightlog

Http/Web/Controller/PilotEditController.php

Unused Use Statements -3 removed lines

@@ -4,12 +4,9 @@
 namespace FlightLog\Http\Web\Controller;
 
 
-use FlightLog\Application\Damage\Command\CreateDamageCommand;
-use FlightLog\Application\Damage\Command\CreateDamageCommandHandler;
 use FlightLog\Application\Pilot\Command\CreateUpdatePilotInformationCommand;
 use FlightLog\Application\Pilot\Command\CreateUpdatePilotInformationCommandHandler;
 use FlightLog\Domain\Pilot\ValueObject\PilotId;
-use FlightLog\Http\Web\Form\DamageCreationForm;
 use FlightLog\Http\Web\Form\PilotForm;
 use FlightLog\Infrastructure\Pilot\Repository\PilotRepository;
 

Spacing +9 added lines, -9 removed lines

@@ -16,17 +16,17 @@ 
 final class PilotEditController extends WebController
 {
 
-    public function index(){
+    public function index() {
         $id = $this->request->getParam('id');
 
-        if($id === null){
+        if ($id === null) {
             $this->renderHtml('<p>Paramètre ID non fournis.</p>');
             return;
         }
 
         $command = new CreateUpdatePilotInformationCommand($id);
 
-        if($this->getPilotRepository()->exist(PilotId::create($id))){
+        if ($this->getPilotRepository()->exist(PilotId::create($id))) {
             $command->fromPilot($this->getPilotRepository()->getById(PilotId::create($id)));
         }
 
@@ -36,24 +36,24 @@ 
         $user = new \User($this->db);
         $user->fetch($id);
 
-        if($this->request->isPost()){
+        if ($this->request->isPost()) {
             $form->setData($this->request->getPostParameters());
 
-            if(!$form->validate()){
+            if (!$form->validate()) {
                 return $this->render('pilot/edit.phtml', [
                     'form' => $form,
                 ]);
             }
 
-            try{
+            try {
                 $this->handle($form->getObject());
-            }catch(\Exception $e){
+            } catch (\Exception $e) {
                 print $e->getMessage();
                 dol_syslog($e->getMessage(), LOG_ERR);
             }
 
 
-            return $this->redirect($_SERVER["PHP_SELF"].'?id='.$id.'&r=edit_pilot');
+            return $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $id . '&r=edit_pilot');
         }
 
         return $this->render('pilot/edit.phtml', [
@@ -75,7 +75,7 @@ 
     /**
      * @return CreateUpdatePilotInformationCommandHandler()
      */
-    private function getHandler(){
+    private function getHandler() {
         return new CreateUpdatePilotInformationCommandHandler($this->getPilotRepository());
     }
 

Braces +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 
             try{
                 $this->handle($form->getObject());
-            }catch(\Exception $e){
+            } catch(\Exception $e){
                 print $e->getMessage();
                 dol_syslog($e->getMessage(), LOG_ERR);
             }

Http/Web/Form/PilotForm.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
     }
 
     /**
-     * @return CreateUpdatePilotInformationCommand|\stdClass|null
+     * @return CreateUpdatePilotInformationCommand
      */
     public function getObject()
     {

Unused Use Statements -3 removed lines

@@ -4,7 +4,6 @@ 
 namespace FlightLog\Http\Web\Form;
 
 
-use FlightLog\Application\Damage\Command\CreateDamageCommand;
 use FlightLog\Application\Pilot\Command\CreateUpdatePilotInformationCommand;
 use flightlog\form\Csrf;
 use flightlog\form\Form;
@@ -13,8 +12,6 @@ 
 use flightlog\form\Input;
 use flightlog\form\InputCheckBox;
 use flightlog\form\InputDate;
-use flightlog\form\Number;
-use flightlog\form\UserSelect;
 
 final class PilotForm extends Form
 {

Http/Web/Controller/PilotListController.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 final class PilotListController extends WebController
 {
 
-    public function index(){
+    public function index() {
 
         $members = $this->getPilotRepository()->query();
 

class/Common/ValueObject/Id.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      *
      * @return Id|static
      */
-    public static function create($id){
+    public static function create($id) {
         return new self($id);
     }
 

class/Pilot/Pilot.php

Spacing +1 added lines, -1 removed lines

@@ -526,7 +526,7 @@
 
     public function attributeRadioLicenceDate(RadioLicenceDate $value)
     {
-        $this->radioLicenceDate =  $value;
+        $this->radioLicenceDate = $value;
     }
 
     public function attributeLastTrainingFirstHelpDate(LastTrainingDate $value)

class/Pilot/ValueObject/IsOwner.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
             return self::no();
         }
 
-        if (is_numeric($value) || is_int($value) || (int)$value == $value) {
+        if (is_numeric($value) || is_int($value) || (int) $value == $value) {
             return new self($value == 1);
         }
 

flightlog.inc.php

Spacing +2 added lines, -2 removed lines

@@ -172,13 +172,13 @@
                 continue;
             }
 
-            if($match == ".." || $match == "." || substr($match, 0,1) === '.'){
+            if ($match == ".." || $match == "." || substr($match, 0, 1) === '.') {
                 continue;
             }
 
             $element = $root . DIRECTORY_SEPARATOR . $match;
 
-            if(substr_count($element, '/', 3) >= 1){
+            if (substr_count($element, '/', 3) >= 1) {
                 scan($element);
             }
 

Form/InputCheckBox.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
         parent::__construct($name, FormElementInterface::TYPE_CHECKBOX, $options);
     }
 
-    public function checkedValue(){
+    public function checkedValue() {
         return 1;
     }
 }
\ No newline at end of file

Infrastructure/Common/Repository/AbstractDomainRepository.php

Spacing +14 added lines, -14 removed lines

@@ -23,7 +23,7 @@ 
     public function __construct(\DoliDB $db, $tableName)
     {
         $this->db = $db;
-        $this->tableName = strpos($tableName, MAIN_DB_PREFIX) === 0 ? $tableName : MAIN_DB_PREFIX.$tableName;
+        $this->tableName = strpos($tableName, MAIN_DB_PREFIX) === 0 ? $tableName : MAIN_DB_PREFIX . $tableName;
     }
 
     /**
@@ -33,7 +33,7 @@ 
      *
      * @throws \Exception
      */
-    protected function write(array $elements){
+    protected function write(array $elements) {
         $columns = join(',', array_keys($elements));
         $values = join(',', array_map([$this, 'escape'], array_values($elements)));
 
@@ -44,7 +44,7 @@ 
             $lasterror = $this->db->lasterror();
             dol_syslog(__METHOD__ . ' ' . $lasterror, LOG_ERR);
             $this->db->rollback();
-            throw new \Exception("Repository error - ".$lasterror);
+            throw new \Exception("Repository error - " . $lasterror);
         }
 
         $id = $this->db->last_insert_id($this->tableName);
@@ -57,16 +57,16 @@ 
      *
      * @return int|string|null
      */
-    private function escape($value){
-        if(is_null($value)){
+    private function escape($value) {
+        if (is_null($value)) {
             return 'NULL';
         }
 
-        if(is_bool($value)){
-            return (int)$value;
+        if (is_bool($value)) {
+            return (int) $value;
         }
 
-        return is_string($value) ? "'".$this->db->escape($value)."'" : $value ;
+        return is_string($value) ? "'" . $this->db->escape($value) . "'" : $value;
     }
 
     /**
@@ -79,18 +79,18 @@ 
     {
         $sqlModifications = [];
 
-        foreach($elements as $field => $value){
+        foreach ($elements as $field => $value) {
             $sqlModifications[] = sprintf('%s=%s', $field, $this->escape($value));
         }
 
         $this->db->begin();
-        $resql = $this->db->query(sprintf('UPDATE %s SET %s WHERE '.$idCol.' = %s ', $this->tableName, join(',',$sqlModifications), $id));
+        $resql = $this->db->query(sprintf('UPDATE %s SET %s WHERE ' . $idCol . ' = %s ', $this->tableName, join(',', $sqlModifications), $id));
 
         if (!$resql) {
             $lasterror = $this->db->lasterror();
             dol_syslog(__METHOD__ . ' ' . $lasterror, LOG_ERR);
             $this->db->rollback();
-            throw new \Exception("Repository error - ".$lasterror);
+            throw new \Exception("Repository error - " . $lasterror);
         }
 
         $this->db->commit();
@@ -104,8 +104,8 @@ 
      *
      * @return array|null
      */
-    protected function get($id, $idCol = 'rowid'){
-        $sql = sprintf('SELECT * FROM %s WHERE '.$idCol.' = %s', $this->tableName, $id );
+    protected function get($id, $idCol = 'rowid') {
+        $sql = sprintf('SELECT * FROM %s WHERE ' . $idCol . ' = %s', $this->tableName, $id);
 
         $resql = $this->db->query($sql);
         if (!$resql) {
@@ -117,7 +117,7 @@ 
             return null;
         }
 
-        for($i = 0; $i < $num ; $i++) {
+        for ($i = 0; $i < $num; $i++) {
             return $this->db->fetch_array($resql);
         }