laudeco / bbc-dolibarr-flightlog

class/bbctypes.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -645,7 +645,7 @@
     }
 
     /**
-     * @return array|BbctypesLine[]
+     * @return BbctypesLine[]
      */
     public function getLines()
     {

Spacing +1 added lines, -1 removed lines

@@ -733,7 +733,7 @@
      */
     public function getActive()
     {
-        return (boolean)$this->active;
+        return (boolean) $this->active;
     }
 
     /**

Form/FlightTypeSelect.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
      */
     private function buildOptions()
     {
-        foreach($this->flightType->getLines() as $currentFlightType){
+        foreach ($this->flightType->getLines() as $currentFlightType) {
             $this->addValueOption($currentFlightType->getId(), $currentFlightType->getLabel());
         }
     }

validators/AbstractValidator.php

Spacing +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
      *
      * @return array|string[]
      */
-    public function getError($field){
-        if(!$this->hasError($field)){
+    public function getError($field) {
+        if (!$this->hasError($field)) {
             return [];
         }
 

Form/Form.php

Spacing +16 added lines, -16 removed lines

@@ -78,7 +78,7 @@ 
     /**
      * @inheritDoc
      */
-    public function getOptions(){
+    public function getOptions() {
         return $this->options;
     }
 
@@ -98,18 +98,18 @@ 
      */
     public function validate()
     {
-        if(!$this->validator){
+        if (!$this->validator) {
             return true;
         }
 
-        if(null === $this->object){
+        if (null === $this->object) {
             throw new \InvalidArgumentException('Object not bound');
         }
 
         $validation = $this->validator->isValid($this->object, $_REQUEST);
         
-        if(!$validation){
-            foreach($this->elements as $fieldName => $field){
+        if (!$validation) {
+            foreach ($this->elements as $fieldName => $field) {
                 $field->setErrors($this->validator->getError($fieldName));
             }
         }
@@ -120,7 +120,7 @@ 
     /**
      * @return array|string[]
      */
-    public function getErrorMessages(){
+    public function getErrorMessages() {
         return $this->validator->getErrors();
     }
 
@@ -141,10 +141,10 @@ 
      */
     public function bind($object)
     {
-        foreach($this->elements as $element){
+        foreach ($this->elements as $element) {
             $name = $this->camelCase($element->getName());
-            $methodName = 'get'.$name;
-            if(!method_exists($object, $methodName)){
+            $methodName = 'get' . $name;
+            if (!method_exists($object, $methodName)) {
                 continue;
             }
 
@@ -161,24 +161,24 @@ 
      */
     public function setData(array $data)
     {
-        foreach($data as $fieldName => $currentData){
-            if(!key_exists($fieldName, $this->elements) || $this->elements[$fieldName]->isDisabled()){
+        foreach ($data as $fieldName => $currentData) {
+            if (!key_exists($fieldName, $this->elements) || $this->elements[$fieldName]->isDisabled()) {
                 continue;
             }
 
             $this->elements[$fieldName]->setValue($currentData);
 
-            $methodName = 'set'.$this->camelCase($fieldName);
-            if(null === $this->object){
+            $methodName = 'set' . $this->camelCase($fieldName);
+            if (null === $this->object) {
                 continue;
             }
 
-            if(method_exists($this->object, $methodName)){
+            if (method_exists($this->object, $methodName)) {
                 $this->object->{$methodName}($currentData);
                 continue;
             }
 
-            if(property_exists($this->object, $fieldName)){
+            if (property_exists($this->object, $fieldName)) {
                 $this->object->{$fieldName} = $currentData;
                 continue;
             }
@@ -200,7 +200,7 @@ 
      */
     public function getElement($elementName)
     {
-        if(!key_exists($elementName, $this->elements)){
+        if (!key_exists($elementName, $this->elements)) {
             throw new \InvalidArgumentException(sprintf('Element %s not found ', $elementName));
         }
 

Doc Comments +2 added lines, -1 removed lines

@@ -95,6 +95,7 @@ 
 
     /**
      * @inheritDoc
+     * @param string $fieldName
      */
     public function remove($fieldName)
     {
@@ -142,7 +143,7 @@ 
     }
 
     /**
-     * @param null|\ValidatorInterface $validator
+     * @param ValidatorInterface $validator
      *
      * @return Form
      */

Form/Select.php

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
      *
      * @return $this
      */
-    public function addValueOption($key, $value){
+    public function addValueOption($key, $value) {
         $this->valueOptions[$key] = $value;
         return $this;
     }
@@ -63,7 +63,7 @@ 
     {
         parent::setValue($value);
 
-        if(!isset($this->valueOptions[$value])){
+        if (!isset($this->valueOptions[$value])) {
             $this->valueOptions[$value] = empty($value) ? ' ' : $value;
         }
     }

Form/BalloonSelect.php

Spacing +6 added lines, -6 removed lines

@@ -31,12 +31,12 @@
     private function buildOptions()
     {
         $sql = "SELECT";
-        $sql.= " t.rowid,";
-        $sql.= " t.immat,";
-        $sql.= " t.is_disable";
-        $sql.= " FROM llx_bbc_ballons as t";
-        $sql.= " WHERE t.is_disable = 0";
-        $sql.= " ORDER BY t.immat";
+        $sql .= " t.rowid,";
+        $sql .= " t.immat,";
+        $sql .= " t.is_disable";
+        $sql .= " FROM llx_bbc_ballons as t";
+        $sql .= " WHERE t.is_disable = 0";
+        $sql .= " ORDER BY t.immat";
 
         $resql = $this->db->query($sql);
         if ($resql) {

Form/BaseInput.php

Spacing +6 added lines, -6 removed lines

@@ -79,7 +79,7 @@ 
     /**
      * @inheritdoc
      */
-    public function getId(){
+    public function getId() {
         return $this->getOption('id') ?: $this->getName();
     }
 
@@ -115,7 +115,7 @@ 
     /**
      * @return $this
      */
-    public function required(){
+    public function required() {
         $this->options['attr']['required'] = 'required';
 
         return $this;
@@ -124,7 +124,7 @@ 
     /**
      * @return $this
      */
-    public function disable(){
+    public function disable() {
         $this->options['attr']['disabled'] = 'disabled';
         return $this;
     }
@@ -132,7 +132,7 @@ 
     /**
      * @inheritdoc
      */
-    public function isDisabled(){
+    public function isDisabled() {
         return isset($this->options['attr']['disabled']);
     }
 
@@ -141,8 +141,8 @@ 
      *
      * @return string|int|boolean|null
      */
-    public function getOption($option){
-        if(!isset($this->options[$option])){
+    public function getOption($option) {
+        if (!isset($this->options[$option])) {
             return null;
         }
 

Form/SimpleFormRenderer.php

Spacing +3 added lines, -3 removed lines

@@ -70,7 +70,7 @@ 
                 $select = $element;
                 $html = $this->renderSelectElement($select);
 
-                if(isset($options['ajax']) && $options['ajax']){
+                if (isset($options['ajax']) && $options['ajax']) {
                     $html .= ajax_combobox($element->getName());
                 }
 
@@ -79,7 +79,7 @@ 
             default:
                 return sprintf('<input type="%s" class="%s" name="%s" value="%s" %s />',
                     $element->getType(),
-                    ' flat '.($element->hasError() ? 'error' : ''),
+                    ' flat ' . ($element->hasError() ? 'error' : ''),
                     $element->getName(),
                     $element->getValue(),
                     $this->formatOptions($element->getOptions())
@@ -119,7 +119,7 @@ 
      */
     private function renderSelectElement(Select $element)
     {
-        $selectElement = sprintf('<select id="%s" class="%s" name="%s" >', $element->getId(),$element->hasError() ? 'error' : '', $element->getName());
+        $selectElement = sprintf('<select id="%s" class="%s" name="%s" >', $element->getId(), $element->hasError() ? 'error' : '', $element->getName());
 
         if ($element->getValueOptions()) {
             foreach ($element->getValueOptions() as $optionValue => $optionLabel) {

card.php

Spacing +21 added lines, -21 removed lines

@@ -116,7 +116,7 @@ 
 $extralabels = $extrafields->fetch_name_optionals_label($object->table_element);
 
 // Load object
-include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php';  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
+include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php'; // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
 include DOL_DOCUMENT_ROOT . '/core/actions_dellink.inc.php';
 
 // Initialize technical object to manage hooks of modules. Note that conf->hooks_modules contains array array
@@ -145,7 +145,7 @@ 
 
 $parameters = array();
 $reshook = $hookmanager->executeHooks('doActions', $parameters, $object,
-    $action);    // Note that $action and $object may have been modified by some hooks
+    $action); // Note that $action and $object may have been modified by some hooks
 if ($reshook < 0) {
     setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
 }
@@ -251,7 +251,7 @@ 
 
 
 // Part to edit record
-if (($user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id )) && ($id || $ref) && $action == 'edit'): ?>
+if (($user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && ($id || $ref) && $action == 'edit'): ?>
 
     <?php $renderer = new \flightlog\form\SimpleFormRenderer(); ?>
 
@@ -269,7 +269,7 @@ 
         <?php echo $renderer->render($formFlight->getElement('idBBC_vols')); ?>
 
         <!-- Date et heures -->
-        <?php if($formFlight->has('fk_type')): ?>
+        <?php if ($formFlight->has('fk_type')): ?>
         <section class="form-section">
             <h1 class="form-section-title"><?php echo $langs->trans('Type de vol'); ?></h1>
             <table class="border" width="50%">
@@ -286,14 +286,14 @@ 
             <h1 class="form-section-title"><?php echo $langs->trans('Pilote & ballon') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('fk_pilot')): ?>
+                <?php if ($formFlight->has('fk_pilot')): ?>
                 <tr>
                     <td class="fieldrequired"> Pilote </td>
-                    <td><?php echo $renderer->render($formFlight->getElement('fk_pilot'),['ajax' => true]); ?></td>
+                    <td><?php echo $renderer->render($formFlight->getElement('fk_pilot'), ['ajax' => true]); ?></td>
                 </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('BBC_ballons_idBBC_ballons')): ?>
+                <?php if ($formFlight->has('BBC_ballons_idBBC_ballons')): ?>
                 <tr>
                     <td width="25%" class="fieldrequired">Ballon</td>
                     <td><?php echo $renderer->render($formFlight->getElement('BBC_ballons_idBBC_ballons')); ?></td>
@@ -328,7 +328,7 @@ 
             </table>
         </section>
 
-        <?php if($formFlight->has('fk_organisateur')): ?>
+        <?php if ($formFlight->has('fk_organisateur')): ?>
             <section class="form-section">
                 <h1 class="form-section-title"><span class="js-organisator-field">Organisateur</span></h1>
                 <table class="border" width="50%">
@@ -337,7 +337,7 @@ 
                         <td>
                             <?php
                             //organisateur
-                            print $renderer->render($formFlight->getElement('fk_organisateur'),['ajax' => true]);
+                            print $renderer->render($formFlight->getElement('fk_organisateur'), ['ajax' => true]);
                             ?>
                         </td>
                     </tr>
@@ -349,7 +349,7 @@ 
         <section class="form-section js-expensable-field">
             <h1 class="form-section-title"><?php echo $langs->trans('Déplacements') ?></h1>
             <table class="border" width="50%">
-                <?php if($formFlight->has('kilometers')): ?>
+                <?php if ($formFlight->has('kilometers')): ?>
                     <!-- number of kilometers done for the flight -->
                     <tr>
                         <td class="fieldrequired">Nombre de kilometres effectués pour le vol</td>
@@ -359,7 +359,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('justif_kilometers')): ?>
+                <?php if ($formFlight->has('justif_kilometers')): ?>
                     <!-- Justif Kilometers -->
                     <tr>
 
@@ -377,7 +377,7 @@ 
         <section class="form-section">
             <h1 class="form-section-title"><?php echo $langs->trans('Passager') ?></h1>
             <table class="border" width="50%">
-                <?php if($formFlight->has('nbrPax')): ?>
+                <?php if ($formFlight->has('nbrPax')): ?>
                     <tr>
                         <td class="fieldrequired"><?php echo $langs->trans('Nombre de passagers'); ?></td>
                         <td>
@@ -386,7 +386,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('passengerNames')): ?>
+                <?php if ($formFlight->has('passengerNames')): ?>
                     <!-- passenger names -->
                     <tr>
                         <td width="25%" class="fieldrequired"><?php echo $langs->trans('Noms des passagers'); ?><br/>(Séparé
@@ -396,7 +396,7 @@ 
                             <?php print $renderer->render($formFlight->getElement('passengerNames')); ?>
                         </td>
                     </tr>
-                <?php endif;?>
+                <?php endif; ?>
             </table>
         </section>
 
@@ -405,17 +405,17 @@ 
             <h1 class="form-section-title js-billable-field"><?php echo $langs->trans('Facturation') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('fk_receiver')): ?>
+                <?php if ($formFlight->has('fk_receiver')): ?>
                     <!-- Money receiver -->
                     <tr class="js-hide-order js-billable-field">
                         <td class="fieldrequired"><?php echo $langs->trans('Qui a perçu l\'argent') ?></td>
                         <td>
-                            <?php print $renderer->render($formFlight->getElement('fk_receiver'),['ajax' => true]); ?>
+                            <?php print $renderer->render($formFlight->getElement('fk_receiver'), ['ajax' => true]); ?>
                         </td>
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('cost')): ?>
+                <?php if ($formFlight->has('cost')): ?>
                     <!-- Flight cost -->
                     <tr class="js-hide-order js-billable-field">
                         <td class="fieldrequired">Montant perçu</td>
@@ -433,7 +433,7 @@ 
             <h1 class="form-section-title"><?php echo $langs->trans('Commentaires') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('remarque')): ?>
+                <?php if ($formFlight->has('remarque')): ?>
                     <!-- commentaires -->
                     <tr class="">
                         <td class="fieldrequired"> Commentaire</td>
@@ -443,7 +443,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('incidents')): ?>
+                <?php if ($formFlight->has('incidents')): ?>
                     <!-- incidents -->
                     <tr class="">
                         <td class="fieldrequired"> incidents</td>
@@ -477,7 +477,7 @@ 
         $formconfirm = $form->formconfirm($_SERVER["PHP_SELF"] . '?id=' . $object->id, $langs->trans('DeleteMyOjbect'),
             $langs->trans('êtes-vous sure de vouloir supprimer ce vol ?'), 'confirm_delete', '', 0, 1);
         print $formconfirm;
-    } elseif ($user->rights->flightlog->vol->financial  && $action == ACTION_FLAG_BILLED) {
+    } elseif ($user->rights->flightlog->vol->financial && $action == ACTION_FLAG_BILLED) {
         $formconfirm = $form->formconfirm($_SERVER["PHP_SELF"] . '?id=' . $object->id,
             $langs->trans('Marque comme facturé'),
             $langs->trans('Ce vol va être marqué comme facturé, est-ce bien le cas ?'), ACTION_CONFIRM_FLAG_BILLED, '',
@@ -509,7 +509,7 @@ 
     print '<div class="tabsAction">' . "\n";
     $parameters = array();
     $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object,
-        $action);    // Note that $action and $object may have been modified by hook
+        $action); // Note that $action and $object may have been modified by hook
     if ($reshook < 0) {
         setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
     }