laudeco / bbc-dolibarr-flightlog

Form/BaseInput.php

<?php
/**
 *
 */

namespace flightlog\form;

/**
 * @author Laurent De Coninck <lau.deconinck@gmail.com>
 */
abstract class BaseInput implements FormElementInterface
{
    /**
     * @var string
     */
    private $name;

    /**
     * @var array
     */
    private $options;

    /**
     * @var string|int
     */
    private $value;

    /**
     * @var string
     */
    private $type;

    /**
     * @var string[]|array
     */
    private $errors;

    /**
     * @param string $name
     * @param string $type
     * @param array  $options
     */
    public function __construct($name, $type, array $options = [])
    {
        if (empty($name)) {
            throw new \InvalidArgumentException('Name cannot be empty');
        }

        $this->name = $name;
        $this->options = $options;
        $this->type = $type;
        $this->errors = [];
    }

    /**
     * @inheritDoc
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @inheritDoc
     */
    public function getOptions()
    {
        return $this->options;
    }

    /**
     * @inheritDoc
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @inheritdoc
     */
    public function getId(){
        return $this->getOption('id') ?: $this->getName();

The expression $this->getOption('id') ?: $this->getName(); of type string|integer|boolean adds the type boolean to the return on line 83 which is incompatible with the return type declared by the interface flightlog\form\FormElementInterface::getId of type string.

    }

    /**
     * @inheritDoc
     */
    public function getValue()
    {
        return $this->value;
    }

    /**
     * @inheritDoc
     */
    public function setValue($value)
    {
        $this->value = $value;
    }

    /**
     * @param string     $name
     * @param int|string $value
     *
     * @return $this
     */
    protected function setAttribute($name, $value)
    {
        $this->options['attr'][$name] = $value;

        return $this;
    }

    /**
     * @return $this
     */
    public function required(){
        $this->options['attr']['required'] = 'required';

        return $this;
    }

    /**
     * @return $this
     */
    public function disable(){
        $this->options['attr']['disabled'] = 'disabled';
        return $this;
    }

    /**
     * @inheritdoc
     */
    public function isDisabled(){
        return isset($this->options['attr']['disabled']);
    }

    /**
     * @param string $option
     *
     * @return string|int|boolean|null
     */
    public function getOption($option){
        if(!isset($this->options[$option])){
            return null;
        }

        return $this->options[$option];
    }

    /**
     * @inheritDoc
     */
    public function setErrors($errors = [])
    {
        $this->errors = $errors;
    }

    /**
     * @inheritDoc
     */
    public function hasError()
    {
        return !empty($this->errors);
    }

}