laudeco / bbc-dolibarr-flightlog

Application/Damage/Command/CreateDamageCommand.php

Doc Comments +3 added lines

@@ -27,6 +27,9 @@
      */
     private $billId;
 
+    /**
+     * @param integer $authorId
+     */
     public function __construct($authorId)
     {
         $this->authorId = $authorId;

Infrastructure/Common/Routes/Route.php

Doc Comments -1 removed lines

@@ -61,7 +61,6 @@
     }
 
     /**
-     * @param string $action
      *
      * @return bool
      */

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 namespace FlightLog\Infrastructure\Common\Routes;
 
 
-use FlightLog\Http\Web\Controller\WebController;
-
 final class Route
 {
 

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
      *
      * @return bool
      */
-    public function match($route){
+    public function match($route) {
         return $this->name === $route;
     }
 

command/CreatePilotYearBillCommandHandler.php

Spacing +2 added lines, -2 removed lines

@@ -280,7 +280,7 @@ 
             return;
         }
 
-        $pointsHt = $command->getAdditionalBonus()/(1+6/100);
+        $pointsHt = $command->getAdditionalBonus() / (1 + 6 / 100);
         $desc = sprintf("%s - %s", $command->getYear(), $command->getBonusAdditionalMessage());
 
         $discountid = $this->getCompany($object->socid)->set_remise_except($pointsHt, $this->user, $desc, 6);
@@ -300,7 +300,7 @@ 
     {
         $price = $damage->getCost()->addCost($invoicedDamage->getCost())->getValue();
 
-        if($price <= 0 ){
+        if ($price <= 0) {
             return;
         }
 

index.php

Spacing +2 added lines, -2 removed lines

@@ -53,14 +53,14 @@
 
 $routes = require './Infrastructure/Common/Routes/routes.conf.php';
 
-try{
+try {
     $routeName = GETPOST('r');
 
     $routeManager = new \FlightLog\Infrastructure\Common\Routes\RouteManager($db);
     $routeManager->load($routes);
 
     $routeManager->__invoke($routeName);
-}catch (\Exception $e){
+} catch (\Exception $e) {
     dol_syslog($e->getMessage(), LOG_ERR);
     echo $e->getMessage();
 }

Braces +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
     $routeManager->load($routes);
 
     $routeManager->__invoke($routeName);
-}catch (\Exception $e){
+} catch (\Exception $e){
     dol_syslog($e->getMessage(), LOG_ERR);
     echo $e->getMessage();
 }

Application/Damage/Command/CreateDamageCommandHandler.php

Spacing +6 added lines, -6 removed lines

@@ -41,7 +41,7 @@ 
     public function __invoke(CreateDamageCommand $command)
     {
         $damage = FlightDamage::waiting(new DamageAmount($command->getAmount()), AuthorId::create($command->getAuthorId()));
-        if(null !== $command->getFlightId()){
+        if (null !== $command->getFlightId()) {
             $damage = FlightDamage::damage(FlightId::create($command->getFlightId()), new DamageAmount($command->getAmount()), AuthorId::create($command->getAuthorId()));
         }
 
@@ -59,7 +59,7 @@ 
      */
     private function linkSupplierInvoice($damageId, $invoiceId)
     {
-        if($invoiceId <= 0){
+        if ($invoiceId <= 0) {
             return;
         }
 
@@ -80,8 +80,8 @@ 
      * @param int $targetId
      * @param string $targetType
      */
-    private function insertLinks($damageId, $targetId, $targetType){
-        $sql = "INSERT INTO ".MAIN_DB_PREFIX."element_element (";
+    private function insertLinks($damageId, $targetId, $targetType) {
+        $sql = "INSERT INTO " . MAIN_DB_PREFIX . "element_element (";
         $sql .= "fk_source";
         $sql .= ", sourcetype";
         $sql .= ", fk_target";
@@ -89,8 +89,8 @@ 
         $sql .= ") VALUES (";
         $sql .= $damageId;
         $sql .= ", 'flightlog_damage'";
-        $sql .= ", ".$targetId;
-        $sql .= ", '".$targetType."'";
+        $sql .= ", " . $targetId;
+        $sql .= ", '" . $targetType . "'";
         $sql .= ")";
 
         if ($this->db->query($sql))

Application/Damage/ViewModel/Damage.php

Spacing +2 added lines, -2 removed lines

@@ -59,12 +59,12 @@
      *
      * @return Damage
      */
-    public static function fromArray(array $properties){
+    public static function fromArray(array $properties) {
         $author = $properties['author_name'];
         $amount = $properties['amount'];
         $id = $properties['id'];
         $flightId = isset($properties['flight_id']) ? $properties['flight_id'] : null;
-        $invoiced = (bool)$properties['invoiced'];
+        $invoiced = (bool) $properties['invoiced'];
 
         return new self($author, $amount, $id, $invoiced, $flightId);
     }

Http/Web/templates/flight_damage/view.php

Spacing +5 added lines, -5 removed lines

@@ -14,20 +14,20 @@
         <td>Montant</td>
     </tr>
     <?php $total = 0; ?>
-    <?php foreach($damages as $currentDamage):?>
+    <?php foreach ($damages as $currentDamage):?>
         <?php $total += $currentDamage->getAmount(); ?>
         <tr>
-            <td><?php echo $currentDamage->getAuthorName();?></td>
-            <td><?php echo $currentDamage->getAmount();?>€</td>
+            <td><?php echo $currentDamage->getAuthorName(); ?></td>
+            <td><?php echo $currentDamage->getAmount(); ?>€</td>
             <td>
-                <?php if($currentDamage->isInvoiced()): ?>
+                <?php if ($currentDamage->isInvoiced()): ?>
                     <i class="fas fa-check"></i>
                 <?php else: ?>
                     <i class="fas fa-times"></i>
                 <?php endif; ?>
             </td>
             <td>
-                <a href="<?php print sprintf('%s/flightlog/index.php?r=get_one_damage&id=%s', DOL_URL_ROOT, $currentDamage->getId());?>"><i class="fas fa-link"></i></a>
+                <a href="<?php print sprintf('%s/flightlog/index.php?r=get_one_damage&id=%s', DOL_URL_ROOT, $currentDamage->getId()); ?>"><i class="fas fa-link"></i></a>
             </td>
         </tr>
     <?php endforeach; ?>

Braces +5 added lines, -2 removed lines

@@ -22,9 +22,12 @@
             <td>
                 <?php if($currentDamage->isInvoiced()): ?>
                     <i class="fas fa-check"></i>
-                <?php else: ?>
+                <?php else {
+    : ?>
                     <i class="fas fa-times"></i>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             </td>
             <td>
                 <a href="<?php print sprintf('%s/flightlog/index.php?r=get_one_damage&id=%s', DOL_URL_ROOT, $currentDamage->getId());?>"><i class="fas fa-link"></i></a>

Http/Web/templates/damage/view.php

Spacing +3 added lines, -3 removed lines

@@ -53,9 +53,9 @@
 ?>
 
 <table class="border centpercent">
-    <tr><td class="fieldrequired">Auteur</td><td><?php echo $damage->getAuthorName();?></td></tr>
-    <tr><td class="fieldrequired">Montant</td><td><?php echo $damage->getAmount();?>€</td></tr>
-    <tr><td class="fieldrequired">Facturé</td><td><?php echo $damage->isInvoiced()? 'Oui' : 'Non';?></td></tr>
+    <tr><td class="fieldrequired">Auteur</td><td><?php echo $damage->getAuthorName(); ?></td></tr>
+    <tr><td class="fieldrequired">Montant</td><td><?php echo $damage->getAmount(); ?>€</td></tr>
+    <tr><td class="fieldrequired">Facturé</td><td><?php echo $damage->isInvoiced() ? 'Oui' : 'Non'; ?></td></tr>
     <tr>
         <td class="fieldrequired">Vol</td>
         <td>

Http/Web/Controller/DamageController.php

Spacing +6 added lines, -6 removed lines

@@ -13,14 +13,14 @@ 
     /**
      * @return GetDamageQueryRepository
      */
-    private function getDamageRepository(){
+    private function getDamageRepository() {
         return new GetDamageQueryRepository($this->db);
     }
 
-    public function view(){
+    public function view() {
         $damageId = $this->request->getParam('id');
 
-        try{
+        try {
             $damage = $this->getDamageRepository()->query($damageId);
 
             $flight = new \Bbcvols($this->db);
@@ -31,17 +31,17 @@ 
                 'form' => new Form($this->db),
                 'flight' => $flight
             ]);
-        }catch (\Exception $e){
+        } catch (\Exception $e) {
             echo $e->getMessage();
         }
     }
 
-    public function invoice(){
+    public function invoice() {
         $damageId = $this->request->getParam('id');
 
 
 
-        $this->redirect($_SERVER["PHP_SELF"].'?id='.$damageId);
+        $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $damageId);
         exit;
     }
 }
\ No newline at end of file

Braces +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
                 'form' => new Form($this->db),
                 'flight' => $flight
             ]);
-        }catch (\Exception $e){
+        } catch (\Exception $e){
             echo $e->getMessage();
         }
     }