larriereguichet / AdminBundle

src/Factory/FieldFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
     }
     
     /**
-     * @param $name
+     * @param string $name
      * @param $type
      *
      * @return FieldInterface

Unused Use Statements -2 removed lines

@@ -3,13 +3,11 @@
 namespace LAG\AdminBundle\Factory;
 
 use Exception;
-use LAG\AdminBundle\Admin\Exception\AdminException;
 use LAG\AdminBundle\Configuration\ActionConfiguration;
 use LAG\AdminBundle\Configuration\ApplicationConfiguration;
 use LAG\AdminBundle\Configuration\ApplicationConfigurationStorage;
 use LAG\AdminBundle\Field\FieldInterface;
 use LAG\AdminBundle\Field\TwigAwareFieldInterface;
-use LAG\AdminBundle\Field\TwigAwareInterface;
 use LAG\AdminBundle\Field\TranslatorAwareFieldInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 use Symfony\Component\Translation\TranslatorInterface;

src/View/View.php

Doc Comments +2 added lines, -2 removed lines

@@ -64,8 +64,8 @@
     /**
      * View constructor.
      *
-     * @param                     $actionName
-     * @param                     $adminName
+     * @param                     string $actionName
+     * @param                     string $adminName
      * @param ActionConfiguration $configuration
      * @param AdminConfiguration  $adminConfiguration
      * @param FieldInterface[]    $fields

src/Configuration/ApplicationConfiguration.php

Spacing +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
             ->setAllowedTypes('routing_name_pattern', 'string')
             ->setAllowedTypes('routing_url_pattern', 'string')
             ->setAllowedTypes('page_parameter', 'string')
-            ->setNormalizer('routing_name_pattern', function (Options $options, $value) {
+            ->setNormalizer('routing_name_pattern', function(Options $options, $value) {
                 if (strstr($value, '{admin}') === false) {
                     throw new InvalidOptionsException(
                         'Admin routing configuration pattern name should contains the {admin} placeholder'
@@ -93,7 +93,7 @@ 
 
                 return $value;
             })
-            ->setNormalizer('routing_url_pattern', function (Options $options, $value) {
+            ->setNormalizer('routing_url_pattern', function(Options $options, $value) {
                 if (strstr($value, '{admin}') === false) {
                     throw new InvalidOptionsException('Admin routing configuration url pattern should contains {admin} placeholder');
                 }

src/Configuration/ActionConfiguration.php

Indentation +5 added lines, -5 removed lines

@@ -15,11 +15,11 @@
 
 class ActionConfiguration extends Configuration
 {
-     /**
-     * Related Action name.
-     *
-     * @var string
-     */
+        /**
+         * Related Action name.
+         *
+         * @var string
+         */
     private $actionName;
 
     /**

Spacing +7 added lines, -7 removed lines

@@ -164,7 +164,7 @@ 
      */
     private function getFieldsNormalizer()
     {
-        return function (Options $options, $fields) {
+        return function(Options $options, $fields) {
             $normalizedFields = [];
 
             foreach ($fields as $name => $field) {
@@ -187,7 +187,7 @@ 
      */
     private function getOrderNormalizer()
     {
-        return function (Options $options, $order) {
+        return function(Options $options, $order) {
             foreach ($order as $field => $sort) {
 
                 if (!is_string($sort) || !is_string($field) || !in_array(strtolower($sort), ['asc', 'desc'])) {
@@ -211,7 +211,7 @@ 
      */
     private function getLoadStrategyNormalizer()
     {
-        return function (Options $options, $value) {
+        return function(Options $options, $value) {
             if (!$value) {
                 if ($this->actionName == 'create') {
                     $value = LAGAdminBundle::LOAD_STRATEGY_NONE;
@@ -234,7 +234,7 @@ 
      */
     private function getMenuNormalizer()
     {
-        return function (Options $options, $menus) {
+        return function(Options $options, $menus) {
             // set default to an array
             if ($menus === false) {
                 $menus = [];
@@ -252,7 +252,7 @@ 
      */
     private function getCriteriaNormalizer()
     {
-        return function (Options $options, $value) {
+        return function(Options $options, $value) {
             if (!$value) {
                 $idActions = [
                     'edit',
@@ -301,7 +301,7 @@ 
      */
     private function getFiltersNormalizer()
     {
-        return function (Options $options, $data) {
+        return function(Options $options, $data) {
             $normalizedData = [];
 
             foreach ($data as $name => $field) {
@@ -327,7 +327,7 @@ 
 
     private function getRouteDefaultNormalizer()
     {
-        return function (Options $options, $value) {
+        return function(Options $options, $value) {
             if (!is_array($value)) {
                 $value = [];
             }

src/Configuration/AdminConfiguration.php

Spacing +1 added lines, -1 removed lines

@@ -76,7 +76,7 @@
                 null,
                 'pagerfanta',
             ])
-            ->setNormalizer('actions', function (Options $options, $actions) {
+            ->setNormalizer('actions', function(Options $options, $actions) {
                 $normalizedActions = [];
                 $addBatchAction = false;
 

src/Field/LinkField.php

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
                 '_self',
                 '_blank',
             ])
-            ->setNormalizer('route', function (Options $options, $value) use ($actionConfiguration) {
+            ->setNormalizer('route', function(Options $options, $value) use ($actionConfiguration) {
                 // route or url should be defined
                 if (!$value && !$options->offsetGet('url') && !$options->offsetGet('admin')) {
                     throw new InvalidOptionsException(
@@ -64,7 +64,7 @@ 
 
                 return $value;
             })
-            ->setNormalizer('admin', function (Options $options, $value) {
+            ->setNormalizer('admin', function(Options $options, $value) {
                 // if a Admin is defined, an Action should be defined too
                 if ($value && !$options->offsetGet('action')) {
                     throw new InvalidOptionsException(
@@ -74,7 +74,7 @@ 
 
                 return $value;
             })
-            ->setNormalizer('parameters', function (Options $options, $values) {
+            ->setNormalizer('parameters', function(Options $options, $values) {
                 $cleanedValues = [];
 
                 foreach ($values as $name => $method) {

sam.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
     'copy' => [],
 ];
 $eventDispatcher = new EventDispatcher();
-$eventDispatcher->addListener(NotificationEvent::NAME, function (NotificationEvent $event) {
+$eventDispatcher->addListener(NotificationEvent::NAME, function(NotificationEvent $event) {
     echo $event->getMessage()."\n";
 });
 
@@ -68,7 +68,7 @@ 
 $builder = new TaskBuilder();
 $tasks = $builder->build($tasks);
 
-$normalizer = new Normalizer(realpath(__DIR__ . '/AdminBundle'));
+$normalizer = new Normalizer(realpath(__DIR__.'/AdminBundle'));
 $locator = new Locator($normalizer);
 
 $runner = new TaskRunner(

src/Event/Subscriber/AdminSubscriber.php

Braces +2 added lines, -4 removed lines

@@ -135,12 +135,10 @@
 
         if (LAGAdminBundle::LOAD_STRATEGY_NONE === $strategy) {
             return;
-        }
-        else if (LAGAdminBundle::LOAD_STRATEGY_MULTIPLE === $strategy) {
+        } else if (LAGAdminBundle::LOAD_STRATEGY_MULTIPLE === $strategy) {
             $entities = $dataProvider->getCollection($admin, $event->getFilters());
             $event->setEntities($entities);
-        }
-        else if (LAGAdminBundle::LOAD_STRATEGY_UNIQUE === $strategy) {
+        } else if (LAGAdminBundle::LOAD_STRATEGY_UNIQUE === $strategy) {
             $requirements = $actionConfiguration->getParameter('route_requirements');
             $identifier = null;
 

tests/AdminBundle/DependencyInjection/CompilerPass/ResourceCompilerPassTest.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
         $resourceCollection
             ->expects($this->once())
             ->method('addMethodCall')
-            ->willReturnCallback(function ($name, $parameters) {
+            ->willReturnCallback(function($name, $parameters) {
                 $this->assertEquals('add', $name);
                 $this->assertCount(1, $parameters);
                 $this->assertInstanceOf(Reference::class, $parameters[0]);