Completed
Pull Request — dev (#19)
by Arnaud
02:49
created
Admin/Action.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
      * Return action configuration resolver
107 107
      *
108 108
      * @param OptionsResolver $resolver
109
-     * @param $actionName
109
+     * @param string $actionName
110 110
      * @param Admin|null $admin
111 111
      */
112 112
     protected function configureOptionsResolver(OptionsResolver $resolver, $actionName, Admin $admin = null)
Please login to merge, or discard this patch.
Routing/RoutingLoader.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
         // by default, generic controller
97 97
         $defaults = [
98
-            '_controller' => $admin->getConfiguration()->getParameter('controller') . ':' . $action->getName(),
98
+            '_controller' => $admin->getConfiguration()->getParameter('controller').':'.$action->getName(),
99 99
             '_admin' => $admin->getName(),
100 100
             '_action' => $action->getName(),
101 101
         ];
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
     {
149 149
         $array = explode('\\', $namespace);
150 150
         $path = array_pop($array);
151
-        $path = strtolower(substr($path, 0, 1)) . substr($path, 1);
151
+        $path = strtolower(substr($path, 0, 1)).substr($path, 1);
152 152
 
153 153
         return $path;
154 154
     }
Please login to merge, or discard this patch.
Action/Configuration/ActionConfiguration.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
         $resolver
83 83
             ->setDefault('route', '')
84 84
             ->setAllowedTypes('route', 'string')
85
-            ->setNormalizer('route', function (Options $options, $value) {
85
+            ->setNormalizer('route', function(Options $options, $value) {
86 86
                 if (!$value) {
87 87
                     // if no route was provided, it should be linked to an Admin
88 88
                     if (!$this->admin) {
89
-                        throw new InvalidOptionsException('No route was provided for action : ' . $this->actionName);
89
+                        throw new InvalidOptionsException('No route was provided for action : '.$this->actionName);
90 90
                     }
91 91
 
92 92
                     // generate default route from admin
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
             ->addAllowedValues('load_strategy', AdminInterface::LOAD_STRATEGY_NONE)
115 115
             ->addAllowedValues('load_strategy', AdminInterface::LOAD_STRATEGY_UNIQUE)
116 116
             ->addAllowedValues('load_strategy', AdminInterface::LOAD_STRATEGY_MULTIPLE)
117
-            ->setNormalizer('load_strategy', function (Options $options, $value) {
117
+            ->setNormalizer('load_strategy', function(Options $options, $value) {
118 118
 
119 119
                 if (!$value) {
120 120
                     if ($this->actionName == 'create') {
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
         // criteria used to find entity in the data provider
140 140
         $resolver
141 141
             ->setDefault('criteria', [])
142
-            ->setNormalizer('criteria', function (Options $options, $value) {
142
+            ->setNormalizer('criteria', function(Options $options, $value) {
143 143
 
144 144
                 if (!$value) {
145 145
                     $idActions = [
Please login to merge, or discard this patch.
Application/Configuration/ApplicationConfiguration.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
             'name_pattern' => 'lag.admin.{admin}',
70 70
         ]);
71 71
         $resolver->setAllowedTypes('routing', 'array');
72
-        $resolver->setNormalizer('routing', function (Options $options, $value) {
72
+        $resolver->setNormalizer('routing', function(Options $options, $value) {
73 73
 
74 74
             // url pattern should contain {admin} and {action} token
75 75
             $urlPattern = $value['url_pattern'];
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
             'pattern' => 'lag.admin.{key}'
98 98
         ]);
99 99
         $resolver->setAllowedTypes('translation', 'array');
100
-        $resolver->setNormalizer('translation', function (Options $options, $value) {
100
+        $resolver->setNormalizer('translation', function(Options $options, $value) {
101 101
 
102 102
             if (!is_bool($value['enabled'])) {
103 103
                 throw new InvalidOptionsException('Admin translation enabled parameter should be a boolean');
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
         $resolver->setDefault('fields_mapping', $defaultMapping);
130 130
         $resolver->setAllowedTypes('fields_mapping', 'array');
131
-        $resolver->setNormalizer('fields_mapping', function (Options $options, $value) use ($defaultMapping) {
131
+        $resolver->setNormalizer('fields_mapping', function(Options $options, $value) use ($defaultMapping) {
132 132
             // merge with default mapping to allow override
133 133
             $value = array_merge($defaultMapping, $value);
134 134
 
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
         $resolver->setDefault('fields_template_mapping', $defaultMapping);
144 144
         $resolver->setAllowedTypes('fields_template_mapping', 'array');
145
-        $resolver->setNormalizer('fields_template_mapping', function (Options $options, $value) use ($defaultMapping) {
145
+        $resolver->setNormalizer('fields_template_mapping', function(Options $options, $value) use ($defaultMapping) {
146 146
             // merge with default mapping to allow override
147 147
             $value = array_merge($defaultMapping, $value);
148 148
 
Please login to merge, or discard this patch.
Configuration/Factory/ConfigurationFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
      * Return action configuration resolver
107 107
      *
108 108
      * @param OptionsResolver $resolver
109
-     * @param $actionName
109
+     * @param string $actionName
110 110
      * @param Admin|null $admin
111 111
      */
112 112
     protected function configureOptionsResolver(OptionsResolver $resolver, $actionName, Admin $admin = null)
Please login to merge, or discard this patch.
Menu/Configuration/MenuItemConfiguration.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
         // user can defined an admin name
20 20
         $resolver
21 21
             ->setDefault('admin', null)
22
-            ->setNormalizer('admin', function (Options $options, $adminName) {
22
+            ->setNormalizer('admin', function(Options $options, $adminName) {
23 23
 
24 24
                 // user has to defined either an admin name and an action name, or a route name with optional
25 25
                 // parameters, or an url
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
                 // if an action name is provided, an admin name should be defined too
44 44
                 if ($action !== null && $options->offsetGet('admin') === null) {
45 45
                     throw new InvalidOptionsException(
46
-                        'You should provide an admin name for this action ' . $action
46
+                        'You should provide an admin name for this action '.$action
47 47
                     );
48 48
                 }
49 49
 
Please login to merge, or discard this patch.