larriereguichet / AdminBundle

Admin/Admin.php

Doc Comments +2 added lines, -2 removed lines

@@ -253,7 +253,7 @@ 
      *
      * @param array $criteria
      * @param array $orderBy
-     * @param null $limit
+     * @param integer $limit
      * @param int $offset
      */
     public function load(array $criteria, $orderBy = [], $limit = null, $offset = 1)
@@ -353,7 +353,7 @@ 
     }
 
     /**
-     * @return array
+     * @return integer[]
      */
     public function getActionNames()
     {

Admin/Configuration/ApplicationConfiguration.php

Doc Comments +9 added lines, -6 removed lines

@@ -105,6 +105,9 @@ 
      */
     protected $translationPattern;
 
+    /**
+     * @param string $locale
+     */
     public function __construct(array $applicationConfiguration = [], $locale)
     {
         $resolver = new OptionsResolver();
@@ -201,7 +204,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getTitle()
     {
@@ -217,7 +220,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getLayout()
     {
@@ -233,7 +236,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getBlockTemplate()
     {
@@ -249,7 +252,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getDescription()
     {
@@ -281,7 +284,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getDateFormat()
     {
@@ -372,7 +375,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return integer
      */
     public function getStringLengthTruncate()
     {

Spacing +3 added lines, -3 removed lines

@@ -146,7 +146,7 @@ 
             'url_pattern',
             'name_pattern',
         ]);
-        $resolver->setNormalizer('url_pattern', function (Options $options, $value) {
+        $resolver->setNormalizer('url_pattern', function(Options $options, $value) {
             if (strstr($value, '{admin}') === false) {
                 throw new InvalidOptionsException('Admin routing configuration url pattern should contains {admin} placeholder');
             }
@@ -156,7 +156,7 @@ 
 
             return $value;
         });
-        $resolver->setNormalizer('name_pattern', function (Options $options, $value) {
+        $resolver->setNormalizer('name_pattern', function(Options $options, $value) {
             if (strstr($value, '{admin}') === false) {
                 throw new InvalidOptionsException('Admin routing configuration pattern name should contains {admin} placeholder');
             }
@@ -174,7 +174,7 @@ 
             ->clear()
             ->setDefault('enabled', true)
             ->setDefault('pattern', 'lag.admin.{key}');
-        $resolver->setNormalizer('pattern', function (Options $options, $value) {
+        $resolver->setNormalizer('pattern', function(Options $options, $value) {
             if (strstr($value, 'key') === false) {
                 throw new InvalidOptionsException('Admin translation configuration pattern should contains {key} placeholder');
             }

Admin/Factory/ActionFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
      * Return action configuration resolver
      *
      * @param OptionsResolver $resolver
-     * @param $actionName
+     * @param string $actionName
      * @param Admin|null $admin
      */
     protected function configureOptionsResolver(OptionsResolver $resolver, $actionName, Admin $admin = null)

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use LAG\AdminBundle\Admin\AdminInterface;
 use LAG\AdminBundle\Admin\Configuration\ActionConfiguration;
 use LAG\AdminBundle\Admin\Configuration\ApplicationConfiguration;
-use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
 use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 

Spacing +3 added lines, -3 removed lines

@@ -157,7 +157,7 @@ 
                 Admin::LOAD_STRATEGY_UNIQUE,
                 Admin::LOAD_STRATEGY_MULTIPLE,
             ])
-            ->setNormalizer('route', function (Options $options, $value) use ($admin, $actionName) {
+            ->setNormalizer('route', function(Options $options, $value) use ($admin, $actionName) {
                 if (!$value) {
                     // if no route was provided, it should be linked to an Admin
                     if (!$admin) {
@@ -168,7 +168,7 @@ 
                 }
                 return $value;
             })
-            ->setNormalizer('title', function (Options $options, $value) use ($admin, $actionName) {
+            ->setNormalizer('title', function(Options $options, $value) use ($admin, $actionName) {
                 if (!$value) {
                     $adminKey = '';
                     // if an Admin is linked to this action, we use its name in translation key
@@ -179,7 +179,7 @@ 
                 }
                 return $value;
             })
-            ->setNormalizer('batch', function (Options $options, $value) use ($admin, $actionName) {
+            ->setNormalizer('batch', function(Options $options, $value) use ($admin, $actionName) {
                 if ($value) {
                     if (!is_array($value)) {
                         $value = [$value];

DataProvider/DataProvider.php

Doc Comments +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
     /**
      * Find an entity by its unique id
      *
-     * @param $id
+     * @param string $id
      * @return object
      */
     public function find($id)
@@ -64,7 +64,7 @@ 
     /**
      * Save an entity
      *
-     * @param $entity
+     * @param \stdClass $entity
      */
     public function save($entity)
     {
@@ -76,7 +76,7 @@ 
     /**
      * Remove an entity
      *
-     * @param $entity
+     * @param \stdClass $entity
      */
     public function remove($entity)
     {

Event/Subscriber/ExtraConfigurationSubscriber.php

Doc Comments +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     /**
      * ExtraConfigurationSubscriber constructor
      *
-     * @param bool|true $enableExtraConfiguration
+     * @param boolean $enableExtraConfiguration
      * @param EntityManager $entityManager
      * @param ApplicationConfiguration $applicationConfiguration
      */

Repository/GenericRepository.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
      *
      * @param ObjectManager $objectManager
      * @param ObjectRepository $repository
-     * @param $entityClassName
+     * @param string|null $entityClassName
      */
     public function __construct(ObjectManager $objectManager, ObjectRepository $repository, $entityClassName)
     {

Tests/AdminBundle/Admin/AdminTest.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
         }
     }
 
+    /**
+     * @param string $adminName
+     */
     protected function doTestAdmin(AdminInterface $admin, array $configuration, $adminName)
     {
         $this->assertEquals($admin->getName(), $adminName);

Tests/Base.php

Doc Comments +8 added lines, -8 removed lines

@@ -77,7 +77,7 @@ 
     /**
      * Assert that an exception is raised in the given code.
      *
-     * @param $exceptionClass
+     * @param string $exceptionClass
      * @param Closure $closure
      */
     protected function assertExceptionRaised($exceptionClass, Closure $closure)
@@ -124,8 +124,8 @@ 
     }
 
     /**
-     * @param $name
-     * @param $configuration
+     * @param string $name
+     * @param \LAG\AdminBundle\Admin\Configuration\AdminConfiguration $configuration
      * @return Admin
      */
     protected function mockAdmin($name, $configuration)
@@ -140,7 +140,7 @@ 
 
     /**
      * @param $name
-     * @return ActionInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return ActionInterface
      */
     protected function mockAction($name)
     {
@@ -237,7 +237,7 @@ 
     /**
      * Return a mock of an entity repository
      *
-     * @return RepositoryInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return RepositoryInterface
      */
     protected function mockEntityRepository()
     {
@@ -275,7 +275,7 @@ 
     }
 
     /**
-     * @return ActionFactory|PHPUnit_Framework_MockObject_MockObject
+     * @return ActionFactory
      */
     protected function mockActionFactory()
     {
@@ -317,7 +317,7 @@ 
     }
 
     /**
-     * @return MessageHandlerInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return MessageHandlerInterface
      */
     protected function mockMessageHandler()
     {
@@ -340,7 +340,7 @@ 
     }
 
     /**
-     * @return DataProviderInterface|PHPUnit_Framework_MockObject_MockObject
+     * @return DataProviderInterface
      */
     protected function mockDataProvider()
     {

Spacing +1 added lines, -1 removed lines

@@ -259,7 +259,7 @@
         $repository = $this->mockEntityRepository();
         $repository
             ->method('getEntityPersister')
-            ->willReturn( $this
+            ->willReturn($this
                 ->getMockBuilder('Doctrine\ORM\Persisters\Entity\BasicEntityPersister')
                 ->disableOriginalConstructor()
                 ->getMock());

Twig/AdminExtension.php

Doc Comments +2 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
     }
 
     /**
-     * @return array
+     * @return Twig_SimpleFunction[]
      */
     public function getFunctions()
     {
@@ -67,7 +67,7 @@ 
     }
 
     /**
-     * @return array
+     * @return Twig_SimpleFilter[]
      */
     public function getFilters()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace LAG\AdminBundle\Twig;
 
 use LAG\AdminBundle\Admin\Configuration\ApplicationConfiguration;
-use LAG\AdminBundle\Admin\Field;
 use LAG\AdminBundle\Admin\Field\EntityFieldInterface;
 use LAG\AdminBundle\Admin\FieldInterface;
 use Symfony\Component\DependencyInjection\Container;