ModelCreating::afterCreate() - Code Metrics - Inspection of "Large Amound of Refactoring for LTS AND Edge suppo..." - laravelflare/flare - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9e7309...ca86c4 )

by Aden

created 2016-02-25 13:03 UTC

ModelCreating::afterCreate() A

↳ Parent: ModelCreating

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
eloc	1
nc	1
nop	0

<?php

namespace LaravelFlare\Flare\Admin\Models\Traits;

use LaravelFlare\Flare\Events\ModelCreate;
use LaravelFlare\Flare\Events\AfterCreate;
use LaravelFlare\Flare\Events\BeforeCreate;
use LaravelFlare\Flare\Exceptions\ModelAdminWriteableException as WriteableException;

trait ModelCreating
{
    /**
     * Method fired before the Create action is undertaken.
     * 
     * @return
     */
    protected function beforeCreate()
    {
    }

    /**
     * Create Action.
     *
     * Fires off beforeCreate(), doCreate() and afterCreate()
     * 
     * @return
     */
    public function create()
    {
        event(new BeforeCreate($this));

        $this->beforeCreate();

        $this->doCreate();

        $this->afterCreate();

        event(new AfterCreate($this));
    }

    /**
     * The actual Create action, which does all of hte pre-processing
     * required before we are able to perform the save() function.
     * 
     * @return
     */
    private function doCreate()

    {
        if (is_callable(array('self', 'save'))) {
            $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            event(new ModelCreate($this));

            return;
        }

        throw new WriteableException('For a Model to be Creatable the ModelAdmin must have the Save method implemented using the ModelWriting trait', 1);
    }

    /**
     * Method fired after the Create action is complete.
     * 
     * @return
     */
    protected function afterCreate()
    {
    }
}


1		<?php
2
3		namespace LaravelFlare\Flare\Admin\Models\Traits;
4
5		use LaravelFlare\Flare\Events\ModelCreate;
6		use LaravelFlare\Flare\Events\AfterCreate;
7		use LaravelFlare\Flare\Events\BeforeCreate;
8		use LaravelFlare\Flare\Exceptions\ModelAdminWriteableException as WriteableException;
9
10		trait ModelCreating
11		{
12		/**
13		* Method fired before the Create action is undertaken.
14		*
15		* @return
16		*/
17		protected function beforeCreate()
18		{
19		}
20
21		/**
22		* Create Action.
23		*
24		* Fires off beforeCreate(), doCreate() and afterCreate()
25		*
26		* @return
27		*/
28		public function create()
29		{
30		event(new BeforeCreate($this));
31
32		$this->beforeCreate();
33
34		$this->doCreate();
35
36		$this->afterCreate();
37
38		event(new AfterCreate($this));
39		}
40
41		/**
42		* The actual Create action, which does all of hte pre-processing
43		* required before we are able to perform the save() function.
44		*
45		* @return
46		*/
47	View Code Duplication	private function doCreate()
		0 ignored issues – show Duplication introduced 2016-02-25 13:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		{
49		if (is_callable(array('self', 'save'))) {
50		$this->save();
		0 ignored issues – show Bug introduced 2016-02-09 11:48 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
51
52		event(new ModelCreate($this));
53
54		return;
55		}
56
57		throw new WriteableException('For a Model to be Creatable the ModelAdmin must have the Save method implemented using the ModelWriting trait', 1);
58		}
59
60		/**
61		* Method fired after the Create action is complete.
62		*
63		* @return
64		*/
65		protected function afterCreate()
66		{
67		}
68		}
69

laravelflare / flare

GitHub Access Token became invalid

Push — master ( 9e7309...ca86c4 )

ModelCreating::afterCreate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like