LaravelFlare\Flare\Admin\Models\Traits\ModelCreating

Complexity

Total Complexity

5

Size/Duplication

Total Lines	59
Duplicated Lines	20.34 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	beforeCreate()	0	3	1
A	create()	0	12	1
A	doCreate()	12	12	2
A	afterCreate()	0	3	1

<?php

namespace LaravelFlare\Flare\Admin\Models\Traits;

use LaravelFlare\Flare\Events\ModelCreate;
use LaravelFlare\Flare\Events\AfterCreate;
use LaravelFlare\Flare\Events\BeforeCreate;
use LaravelFlare\Flare\Exceptions\ModelAdminWriteableException as WriteableException;

trait ModelCreating
{
    /**
     * Method fired before the Create action is undertaken.
     * 
     * @return
     */
    protected function beforeCreate()
    {
    }

    /**
     * Create Action.
     *
     * Fires off beforeCreate(), doCreate() and afterCreate()
     * 
     * @return
     */
    public function create()
    {
        event(new BeforeCreate($this));

        $this->beforeCreate();

        $this->doCreate();

        $this->afterCreate();

        event(new AfterCreate($this));
    }

    /**
     * The actual Create action, which does all of hte pre-processing
     * required before we are able to perform the save() function.
     * 
     * @return
     */
    private function doCreate()

This method seems to be duplicated in your project.

    {
        if (is_callable(array('self', 'save'))) {
            $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            event(new ModelCreate($this));

            return;
        }

        throw new WriteableException('For a Model to be Creatable the ModelAdmin must have the Save method implemented using the ModelWriting trait', 1);
    }

    /**
     * Method fired after the Create action is complete.
     * 
     * @return
     */
    protected function afterCreate()
    {
    }
}