App\Tables\Builders\DnaTable::query()

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function query(): Builder
    {
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $userId = \Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if (in_array($role, [1, 2])) {
            return Dna::selectRaw('

The expression return App\Models\Dna::selectRaw(' dnas.id, dnas.name, dnas.file_name, dnas.variable_name, dnas.created_at ') could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            dnas.id, dnas.name, dnas.file_name, dnas.variable_name, dnas.created_at
        ');
        }

        return Dna::selectRaw('

The expression return App\Models\Dna::selectRaw(' dnas.id, dnas.name, dnas.file_name, dnas.variable_name, dnas.created_at, dnas.user_id ')->where('dnas.user_id', $userId) could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship|Illuminate\Database\Eloquent\Relations\HasManyThrough|Illuminate\Database\Eloquent\Relations\HasOneThrough which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            dnas.id, dnas.name, dnas.file_name, dnas.variable_name, dnas.created_at, dnas.user_id
        ')->where('dnas.user_id', $userId);
    }