App\Tables\Builders\DnaTable

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	query()	0	14	2
A	templatePath()	0	3	1

<?php

namespace App\Tables\Builders;

use App\Models\Dna;
use Illuminate\Database\Eloquent\Builder;
use LaravelEnso\Tables\Contracts\Table;

class DnaTable implements Table
{
    protected const TemplatePath = __DIR__.'/../Templates/dna.json';

    public function query(): Builder
    {
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $userId = \Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if (in_array($role, [1, 2])) {
            return Dna::selectRaw('

The expression return App\Models\Dna::selectRaw(' dnas.id, dnas.name, dnas.file_name, dnas.variable_name, dnas.created_at ') could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            dnas.id, dnas.name, dnas.file_name, dnas.variable_name, dnas.created_at
        ');
        }

        return Dna::selectRaw('

The expression return App\Models\Dna::selectRaw(' dnas.id, dnas.name, dnas.file_name, dnas.variable_name, dnas.created_at, dnas.user_id ')->where('dnas.user_id', $userId) could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship|Illuminate\Database\Eloquent\Relations\HasManyThrough|Illuminate\Database\Eloquent\Relations\HasOneThrough which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            dnas.id, dnas.name, dnas.file_name, dnas.variable_name, dnas.created_at, dnas.user_id
        ')->where('dnas.user_id', $userId);
    }

    public function templatePath(): string
    {
        return static::TemplatePath;
    }
}