| Conditions | 3 |
| Paths | 3 |
| Total Lines | 55 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 6 | ||
| Bugs | 2 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 36 | public function handle() |
||
| 37 | { |
||
| 38 | $user = $this->current_user; |
||
| 39 | $dnas = Dna::where('variable_name', '!=', $this->var_name)->get(); |
||
| 40 | $mpath = app_path(); |
||
| 41 | |||
| 42 | foreach ($dnas as $dna) { |
||
| 43 | Log::info(json_encode($dna, JSON_THROW_ON_ERROR)); |
||
| 44 | Log::info(storage_path('/app/public/dna/output/shared_dna_'.$this->var_name.'_'.$dna->variable_name.'_'.$this->file_name.'_'.$dna->file_name)); |
||
| 45 | // system('/usr/bin/python3 /home/genealogia/public_html/dna.py ' . $this->var_name . ' ' . $dna->variable_name . ' ' . '/home/genealogia/public_html/storage/app/dna/'. $this->file_name . ' ' . '/home/genealogia/public_html/storage/app/dna/'. $dna->file_name); |
||
| 46 | // chdir('/home/familytree365/domains/api.familytree365.com/genealogy/app'); |
||
| 47 | chdir($mpath); |
||
| 48 | // exec('python dna.py '.$this->var_name.' '.$dna->variable_name.' '.$this->file_name.' '.$dna->file_name, $dna_output); |
||
| 49 | $result = exec('python3 dna.py '.$this->var_name.' '.$dna->variable_name.' '.$this->file_name.' '.$dna->file_name); |
||
| 50 | // $resultData = json_decode($result, true, 512, JSON_THROW_ON_ERROR); |
||
| 51 | $resultData = json_decode($result, true, 512, JSON_THROW_ON_ERROR); |
||
| 52 | // chmod(storage_path('/app/public/dna/output/shared_dna_'.$this->var_name.'_'.$dna->variable_name.'_'.$this->file_name.'_'.$dna->file_name), 0777); |
||
| 53 | |||
| 54 | $dm = new DM(); |
||
| 55 | $dm->user_id = $user->id; |
||
| 56 | $dm->match_id = $dna->user_id; |
||
| 57 | $match_name_user = User::with('person')->find($dna->user_id); |
||
| 58 | $match_name = $match_name_user->person->name; |
||
| 59 | $dm->match_name = $match_name; |
||
| 60 | // $dm->image = 'shared_dna_'.$this->var_name.'_'.$dna->variable_name.'.png'; |
||
| 61 | // $dm->image = 'shared_dna_'.$this->var_name.'_'.$dna->variable_name.'_0p75cM_1100snps_GRCh37_HapMap2.png'; |
||
| 62 | $dm->image = env('APP_URL').'/storage/dna/output/shared_dna_'.$this->var_name.'_'. |
||
| 63 | $dna->variable_name.'_0p75cM_1100snps_GRCh37_HapMap2.png'; |
||
| 64 | // $dm->file1 = 'discordant_snps_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv'; |
||
| 65 | $dm->file1 = 'discordant_snps_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv'; |
||
| 66 | // $dm->file2 = 'shared_dna_one_chrom_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv'; |
||
| 67 | $dm->file2 = 'shared_dna_one_chrom_'.$this->var_name.'_'.$dna->variable_name.'_0p75cM_1100snps_GRCh37_HapMap2.csv'; |
||
| 68 | |||
| 69 | $dm->total_shared_cm = round($resultData['total_cms'], 2); |
||
| 70 | $dm->largest_cm_segment = round($resultData['largest_cm'], 2); |
||
| 71 | |||
| 72 | $dm->save(); |
||
| 73 | if ($dna->user_id !== $user->id) { |
||
| 74 | $dm2 = new DM(); |
||
| 75 | $dm2->user_id = $dna->user_id; |
||
| 76 | $dm2->match_id = $user->id; |
||
| 77 | $match_name_user = User::with('person')->find($dna->user_id); |
||
| 78 | $dm2->match_name = $match_name_user->person->name; |
||
| 79 | // $dm->image = 'shared_dna_'.$this->var_name.'_'.$dna->variable_name.'.png'; |
||
| 80 | // $dm->image = 'shared_dna_'.$this->var_name.'_'.$dna->variable_name.'_0p75cM_1100snps_GRCh37_HapMap2.png'; |
||
| 81 | $dm2->image = env('APP_URL').'/storage/dna/output/shared_dna_'.$this->var_name.'_'.$dna->variable_name.'_0p75cM_1100snps_GRCh37_HapMap2.png'; |
||
| 82 | // $dm->file1 = 'discordant_snps_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv'; |
||
| 83 | $dm2->file1 = 'discordant_snps_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv'; |
||
| 84 | // $dm->file2 = 'shared_dna_one_chrom_'.$this->var_name.'_'.$dna->variable_name.'_GRCh37.csv'; |
||
| 85 | $dm2->file2 = 'shared_dna_one_chrom_'.$this->var_name.'_'.$dna->variable_name.'_0p75cM_1100snps_GRCh37_HapMap2.csv'; |
||
| 86 | |||
| 87 | $dm2->total_shared_cm = round($resultData['total_cms'], 2); |
||
| 88 | $dm2->largest_cm_segment = round($resultData['largest_cm'], 2); |
||
| 89 | |||
| 90 | $dm2->save(); |
||
| 91 | } |
||
| 119 |