App\Http\Controllers\Company\Edit::__invoke()

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function __invoke(Company $company, Form $form)
    {
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user_id = \Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($company->email === \Auth::user()->email) {

The property email does not exist on App\Models\Company. Since you implemented __get, consider adding a @property annotation.

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            if (in_array($role, [1, 2])) {
                return ['form' => $form->edit($company)];
            }
            if ($user_id === $company->created_by) {
                return ['form' => $form->edit($company)];
            }
        }

        return ['error' => __('Unauthorized')];
    }