App\Http\Controllers\Company\Edit

Complexity

Total Complexity

4

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	14	4

<?php

namespace App\Http\Controllers\Company;

use App\Forms\Builders\Company as Form;
use App\Models\Company;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Routing\Controller;

class Edit extends Controller
{
    use AuthorizesRequests;

    public function __invoke(Company $company, Form $form)
    {
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user_id = \Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($company->email === \Auth::user()->email) {

The property email does not exist on App\Models\Company. Since you implemented __get, consider adding a @property annotation.

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            if (in_array($role, [1, 2])) {
                return ['form' => $form->edit($company)];
            }
            if ($user_id === $company->created_by) {
                return ['form' => $form->edit($company)];
            }
        }

        return ['error' => __('Unauthorized')];
    }
}