larapie / actions

src/Concerns/RunsAsController.php

<?php

namespace Larapie\Actions\Concerns;

use Illuminate\Http\Request;

trait RunsAsController
{
    protected $request;

    public function __invoke(Request $request)
    {
        return $this->runAsController($request);
    }

    public function runAsController(Request $request)
    {
        $this->runningAs = 'controller';

The property runningAs does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->request = $request;

        $this->reset($request->user());

It seems like reset() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->fill($this->getAttributesFromRequest($request));

It seems like fill() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $result = $this->run();

It seems like run() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (method_exists($this, 'response')) {
            return $this->response($result, $request);
        }

        if (method_exists($this, 'jsonResponse') && $request->wantsJson()) {
            return $this->jsonResponse($result, $request);
        }

        if (method_exists($this, 'htmlResponse') && ! $request->wantsJson()) {
            return $this->htmlResponse($result, $request);
        }

        return $result;
    }

    public function getAttributesFromRequest(Request $request)
    {
        return array_merge(
            $this->getAttributesFromRoute($request),
            $request->all()
        );
    }

    public function getAttributesFromRoute(Request $request)
    {
        $route = $request->route();

        return $route ? $route->parametersWithoutNulls() : [];
    }

    public function getRequest()
    {
        return $this->request;
    }
}