Larapie\Actions\Concerns\RunsAsController::runAsController()

Complexity

Conditions	6
Paths	4

Size

Total Lines	23
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	6

Importance

Changes

0

<?php
    public function runAsController(Request $request)
    {
        $this->runningAs = 'controller';

The property runningAs does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->request = $request;

        $this->reset($request->user());

It seems like reset() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->fill($this->getAttributesFromRequest($request));

It seems like fill() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $result = $this->run();

It seems like run() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (method_exists($this, 'response')) {
            return $this->response($result, $request);
        }

        if (method_exists($this, 'jsonResponse') && $request->wantsJson()) {
            return $this->jsonResponse($result, $request);
        }

        if (method_exists($this, 'htmlResponse') && ! $request->wantsJson()) {
            return $this->htmlResponse($result, $request);
        }

        return $result;
    }