lagdo / tontine

src/Service/Meeting/Pool/DepositService.php

Spacing +11 added lines, -11 removed lines

@@ -123,7 +123,7 @@ 
     public function createDeposit(Pool $pool, Session $session, int $receivableId): void
     {
         $receivable = $this->getReceivable($pool, $session, $receivableId);
-        if(!$receivable || $receivable->deposit || !$pool->deposit_fixed)
+        if (!$receivable || $receivable->deposit || !$pool->deposit_fixed)
         {
             throw new MessageException(trans('tontine.subscription.errors.not_found'));
         }
@@ -147,16 +147,16 @@ 
     public function saveDepositAmount(Pool $pool, Session $session, int $receivableId, int $amount): void
     {
         $receivable = $this->getReceivable($pool, $session, $receivableId);
-        if(!$receivable || $pool->deposit_fixed)
+        if (!$receivable || $pool->deposit_fixed)
         {
             throw new MessageException(trans('tontine.subscription.errors.not_found'));
         }
-        if((!$receivable->deposit->editable))
+        if ((!$receivable->deposit->editable))
         {
             throw new MessageException(trans('tontine.errors.editable'));
         }
 
-        if($receivable->deposit !== null)
+        if ($receivable->deposit !== null)
         {
             $receivable->deposit->amount = $amount;
             $receivable->deposit->save();
@@ -182,11 +182,11 @@ 
     public function deleteDeposit(Pool $pool, Session $session, int $receivableId): void
     {
         $receivable = $this->getReceivable($pool, $session, $receivableId);
-        if(!$receivable || !$receivable->deposit)
+        if (!$receivable || !$receivable->deposit)
         {
             throw new MessageException(trans('tontine.subscription.errors.not_found'));
         }
-        if((!$receivable->deposit->editable))
+        if ((!$receivable->deposit->editable))
         {
             throw new MessageException(trans('tontine.errors.editable'));
         }
@@ -204,13 +204,13 @@ 
     public function createAllDeposits(Pool $pool, Session $session): void
     {
         $receivables = $this->getQuery($pool, $session)->whereDoesntHave('deposit')->get();
-        if($receivables->count() === 0)
+        if ($receivables->count() === 0)
         {
             return;
         }
 
         DB::transaction(function() use($session, $receivables) {
-            foreach($receivables as $receivable)
+            foreach ($receivables as $receivable)
             {
                 $deposit = new Deposit();
                 $deposit->receivable()->associate($receivable);
@@ -232,19 +232,19 @@ 
     {
         $receivables = $this->getQuery($pool, $session)
             ->with(['deposit'])->whereHas('deposit')->get();
-        if($receivables->count() === 0)
+        if ($receivables->count() === 0)
         {
             return;
         }
 
         DB::transaction(function() use($session, $receivables) {
-            foreach($receivables as $receivable)
+            foreach ($receivables as $receivable)
             {
                 try
                 {
                     $receivable->deposit()->where('session_id', $session->id)->delete();
                 }
-                catch(\Exception $e){}
+                catch (\Exception $e) {}
             }
         });
     }

Braces +1 added lines, -2 removed lines

@@ -243,8 +243,7 @@
                 try
                 {
                     $receivable->deposit()->where('session_id', $session->id)->delete();
-                }
-                catch(\Exception $e){}
+                } catch(\Exception $e){}
             }
         });
     }

src/Service/Meeting/Credit/RefundService.php

Spacing +11 added lines, -11 removed lines

@@ -80,7 +80,7 @@ 
                         $query->where('session_id', $sessionId);
                     });
                 });
-                if($prevSessions->count() === 0)
+                if ($prevSessions->count() === 0)
                 {
                     return;
                 }
@@ -168,11 +168,11 @@ 
         $debt = Debt::whereHas('loan', function(Builder $query) use($sessionIds) {
             $query->whereIn('session_id', $sessionIds);
         })->with(['partial_refunds'])->find($debtId);
-        if(!$debt || $debt->refund)
+        if (!$debt || $debt->refund)
         {
             throw new MessageException(trans('tontine.loan.errors.not_found'));
         }
-        if(!$this->debtCalculator->debtIsEditable($session, $debt))
+        if (!$this->debtCalculator->debtIsEditable($session, $debt))
         {
             throw new MessageException(trans('meeting.refund.errors.cannot_refund'));
         }
@@ -183,7 +183,7 @@ 
         DB::transaction(function() use($session, $debt, $refund) {
             $refund->save();
             // For simple or compound interest, also save the final amount.
-            if($debt->is_interest && !$debt->loan->fixed_interest)
+            if ($debt->is_interest && !$debt->loan->fixed_interest)
             {
                 $debt->amount = $this->debtCalculator->getDebtAmount($session, $debt);
                 $debt->save();
@@ -203,15 +203,15 @@ 
     {
         $refund = Refund::with('debt')->where('session_id', $session->id)
             ->where('debt_id', $debtId)->first();
-        if(!$refund)
+        if (!$refund)
         {
             throw new MessageException(trans('meeting.refund.errors.not_found'));
         }
-        if((!$refund->editable))
+        if ((!$refund->editable))
         {
             throw new MessageException(trans('meeting.refund.errors.cannot_delete'));
         }
-        if(!$this->debtCalculator->debtIsEditable($session, $refund->debt))
+        if (!$this->debtCalculator->debtIsEditable($session, $refund->debt))
         {
             throw new MessageException(trans('meeting.refund.errors.cannot_refund'));
         }
@@ -287,12 +287,12 @@ 
         $debt = Debt::whereHas('loan', function(Builder $query) use($sessionIds) {
             $query->whereIn('session_id', $sessionIds);
         })->find($debtId);
-        if(!$debt || $debt->refund)
+        if (!$debt || $debt->refund)
         {
             throw new MessageException(trans('meeting.refund.errors.not_found'));
         }
         // A partial refund must not totally refund a debt
-        if($amount >= $debt->due_amount)
+        if ($amount >= $debt->due_amount)
         {
             throw new MessageException(trans('meeting.refund.errors.pr_amount'));
         }
@@ -316,11 +316,11 @@ 
     {
         $refund = PartialRefund::where('session_id', $session->id)
             ->with(['debt.refund'])->find($refundId);
-        if(!$refund)
+        if (!$refund)
         {
             throw new MessageException(trans('meeting.refund.errors.not_found'));
         }
-        if($refund->debt->refund !== null || !$refund->editable)
+        if ($refund->debt->refund !== null || !$refund->editable)
         {
             throw new MessageException(trans('meeting.refund.errors.cannot_delete'));
         }

src/Service/Meeting/Charge/SettlementService.php

Spacing +11 added lines, -13 removed lines

@@ -62,19 +62,19 @@ 
         // The select('bills.*') is important here, otherwise Eloquent overrides the
         // Bill model id fields with those of another model, then making the dataset incorrect.
         $query = Bill::select('bills.*');
-        if($charge->is_variable)
+        if ($charge->is_variable)
         {
             return $query->join('libre_bills', 'libre_bills.bill_id', '=', 'bills.id')
                 ->where('libre_bills.charge_id', $charge->id)
                 ->where('libre_bills.session_id', $session->id);
         }
-        if($charge->period_session)
+        if ($charge->period_session)
         {
             return $query->join('session_bills', 'session_bills.bill_id', '=', 'bills.id')
                 ->where('session_bills.charge_id', $charge->id)
                 ->where('session_bills.session_id', $session->id);
         }
-        if($charge->period_round)
+        if ($charge->period_round)
         {
             return $query->join('round_bills', 'round_bills.bill_id', '=', 'bills.id')
                 ->where('round_bills.charge_id', $charge->id);
@@ -97,7 +97,7 @@ 
     {
         $bill = $this->getQuery($charge, $session)->with('settlement')->find($billId);
         // Return if the bill is not found or the bill is already settled.
-        if(!$bill || ($bill->settlement))
+        if (!$bill || ($bill->settlement))
         {
             throw new MessageException(trans('tontine.bill.errors.not_found'));
         }
@@ -120,11 +120,11 @@ 
     {
         $bill = $this->getQuery($charge, $session)->with('settlement')->find($billId);
         // Return if the bill is not found or the bill is not settled.
-        if(!$bill || !($bill->settlement))
+        if (!$bill || !($bill->settlement))
         {
             throw new MessageException(trans('tontine.bill.errors.not_found'));
         }
-        if((!$bill->settlement->editable))
+        if ((!$bill->settlement->editable))
         {
             throw new MessageException(trans('tontine.errors.editable'));
         }
@@ -142,13 +142,13 @@ 
     public function createAllSettlements(Charge $charge, Session $session): void
     {
         $bills = $this->getQuery($charge, $session)->whereDoesntHave('settlement')->get();
-        if($bills->count() === 0)
+        if ($bills->count() === 0)
         {
             return;
         }
 
         DB::transaction(function() use($bills, $session) {
-            foreach($bills as $bill)
+            foreach ($bills as $bill)
             {
                 $settlement = new Settlement();
                 $settlement->bill()->associate($bill);
@@ -174,12 +174,12 @@ 
             ->filter(function($bill) {
                 return $bill->settlement->editable;
             });
-        if($bills->count() === 0)
+        if ($bills->count() === 0)
         {
             return;
         }
         DB::transaction(function() use($bills, $session) {
-            foreach($bills as $bill)
+            foreach ($bills as $bill)
             {
                 $bill->settlement()->where('session_id', $session->id)->delete();
             }
@@ -194,9 +194,7 @@ 
      */
     public function getSettlement(Charge $charge, Session $session): object
     {
-        $billTable = $charge->is_variable ? 'libre_bills' :
-            ($charge->period_session ? 'session_bills' :
-            ($charge->period_round ? 'round_bills' : 'tontine_bills'));
+        $billTable = $charge->is_variable ? 'libre_bills' : ($charge->period_session ? 'session_bills' : ($charge->period_round ? 'round_bills' : 'tontine_bills'));
 
         return DB::table('settlements')
             ->select(DB::raw('count(*) as total'), DB::raw('sum(bills.amount) as amount'))