Export::downloadExportedFile() - Code Metrics - Inspection of "5056e37661fc787cb30aae5e2ef43ed4b75d7bb8" - ladybirdweb/import-export - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — develop (5056e3)

by Abhishek Kumar

created 2018-06-30 07:51 UTC

Export::downloadExportedFile() A

↳ Parent: Export

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	2
nop	1
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php

namespace Ladybirdweb\ImportExport;

use Illuminate\Database\Eloquent\Builder;
use Ladybirdweb\ImportExport\Jobs\ExportJob;
use Ladybirdweb\ImportExport\Models\Export as ModelExport;

class Export
{
	
	public function export(Builder $query, $ext = 'xls')
	{
		// Create new export
		$export = new ModelExport;

		$export->type = $ext;
		$export->query = $query->getModel();

		$export->save();

		ExportJob::dispatch( $export )->onQueue( 'exporting' );

		return $export;
	}



	public function showExportStatus($id)
    {
        // Map export instance
        $export = ModelExport::findOrFail( $id );


        return view( 'importexport::export.progress', compact( 'id' ) );
    }


    /**
     * Return export progress
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response json
     */
    public function returnExportProgress($id)
    {
        // Map export instance
        $export = ModelExport::findOrFail( $id );

        $data['status'] = 200;


        if ( $export->result_rows > 0 ) {

        	$data['progress'] = round( ( $export->row_processed / $export->result_rows ) * 100 );

        } else {

        	$data['progress'] = 0;

        }

        // If progress completed return successful imported rows count
        if ( $data['progress'] == 100 ) {
            $data['exported'] = route( 'ladybirdweb.export.download', $export->id );
        }

        return response()->json( $data );

    }


    public function downloadExportedFile($id)
    {
        // Map export instance
        $export = ModelExport::findOrFail( $id );

        if ( ! file_exists( storage_path( 'app/exports' ) . '/' . $export->file ) || empty( $export->file ) ) {
            abort(404);
        }

        return response()->download( storage_path( 'app/exports/' . $export->file ) );
    }
}


1			<?php
2
3			namespace Ladybirdweb\ImportExport;
4
5			use Illuminate\Database\Eloquent\Builder;
6			use Ladybirdweb\ImportExport\Jobs\ExportJob;
7			use Ladybirdweb\ImportExport\Models\Export as ModelExport;
8
9			class Export
10			{
11
12			public function export(Builder $query, $ext = 'xls')
13			{
14			// Create new export
15			$export = new ModelExport;
16
17			$export->type = $ext;
18			$export->query = $query->getModel();
19
20			$export->save();
21
22			ExportJob::dispatch( $export )->onQueue( 'exporting' );
23
24			return $export;
25			}
26
27
28
29			public function showExportStatus($id)
30			{
31			// Map export instance
32			$export = ModelExport::findOrFail( $id );
			0 ignored issues – show Unused Code introduced 2018-06-30 07:56 UTC by Report Bug Copy Issue Report The assignment to `$export` is dead and can be removed. Loading history...
33
34			return view( 'importexport::export.progress', compact( 'id' ) );
35			}
36
37
38			/**
39			* Return export progress
40			*
41			* @param int $id
42			* @return \Illuminate\Http\Response json
43			*/
44			public function returnExportProgress($id)
45			{
46			// Map export instance
47			$export = ModelExport::findOrFail( $id );
48
49			$data['status'] = 200;
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-06-30 07:56 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Loading history...
50
51			if ( $export->result_rows > 0 ) {
52
53			$data['progress'] = round( ( $export->row_processed / $export->result_rows ) * 100 );
54
55			} else {
56
57			$data['progress'] = 0;
58
59			}
60
61			// If progress completed return successful imported rows count
62			if ( $data['progress'] == 100 ) {
63			$data['exported'] = route( 'ladybirdweb.export.download', $export->id );
64			}
65
66			return response()->json( $data );
			0 ignored issues – show Bug Best Practice introduced 2018-06-30 07:56 UTC by Report Bug Copy Issue Report The expression `return response()->json($data)` returns the type `Illuminate\Http\JsonResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
67			}
68
69
70			public function downloadExportedFile($id)
71			{
72			// Map export instance
73			$export = ModelExport::findOrFail( $id );
74
75			if ( ! file_exists( storage_path( 'app/exports' ) . '/' . $export->file ) \|\| empty( $export->file ) ) {
76			abort(404);
77			}
78
79			return response()->download( storage_path( 'app/exports/' . $export->file ) );
80			}
81			}
82

ladybirdweb / import-export

Branch — develop (5056e3)

Export::downloadExportedFile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like