Ladybirdweb\ImportExport\Export

Complexity

Total Complexity

8

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	downloadExportedFile()	0	10	3
A	returnExportProgress()	0	23	3
A	export()	0	13	1
A	showExportStatus()	0	6	1

<?php

namespace Ladybirdweb\ImportExport;

use Illuminate\Database\Eloquent\Builder;
use Ladybirdweb\ImportExport\Jobs\ExportJob;
use Ladybirdweb\ImportExport\Models\Export as ModelExport;

class Export
{
	
	public function export(Builder $query, $ext = 'xls')
	{
		// Create new export
		$export = new ModelExport;

		$export->type = $ext;
		$export->query = $query->getModel();

		$export->save();

		ExportJob::dispatch( $export )->onQueue( 'exporting' );

		return $export;
	}



	public function showExportStatus($id)
    {
        // Map export instance
        $export = ModelExport::findOrFail( $id );

The assignment to $export is dead and can be removed.

        return view( 'importexport::export.progress', compact( 'id' ) );
    }


    /**
     * Return export progress
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response json
     */
    public function returnExportProgress($id)
    {
        // Map export instance
        $export = ModelExport::findOrFail( $id );

        $data['status'] = 200;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        if ( $export->result_rows > 0 ) {

        	$data['progress'] = round( ( $export->row_processed / $export->result_rows ) * 100 );

        } else {

        	$data['progress'] = 0;

        }

        // If progress completed return successful imported rows count
        if ( $data['progress'] == 100 ) {
            $data['exported'] = route( 'ladybirdweb.export.download', $export->id );
        }

        return response()->json( $data );

The expression return response()->json($data) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }


    public function downloadExportedFile($id)
    {
        // Map export instance
        $export = ModelExport::findOrFail( $id );

        if ( ! file_exists( storage_path( 'app/exports' ) . '/' . $export->file ) || empty( $export->file ) ) {
            abort(404);
        }

        return response()->download( storage_path( 'app/exports/' . $export->file ) );
    }
}