Issues in InterfaceController.php (master) - Issues in master - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3884)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Itil/Controllers/InterfaceController.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Itil\Controllers;

use App\Itil\Controllers\BaseServiceDeskController;
use Exception;
use Illuminate\Http\Request;

class InterfaceController extends BaseServiceDeskController {

    public function agentSidebar() {
       
        return view('itil::interface.agent.sidebar');
    }

    public function agentTopbar() {
        
        return view('itil::interface.agent.topbar');
    }

    public function agentTopSubbar() {
        
        return view('itil::interface.agent.topsubbar');
    }

    public function adminSidebar() {
        
        return view('itil::interface.admin.sidebar');
    }

    public function adminTopbar() {
        
        return view('itil::interface.admin.topbar');
    }

    public function adminTopSubbar() {
        
        return view('itil::interface.admin.topsubbar');
    }

    public function adminSettings() {
        
        return view('itil::interface.admin.settings');
    }

    public function ticketDetailTable($event) {
        $id = $event->para1;
        return view("itil::interface.agent.ticket-head", compact('id'));
    }

    public function generalInfo($id, $table, Request $request) {

        //dd($request);
        try {
            $store = UtilityController::storeGeneralInfo($id, $table, $request);
            //dd($store);
            if ($store == "success") {
                return redirect()->back()->with('success', 'Updated');
            }
            throw new Exception("Sorry we can not process your request");
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function deleteAttachments($attachid, $owner) {

        try {
            $attachments = new \App\Itil\Models\Common\Attachments();
            $attachment = $attachments->where('id', $attachid)->where('owner', $owner)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($attachment) {
                UtilityController::removeAttachment($attachment);
            } else {
                throw new Exception("Sorry we can not find your request");
            }
            return redirect()->back()->with('success', 'Updated');
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function downloadAttachments($attachid, $owner) {

        try {
            $attachments = new \App\Itil\Models\Common\Attachments();
            $attachment = $attachments->where('id', $attachid)->where('owner', $owner)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($attachment) {
                $attach = UtilityController::downloadAttachment($attachment);
                if ($attachment->saved == 2) {
                    return response()->download($attach);
                }
            } else {
                throw new Exception("Sorry we can not find your request");
            }
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function deleteGeneralByIdentifier($owner, $identifier) {

        try {
            $genereals = new \App\Itil\Models\Common\GeneralInfo();
            $genereal = $genereals->where('owner', $owner)->where('key', $identifier)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($genereal) {
                $attachments = new \App\Itil\Models\Common\Attachments();
                $atach_owner = str_replace(":", ":$identifier:", $owner);
                $attachment = $attachments->where('owner', $atach_owner)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                if($attachment){
                    UtilityController::removeAttachment($attachment);
                }
                if ($identifier == "solution") {
                    $title = $genereals->where('owner', $owner)->where('key', "solution-title")->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    if ($title) {
                        $title->delete();
                    }
                }
                $genereal->delete();
            } else {
                throw new Exception("Sorry we can not find your request");
            }
            return redirect()->back()->with('success', 'Updated');
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

}


1		<?php
2
3		namespace App\Itil\Controllers;
4
5		use App\Itil\Controllers\BaseServiceDeskController;
6		use Exception;
7		use Illuminate\Http\Request;
8
9		class InterfaceController extends BaseServiceDeskController {
10
11		public function agentSidebar() {
12
13		return view('itil::interface.agent.sidebar');
14		}
15
16		public function agentTopbar() {
17
18		return view('itil::interface.agent.topbar');
19		}
20
21		public function agentTopSubbar() {
22
23		return view('itil::interface.agent.topsubbar');
24		}
25
26		public function adminSidebar() {
27
28		return view('itil::interface.admin.sidebar');
29		}
30
31		public function adminTopbar() {
32
33		return view('itil::interface.admin.topbar');
34		}
35
36		public function adminTopSubbar() {
37
38		return view('itil::interface.admin.topsubbar');
39		}
40
41		public function adminSettings() {
42
43		return view('itil::interface.admin.settings');
44		}
45
46		public function ticketDetailTable($event) {
47		$id = $event->para1;
48		return view("itil::interface.agent.ticket-head", compact('id'));
49		}
50
51	View Code Duplication	public function generalInfo($id, $table, Request $request) {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		//dd($request);
53		try {
54		$store = UtilityController::storeGeneralInfo($id, $table, $request);
55		//dd($store);
56		if ($store == "success") {
57		return redirect()->back()->with('success', 'Updated');
58		}
59		throw new Exception("Sorry we can not process your request");
60		} catch (Exception $ex) {
61		return redirect()->back()->with('fails', $ex->getMessage());
62		}
63		}
64
65	View Code Duplication	public function deleteAttachments($attachid, $owner) {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		try {
67		$attachments = new \App\Itil\Models\Common\Attachments();
68		$attachment = $attachments->where('id', $attachid)->where('owner', $owner)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `where` does not exist on `object<App\Itil\Models\Common\Attachments>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
69		if ($attachment) {
70		UtilityController::removeAttachment($attachment);
71		} else {
72		throw new Exception("Sorry we can not find your request");
73		}
74		return redirect()->back()->with('success', 'Updated');
75		} catch (Exception $ex) {
76		return redirect()->back()->with('fails', $ex->getMessage());
77		}
78		}
79
80	View Code Duplication	public function downloadAttachments($attachid, $owner) {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		try {
82		$attachments = new \App\Itil\Models\Common\Attachments();
83		$attachment = $attachments->where('id', $attachid)->where('owner', $owner)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `where` does not exist on `object<App\Itil\Models\Common\Attachments>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
84		if ($attachment) {
85		$attach = UtilityController::downloadAttachment($attachment);
86		if ($attachment->saved == 2) {
87		return response()->download($attach);
88		}
89		} else {
90		throw new Exception("Sorry we can not find your request");
91		}
92		} catch (Exception $ex) {
93		return redirect()->back()->with('fails', $ex->getMessage());
94		}
95		}
96
97	View Code Duplication	public function deleteGeneralByIdentifier($owner, $identifier) {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		try {
99		$genereals = new \App\Itil\Models\Common\GeneralInfo();
100		$genereal = $genereals->where('owner', $owner)->where('key', $identifier)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `where` does not exist on `object<App\Itil\Models\Common\GeneralInfo>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
101		if ($genereal) {
102		$attachments = new \App\Itil\Models\Common\Attachments();
103		$atach_owner = str_replace(":", ":$identifier:", $owner);
104		$attachment = $attachments->where('owner', $atach_owner)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `where` does not exist on `object<App\Itil\Models\Common\Attachments>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
105		if($attachment){
106		UtilityController::removeAttachment($attachment);
107		}
108		if ($identifier == "solution") {
109		$title = $genereals->where('owner', $owner)->where('key', "solution-title")->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `where` does not exist on `object<App\Itil\Models\Common\GeneralInfo>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
110		if ($title) {
111		$title->delete();
112		}
113		}
114		$genereal->delete();
115		} else {
116		throw new Exception("Sorry we can not find your request");
117		}
118		return redirect()->back()->with('success', 'Updated');
119		} catch (Exception $ex) {
120		return redirect()->back()->with('fails', $ex->getMessage());
121		}
122		}
123
124		}
125

ladybirdweb / faveo-servicedesk-community

Issues (3884)

Security Analysis not enabled

app/Itil/Controllers/InterfaceController.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like