InterfaceController - Code Metrics - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

InterfaceController A
last analyzed 2017-01-27 05:23 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	116
Duplicated Lines	59.48 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes

Metric	Value
dl	69
loc	116
rs	10
c	0
b	0
f	0
wmc	24
lcom	0
cbo	7

12 Methods

Rating	Name	Duplication	Size	Complexity
A	agentSidebar()	0	4	1
A	agentTopbar()	0	4	1
A	agentTopSubbar()	0	4	1
A	adminSidebar()	0	4	1
A	adminTopbar()	0	4	1
A	adminTopSubbar()	0	4	1
A	adminSettings()	0	4	1
A	ticketDetailTable()	0	4	1
A	generalInfo()	13	13	3
A	deleteAttachments()	14	14	3
A	downloadAttachments()	16	16	4
B	deleteGeneralByIdentifier()	26	26	6

How to fix Duplicated Code

<?php

namespace App\Itil\Controllers;

use App\Itil\Controllers\BaseServiceDeskController;
use Exception;
use Illuminate\Http\Request;

class InterfaceController extends BaseServiceDeskController {

    public function agentSidebar() {
       
        return view('itil::interface.agent.sidebar');
    }

    public function agentTopbar() {
        
        return view('itil::interface.agent.topbar');
    }

    public function agentTopSubbar() {
        
        return view('itil::interface.agent.topsubbar');
    }

    public function adminSidebar() {
        
        return view('itil::interface.admin.sidebar');
    }

    public function adminTopbar() {
        
        return view('itil::interface.admin.topbar');
    }

    public function adminTopSubbar() {
        
        return view('itil::interface.admin.topsubbar');
    }

    public function adminSettings() {
        
        return view('itil::interface.admin.settings');
    }

    public function ticketDetailTable($event) {
        $id = $event->para1;
        return view("itil::interface.agent.ticket-head", compact('id'));
    }

    public function generalInfo($id, $table, Request $request) {

        //dd($request);
        try {
            $store = UtilityController::storeGeneralInfo($id, $table, $request);
            //dd($store);
            if ($store == "success") {
                return redirect()->back()->with('success', 'Updated');
            }
            throw new Exception("Sorry we can not process your request");
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function deleteAttachments($attachid, $owner) {

        try {
            $attachments = new \App\Itil\Models\Common\Attachments();
            $attachment = $attachments->where('id', $attachid)->where('owner', $owner)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($attachment) {
                UtilityController::removeAttachment($attachment);
            } else {
                throw new Exception("Sorry we can not find your request");
            }
            return redirect()->back()->with('success', 'Updated');
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function downloadAttachments($attachid, $owner) {

        try {
            $attachments = new \App\Itil\Models\Common\Attachments();
            $attachment = $attachments->where('id', $attachid)->where('owner', $owner)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($attachment) {
                $attach = UtilityController::downloadAttachment($attachment);
                if ($attachment->saved == 2) {
                    return response()->download($attach);
                }
            } else {
                throw new Exception("Sorry we can not find your request");
            }
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function deleteGeneralByIdentifier($owner, $identifier) {

        try {
            $genereals = new \App\Itil\Models\Common\GeneralInfo();
            $genereal = $genereals->where('owner', $owner)->where('key', $identifier)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($genereal) {
                $attachments = new \App\Itil\Models\Common\Attachments();
                $atach_owner = str_replace(":", ":$identifier:", $owner);
                $attachment = $attachments->where('owner', $atach_owner)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                if($attachment){
                    UtilityController::removeAttachment($attachment);
                }
                if ($identifier == "solution") {
                    $title = $genereals->where('owner', $owner)->where('key', "solution-title")->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    if ($title) {
                        $title->delete();
                    }
                }
                $genereal->delete();
            } else {
                throw new Exception("Sorry we can not find your request");
            }
            return redirect()->back()->with('success', 'Updated');
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

}


1		<?php
2
3		namespace App\Itil\Controllers;
4
5		use App\Itil\Controllers\BaseServiceDeskController;
6		use Exception;
7		use Illuminate\Http\Request;
8
9		class InterfaceController extends BaseServiceDeskController {
10
11		public function agentSidebar() {
12
13		return view('itil::interface.agent.sidebar');
14		}
15
16		public function agentTopbar() {
17
18		return view('itil::interface.agent.topbar');
19		}
20
21		public function agentTopSubbar() {
22
23		return view('itil::interface.agent.topsubbar');
24		}
25
26		public function adminSidebar() {
27
28		return view('itil::interface.admin.sidebar');
29		}
30
31		public function adminTopbar() {
32
33		return view('itil::interface.admin.topbar');
34		}
35
36		public function adminTopSubbar() {
37
38		return view('itil::interface.admin.topsubbar');
39		}
40
41		public function adminSettings() {
42
43		return view('itil::interface.admin.settings');
44		}
45
46		public function ticketDetailTable($event) {
47		$id = $event->para1;
48		return view("itil::interface.agent.ticket-head", compact('id'));
49		}
50
51	View Code Duplication	public function generalInfo($id, $table, Request $request) {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		//dd($request);
53		try {
54		$store = UtilityController::storeGeneralInfo($id, $table, $request);
55		//dd($store);
56		if ($store == "success") {
57		return redirect()->back()->with('success', 'Updated');
58		}
59		throw new Exception("Sorry we can not process your request");
60		} catch (Exception $ex) {
61		return redirect()->back()->with('fails', $ex->getMessage());
62		}
63		}
64
65	View Code Duplication	public function deleteAttachments($attachid, $owner) {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		try {
67		$attachments = new \App\Itil\Models\Common\Attachments();
68		$attachment = $attachments->where('id', $attachid)->where('owner', $owner)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Itil\Models\Common\Attachments>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
69		if ($attachment) {
70		UtilityController::removeAttachment($attachment);
71		} else {
72		throw new Exception("Sorry we can not find your request");
73		}
74		return redirect()->back()->with('success', 'Updated');
75		} catch (Exception $ex) {
76		return redirect()->back()->with('fails', $ex->getMessage());
77		}
78		}
79
80	View Code Duplication	public function downloadAttachments($attachid, $owner) {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		try {
82		$attachments = new \App\Itil\Models\Common\Attachments();
83		$attachment = $attachments->where('id', $attachid)->where('owner', $owner)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Itil\Models\Common\Attachments>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
84		if ($attachment) {
85		$attach = UtilityController::downloadAttachment($attachment);
86		if ($attachment->saved == 2) {
87		return response()->download($attach);
88		}
89		} else {
90		throw new Exception("Sorry we can not find your request");
91		}
92		} catch (Exception $ex) {
93		return redirect()->back()->with('fails', $ex->getMessage());
94		}
95		}
96
97	View Code Duplication	public function deleteGeneralByIdentifier($owner, $identifier) {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		try {
99		$genereals = new \App\Itil\Models\Common\GeneralInfo();
100		$genereal = $genereals->where('owner', $owner)->where('key', $identifier)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Itil\Models\Common\GeneralInfo>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
101		if ($genereal) {
102		$attachments = new \App\Itil\Models\Common\Attachments();
103		$atach_owner = str_replace(":", ":$identifier:", $owner);
104		$attachment = $attachments->where('owner', $atach_owner)->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Itil\Models\Common\Attachments>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
105		if($attachment){
106		UtilityController::removeAttachment($attachment);
107		}
108		if ($identifier == "solution") {
109		$title = $genereals->where('owner', $owner)->where('key', "solution-title")->first();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report The method `where` does not exist on `object<App\Itil\Models\Common\GeneralInfo>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
110		if ($title) {
111		$title->delete();
112		}
113		}
114		$genereal->delete();
115		} else {
116		throw new Exception("Sorry we can not find your request");
117		}
118		return redirect()->back()->with('success', 'Updated');
119		} catch (Exception $ex) {
120		return redirect()->back()->with('fails', $ex->getMessage());
121		}
122		}
123
124		}
125

ladybirdweb / faveo-servicedesk-community

InterfaceController A last analyzed 2017-01-27 05:23 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

InterfaceController A
last analyzed 2017-01-27 05:23 UTC