Completed
Pull Request — master (#6)
by Kris
02:53
created
lib/Query/SelectBase.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      * @access protected
102 102
      * @var    QueryBuilder
103 103
      */
104
-     protected $topQuery = null;
104
+        protected $topQuery = null;
105 105
 
106 106
     /**
107 107
      * Constructor
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         }
123 123
     }
124 124
 
125
-   /**
125
+    /**
126 126
      * Parse the columns arguments for the select query
127 127
      *
128 128
      * @access protected
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
      */
201 201
     public function count($alias)
202 202
     {
203
-         $this->columns[] = array(
203
+            $this->columns[] = array(
204 204
             'type'  => 'count',
205 205
             'alias' => $alias
206 206
         );
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
      */
218 218
     public function sum($column, $alias)
219 219
     {
220
-         $this->columns[] = array(
220
+            $this->columns[] = array(
221 221
             'type'  => 'sum',
222 222
             'name'  => $column,
223 223
             'alias' => $alias
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
      */
236 236
     public function min($column, $alias)
237 237
     {
238
-         $this->columns[] = array(
238
+            $this->columns[] = array(
239 239
             'type'  => 'min',
240 240
             'name'  => $column,
241 241
             'alias' => $alias
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
      */
254 254
     public function max($column, $alias)
255 255
     {
256
-         $this->columns[] = array(
256
+            $this->columns[] = array(
257 257
             'type'  => 'max',
258 258
             'name'  => $column,
259 259
             'alias' => $alias
Please login to merge, or discard this patch.
lib/Query/QueryBuilder.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
      *
139 139
      * @return string
140 140
      */
141
-    public function __construct( $driver)
141
+    public function __construct($driver)
142 142
     {
143 143
         $this->driver = $driver;
144 144
     }
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
             }
203 203
 
204 204
             // register error 
205
-            $this->error['code'] = (int)$e->getCode();
205
+            $this->error['code'] = (int) $e->getCode();
206 206
             $this->error['message'] = $e->getMessage();
207 207
             return false;
208 208
         }
@@ -226,13 +226,13 @@  discard block
 block discarded – undo
226 226
                 $paramType = \PDO::PARAM_STR; // default
227 227
 
228 228
                 if (!isset($val)) {
229
-                    $paramType =  \PDO::PARAM_NULL;
229
+                    $paramType = \PDO::PARAM_NULL;
230 230
                 
231 231
                 } elseif (is_int($val)) {
232
-                    $paramType =  \PDO::PARAM_INT;
232
+                    $paramType = \PDO::PARAM_INT;
233 233
                 
234 234
                 } elseif (is_bool($val)) {
235
-                    $paramType =  \PDO::PARAM_BOOL;
235
+                    $paramType = \PDO::PARAM_BOOL;
236 236
                 } 
237 237
                 
238 238
                 // bind value
@@ -251,8 +251,8 @@  discard block
 block discarded – undo
251 251
     {
252 252
         try {
253 253
             // prepare bind execute
254
-            if (!isset($this->pdoStatement)){
255
-               if (!$this->prepare()){
254
+            if (!isset($this->pdoStatement)) {
255
+               if (!$this->prepare()) {
256 256
                    return false;
257 257
                }
258 258
             }
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
             }
268 268
 
269 269
             // register error 
270
-            $this->error['code'] = (int)$e->getCode();
270
+            $this->error['code'] = (int) $e->getCode();
271 271
             $this->error['message'] = $e->getMessage();
272 272
             return false;
273 273
         }
@@ -297,23 +297,23 @@  discard block
 block discarded – undo
297 297
      */
298 298
     protected static function fetchOutput(QueryBuilder $query, $executed, $outputFormat)
299 299
     {
300
-        switch (strtoupper($outputFormat)){
300
+        switch (strtoupper($outputFormat)) {
301 301
 
302 302
             case Output::ASSOC:    
303
-                return $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_ASSOC) :  array();
303
+                return $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_ASSOC) : array();
304 304
 
305 305
             case Output::OBJ:    
306
-                return $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_OBJ) :    array();
306
+                return $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_OBJ) : array();
307 307
 
308 308
             case Output::COLUMN:    
309
-                return $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_COLUMN) :  array();
309
+                return $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_COLUMN) : array();
310 310
 
311 311
             case Output::JSON:
312
-                $results = $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_ASSOC) :  array();
312
+                $results = $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_ASSOC) : array();
313 313
                 return json_encode($results, JSON_NUMERIC_CHECK);   
314 314
 
315 315
             case Output::JSON_PRETTY_PRINT:    
316
-                $results = $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_ASSOC) :  array();
316
+                $results = $executed ? $query->pdoStatement->fetchAll(\PDO::FETCH_ASSOC) : array();
317 317
                 return json_encode($results, JSON_PRETTY_PRINT | JSON_NUMERIC_CHECK);   
318 318
                 
319 319
             default:
Please login to merge, or discard this patch.
lib/Query/Select.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
57 57
     protected function getArgumentName($column)
58 58
     {
59 59
         $topQuery = $this->topQuery ?: $this;  
60
-        $arg = ':_' . str_replace('.', '_', $column); 
61
-        return $topQuery->sqlParameterExists($arg) ? $arg . uniqid() : $arg;
60
+        $arg = ':_'.str_replace('.', '_', $column); 
61
+        return $topQuery->sqlParameterExists($arg) ? $arg.uniqid() : $arg;
62 62
     }
63 63
     
64 64
     /**
@@ -70,22 +70,22 @@  discard block
 block discarded – undo
70 70
     private function sqlColumns()
71 71
     {
72 72
         // no columns givens select all (SELECT *)
73
-        if (!count($this->columns) > 0 ) {
73
+        if (!count($this->columns) > 0) {
74 74
             return '*';   
75 75
         }
76 76
 
77 77
         // use DISTINCT ?
78
-        $sqlDistinct    = $this->distinct ? 'DISTINCT ': '';
78
+        $sqlDistinct = $this->distinct ? 'DISTINCT ' : '';
79 79
 
80 80
         // parse columns
81 81
         $colsList = array();
82
-        foreach ($this->columns as $val){
83
-            switch ($val['type']){
82
+        foreach ($this->columns as $val) {
83
+            switch ($val['type']) {
84 84
                    
85 85
                 // 'classic' column
86 86
                 case 'column':
87 87
                     $name       = $this->escape($val['name']);
88
-                    $alias      = isset($val['alias']) ? 'AS '. $this->escape($val['alias']) : '';
88
+                    $alias      = isset($val['alias']) ? 'AS '.$this->escape($val['alias']) : '';
89 89
                     $colsList[] = trim(sprintf('%s %s', $name, $alias));
90 90
                     break;  
91 91
                    
@@ -97,31 +97,31 @@  discard block
 block discarded – undo
97 97
                 // SUM() column
98 98
                 case 'sum':
99 99
                     $name       = $this->escape($val['name']);
100
-                    $alias      = isset($val['alias']) ? ' AS '. $this->escape($val['alias']) : '';
101
-                    $colsList[] = sprintf('SUM(%s)', $name) . $alias;
100
+                    $alias      = isset($val['alias']) ? ' AS '.$this->escape($val['alias']) : '';
101
+                    $colsList[] = sprintf('SUM(%s)', $name).$alias;
102 102
                     break;  
103 103
 
104 104
                 // MIN() column
105 105
                 case 'min':
106 106
                     $name       = $this->escape($val['name']);
107
-                    $alias      = isset($val['alias']) ? ' AS '. $this->escape($val['alias']) : '';
108
-                    $colsList[] = sprintf('MIN(%s)', $name) . $alias;
107
+                    $alias      = isset($val['alias']) ? ' AS '.$this->escape($val['alias']) : '';
108
+                    $colsList[] = sprintf('MIN(%s)', $name).$alias;
109 109
                     break;   
110 110
                     
111 111
                 // max() column
112 112
                 case 'max':
113 113
                     $name       = $this->escape($val['name']);
114
-                    $alias      = isset($val['alias']) ? ' AS '. $this->escape($val['alias']) : '';
115
-                    $colsList[] = sprintf('MAX(%s)', $name) . $alias;
114
+                    $alias      = isset($val['alias']) ? ' AS '.$this->escape($val['alias']) : '';
115
+                    $colsList[] = sprintf('MAX(%s)', $name).$alias;
116 116
                     break;        
117 117
 
118 118
                 // sub query
119 119
                 case 'sub_query':
120
-                    $colsList[] = '('. $val['query']->sql() .') AS '. $this->escape($val['alias']);
120
+                    $colsList[] = '('.$val['query']->sql().') AS '.$this->escape($val['alias']);
121 121
                     break;
122 122
            }
123 123
         }
124
-        return $sqlDistinct . implode(', ', $colsList);
124
+        return $sqlDistinct.implode(', ', $colsList);
125 125
     }
126 126
     
127 127
     /**
@@ -133,26 +133,26 @@  discard block
 block discarded – undo
133 133
     public function sql()
134 134
     {
135 135
         $topQuery = $this->topQuery ?: $this;  
136
-        $sqlJoins = empty($this->joins) ? '' : implode(' ', $this->joins) ; 
137
-        $sqlFromTable =  'FROM '. $this->escape($this->fromTable);
136
+        $sqlJoins = empty($this->joins) ? '' : implode(' ', $this->joins); 
137
+        $sqlFromTable = 'FROM '.$this->escape($this->fromTable);
138 138
         $sqlWhere = isset($this->where) ? $this->where->sql() : '';
139 139
         $sqlGroupBy = empty($this->groupBy) ? '' : 'GROUP BY '.implode(', ', $this->escapeList($this->groupBy));
140 140
         $sqlHaving = isset($this->having) ? $this->having->sql() : '';
141 141
 
142 142
         // order by
143 143
         $sqlOrderBy = '';
144
-        if (! empty($this->orderBy)){
144
+        if (!empty($this->orderBy)) {
145 145
             $sortArgs = [];
146
-            foreach ($this->orderBy as $item){
147
-                $sql = $item['column'] ? $this->escape($item['column']) . ' ' : '';
148
-                $sortArgs[] = $sql . $item['order'];
146
+            foreach ($this->orderBy as $item) {
147
+                $sql = $item['column'] ? $this->escape($item['column']).' ' : '';
148
+                $sortArgs[] = $sql.$item['order'];
149 149
             }
150
-            $sqlOrderBy = 'ORDER BY ' . implode(', ', $sortArgs);
150
+            $sqlOrderBy = 'ORDER BY '.implode(', ', $sortArgs);
151 151
         }
152 152
 
153 153
         // limit
154 154
         $sqlLimit = '';
155
-        if ($this->limit > 0){
155
+        if ($this->limit > 0) {
156 156
             $argName = $this->getArgumentName('LIMIT');   
157 157
             $topQuery->setSqlParameter($argName, $this->limit); 
158 158
             $sqlLimit = 'LIMIT '.$argName;
@@ -160,10 +160,10 @@  discard block
 block discarded – undo
160 160
 
161 161
         // offset
162 162
         $sqlOffset = '';
163
-        if ($this->offset > 0){
163
+        if ($this->offset > 0) {
164 164
             $argName = $this->getArgumentName('OFFSET');   
165 165
             $topQuery->setSqlParameter($argName, $this->offset); 
166
-            $sqlOffset = 'OFFSET ' . $argName;
166
+            $sqlOffset = 'OFFSET '.$argName;
167 167
         }
168 168
 
169 169
         return trim(implode(' ', ['SELECT', 
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
     public function getColumn()
224 224
     {
225 225
         $this->limit(1);
226
-        return $this->execute() ? $this->pdoStatement->fetchColumn() : NULL ;
226
+        return $this->execute() ? $this->pdoStatement->fetchColumn() : NULL;
227 227
     }
228 228
 
229 229
 }
230 230
\ No newline at end of file
Please login to merge, or discard this patch.
lib/Driver/DatabaseDriver.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -135,8 +135,8 @@
 block discarded – undo
135 135
      */
136 136
     public function escape($str)
137 137
     {
138
-       $list = explode('.', $str);
139
-       return implode('.', $this->escapeList($list));
138
+        $list = explode('.', $str);
139
+        return implode('.', $this->escapeList($list));
140 140
     }
141 141
 
142 142
     /**
Please login to merge, or discard this patch.
lib/Driver/Mysql/MysqlDriver.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         $port    = !empty($settings['port'])     ?  ';port='.$settings['port']        : '';
90 90
         $dbname  = !empty($settings['database']) ?  ';dbname='.$settings['database']  : '';
91 91
         $options = [
92
-          //  \PDO::ATTR_EMULATE_PREPARES => false,
92
+            //  \PDO::ATTR_EMULATE_PREPARES => false,
93 93
         ];
94 94
 
95 95
         $this->pdo = new \PDO(
@@ -153,11 +153,11 @@  discard block
 block discarded – undo
153 153
     public function addForeignKey($fkName, $srcTable, $srcColumn, $refTable, $refColumn)
154 154
     {
155 155
         $sql = sprintf('ALTER TABLE %s ADD CONSTRAINT %s FOREIGN KEY (%s) REFERENCES %s(%s)',
156
-                       $this->escape($srcTable),
157
-                       $fkName,
158
-                       $this->escape($srcColumn),
159
-                       $this->escape($refTable),
160
-                       $this->escape($refColumn)
156
+                        $this->escape($srcTable),
157
+                        $fkName,
158
+                        $this->escape($srcColumn),
159
+                        $this->escape($refTable),
160
+                        $this->escape($refColumn)
161 161
         );
162 162
         return $this->prepareAndExecuteSql($sql);
163 163
     }
@@ -174,8 +174,8 @@  discard block
 block discarded – undo
174 174
     public function dropForeignKey($fkName, $tableName)
175 175
     {
176 176
         $sql = sprintf('ALTER TABLE %s DROP FOREIGN KEY %s',
177
-                       $this->escape($tableName),
178
-                       $fkName
177
+                        $this->escape($tableName),
178
+                        $fkName
179 179
         );
180 180
         return $this->prepareAndExecuteSql($sql);
181 181
     }
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
                     "'" . $userPassword ."'"
231 231
         ));
232 232
         return $this->prepareAndExecuteSql($sql);
233
-   }
233
+    }
234 234
 
235 235
     /**
236 236
      * Drop a user
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
      *
261 261
      * @return bool     True if the user has been granted, otherwise false. 
262 262
      */
263
-     public function grantUser($databaseName, $userName)
263
+        public function grantUser($databaseName, $userName)
264 264
     {
265 265
         $sql = trim(sprintf('GRANT ALL ON %s.* TO %s@%s; FLUSH PRIVILEGES;', 
266 266
             $this->escape($databaseName),
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
      */
60 60
     public function escapeIdentifier($identifier)
61 61
     {
62
-        return '`' . $identifier .'`';
62
+        return '`'.$identifier.'`';
63 63
     }
64 64
 
65 65
     /**
@@ -85,15 +85,15 @@  discard block
 block discarded – undo
85 85
      */
86 86
     public function createConnection(array $settings)
87 87
     {
88
-        $charset = !empty($settings['charset'])  ?  ';charset='.$settings['charset']  : ';charset=utf8';
89
-        $port    = !empty($settings['port'])     ?  ';port='.$settings['port']        : '';
90
-        $dbname  = !empty($settings['database']) ?  ';dbname='.$settings['database']  : '';
88
+        $charset = !empty($settings['charset']) ? ';charset='.$settings['charset'] : ';charset=utf8';
89
+        $port    = !empty($settings['port']) ? ';port='.$settings['port'] : '';
90
+        $dbname  = !empty($settings['database']) ? ';dbname='.$settings['database'] : '';
91 91
         $options = [
92 92
           //  \PDO::ATTR_EMULATE_PREPARES => false,
93 93
         ];
94 94
 
95 95
         $this->pdo = new \PDO(
96
-            'mysql:host='.$settings['hostname'] .$port .$dbname .$charset,
96
+            'mysql:host='.$settings['hostname'].$port.$dbname.$charset,
97 97
             $settings['username'],
98 98
             $settings['password'],
99 99
             $options
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
     {
193 193
         $sql = 'SELECT SCHEMA_NAME FROM INFORMATION_SCHEMA.SCHEMATA WHERE SCHEMA_NAME = :dbName'; 
194 194
         $query = $this->pdo->prepare($sql);
195
-        $query->bindValue(':dbName',  $databaseName, \PDO::PARAM_STR);
195
+        $query->bindValue(':dbName', $databaseName, \PDO::PARAM_STR);
196 196
         $query->execute();
197 197
         return (bool) $query->fetchColumn();
198 198
     }
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
      */
210 210
     public function createDatabase($databaseName, $owner)
211 211
     {
212
-        $sql = trim(sprintf('CREATE DATABASE %s',  $this->escape($databaseName)));
212
+        $sql = trim(sprintf('CREATE DATABASE %s', $this->escape($databaseName)));
213 213
         return $this->prepareAndExecuteSql($sql);
214 214
     }
215 215
     
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
         $sql = trim(sprintf('CREATE USER %s@%s IDENTIFIED BY %s', 
228 228
                     $this->escape($userName),
229 229
                     $this->escape($this->getHostName()),
230
-                    "'" . $userPassword ."'"
230
+                    "'".$userPassword."'"
231 231
         ));
232 232
         return $this->prepareAndExecuteSql($sql);
233 233
    }
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
     public function dropUser($userName, $ifExists = false)
245 245
     {
246 246
         $sql = trim(sprintf('DROP USER %s %s@%s', 
247
-                    $ifExists === true ? 'IF EXISTS': '',
247
+                    $ifExists === true ? 'IF EXISTS' : '',
248 248
                     $this->escape($userName),
249 249
                     $this->escape($this->getHostName())
250 250
         ));
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
      */
312 312
     public function sqlCreateTableOptions() 
313 313
     {
314
-        $engine =  !empty($settings['engine'])  ? $settings['engine']  : 'InnoDB';
314
+        $engine = !empty($settings['engine']) ? $settings['engine'] : 'InnoDB';
315 315
         $charset = !empty($settings['charset']) ? $settings['charset'] : 'utf8';
316 316
         $collate = !empty($settings['collate']) ? $settings['collate'] : 'utf8_unicode_ci';
317 317
         return sprintf('ENGINE=%s DEFAULT CHARSET=%s COLLATE=%s;', $engine, $charset, $collate);
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
      */
341 341
     public function sqlColumnAutoIncrement($type)
342 342
     {
343
-        return $type .' AUTO_INCREMENT';
343
+        return $type.' AUTO_INCREMENT';
344 344
     }
345 345
     
346 346
 }
Please login to merge, or discard this patch.