Database::getInstance() - Code Metrics - kokororin/Kotori.php - Measure and Improve Code Quality continuously with Scrutinizer

Database::getInstance() C
last analyzed 2018-05-04 03:56 UTC

↳ Parent: Database

Complexity

Conditions	8
Paths	10

Size

Total Lines	28
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	36.6188

Importance

Changes

Metric	Value
cc	8
eloc	19
nc	10
nop	1
dl	0
loc	28
ccs	4
cts	17
cp	0.2353
crap	36.6188
rs	5.3846
c	0
b	0
f	0

<?php
/**
 * Kotori.php
 *
 * A Tiny Model-View-Controller PHP Framework
 *
 * This content is released under the Apache 2 License
 *
 * Copyright (c) 2015-2017 Kotori Technology. All rights reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

/**
 * Database Class
 *
 * @package     Kotori
 * @subpackage  Core
 * @author      Kokororin
 * @link        https://kotori.love
 */
namespace Kotori\Core;

use Exception;
use Kotori\Debug\Hook;
use Kotori\Exception\DatabaseException;
use Medoo\Medoo;
use PDOException;

class Database extends Medoo
{
    /**
     * SQL queries
     *
     * @var array
     */
    public static $queries = [];

    /**
     * Instance Handle
     *
     * @var array
     */
    protected static $instance;

    /**
     * Disable Clone
     *
     * @return boolean
     */
    public function __clone()
    {
        return false;
    }

    /**
     * Get singleton
     *
     * @param  string  $key
     * @return object
     *
     * @throws \Kotori\Exception\DatabaseException
     */
    public static function getInstance($key = null)
    {
        $config = Container::get('config')->get('db');
        if (!is_array($config) || count($config) == 0) {
            return null;
        } elseif ($key == null) {

            $dbKeys = array_keys($config);
            if (isset($dbKeys[0])) {
                $key = $dbKeys[0];
            } else {
                return null;
            }
        }

        Container::get('config')->set('selected_db_key', $key);

        if (!isset(self::$instance[$key])) {
            try {
                self::$instance[$key] = new self($config[$key]);
            } catch (PDOException $e) {
                throw new DatabaseException($e);
            } catch (Exception $e) {
                throw new DatabaseException($e);
            }
        }

        return self::$instance[$key];
    }

    /**
     * Class constructor
     *
     * Initialize Database.
     */
    public function __construct(array $options = [])
    {
        parent::__construct([
            'database_type' => $options['type'],
            'database_name' => $options['name'],
            'server' => $options['host'],
            'username' => $options['user'],
            'password' => $options['pwd'],
            'charset' => $options['charset'],
            'port' => $options['port'],
        ]);
        Hook::listen(__CLASS__);
    }

    /**
     * medoo::query()
     *
     * @param  string $query
     * @param  array  $map
     * @return \PDOStatement
     */
    public function query($query, $map = [])

    {
        $statement = parent::exec($query, $map);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $lastSQL = parent::last();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        Container::get('logger')->info($lastSQL);
        array_push(self::$queries, $lastSQL);
        return $statement;
    }

    /**
     * medoo:exec()
     *
     * @param  string $query
     * @param  array  $map
     * @return \PDOStatement
     */
    public function exec($query, $map = [])

    {
        $statement = parent::exec($query, $map);

        $lastSQL = parent::last();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        Container::get('logger')->info($lastSQL);
        array_push(self::$queries, $lastSQL);
        return $statement;
    }
}


1			<?php
2			/**
3			* Kotori.php
4			*
5			* A Tiny Model-View-Controller PHP Framework
6			*
7			* This content is released under the Apache 2 License
8			*
9			* Copyright (c) 2015-2017 Kotori Technology. All rights reserved.
10			*
11			* Licensed under the Apache License, Version 2.0 (the "License");
12			* you may not use this file except in compliance with the License.
13			* You may obtain a copy of the License at
14			*
15			* http://www.apache.org/licenses/LICENSE-2.0
16			*
17			* Unless required by applicable law or agreed to in writing, software
18			* distributed under the License is distributed on an "AS IS" BASIS,
19			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
20			* See the License for the specific language governing permissions and
21			* limitations under the License.
22			*/
23
24			/**
25			* Database Class
26			*
27			* @package Kotori
28			* @subpackage Core
29			* @author Kokororin
30			* @link https://kotori.love
31			*/
32			namespace Kotori\Core;
33
34			use Exception;
35			use Kotori\Debug\Hook;
36			use Kotori\Exception\DatabaseException;
37			use Medoo\Medoo;
38			use PDOException;
39
40			class Database extends Medoo
41			{
42			/**
43			* SQL queries
44			*
45			* @var array
46			*/
47			public static $queries = [];
48
49			/**
50			* Instance Handle
51			*
52			* @var array
53			*/
54			protected static $instance;
55
56			/**
57			* Disable Clone
58			*
59			* @return boolean
60			*/
61			public function __clone()
62			{
63			return false;
64			}
65
66			/**
67			* Get singleton
68			*
69			* @param string $key
70			* @return object
71			*
72			* @throws \Kotori\Exception\DatabaseException
73			*/
74	2		public static function getInstance($key = null)
75			{
76	2		$config = Container::get('config')->get('db');
77	2		if (!is_array($config) \|\| count($config) == 0) {
78	2		return null;
79			} elseif ($key == null) {
			0 ignored issues – show Bug introduced 2017-11-30 07:51 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$key` of type `string\|null` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
80			$dbKeys = array_keys($config);
81			if (isset($dbKeys[0])) {
82			$key = $dbKeys[0];
83			} else {
84			return null;
85			}
86			}
87
88			Container::get('config')->set('selected_db_key', $key);
89
90			if (!isset(self::$instance[$key])) {
91			try {
92			self::$instance[$key] = new self($config[$key]);
93			} catch (PDOException $e) {
94			throw new DatabaseException($e);
95			} catch (Exception $e) {
96			throw new DatabaseException($e);
97			}
98			}
99
100			return self::$instance[$key];
101			}
102
103			/**
104			* Class constructor
105			*
106			* Initialize Database.
107			*/
108			public function __construct(array $options = [])
109			{
110			parent::__construct([
111			'database_type' => $options['type'],
112			'database_name' => $options['name'],
113			'server' => $options['host'],
114			'username' => $options['user'],
115			'password' => $options['pwd'],
116			'charset' => $options['charset'],
117			'port' => $options['port'],
118			]);
119			Hook::listen(__CLASS__);
120			}
121
122			/**
123			* medoo::query()
124			*
125			* @param string $query
126			* @param array $map
127			* @return \PDOStatement
128			*/
129		View Code Duplication	public function query($query, $map = [])
			0 ignored issues – show Duplication introduced 2017-11-30 07:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
130			{
131			$statement = parent::exec($query, $map);
			0 ignored issues – show Comprehensibility Bug introduced 2017-05-14 09:30 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`exec()` instead of `query()`). Are you sure this is correct? If so, you might want to change this to `$this->exec()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Comprehensibility Best Practice introduced 2017-12-03 09:38 UTC by Report Bug Copy Issue Report The expression `parent::exec($query, $map);` of type `false\|PDOStatement` adds `false` to the return on line 135 which is incompatible with the return type documented by `Kotori\Core\Database::query` of type `PDOStatement`. It seems like you forgot to handle an error condition. Loading history...
132			$lastSQL = parent::last();
			0 ignored issues – show Comprehensibility Bug introduced 2017-05-14 09:30 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`last()` instead of `query()`). Are you sure this is correct? If so, you might want to change this to `$this->last()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
133			Container::get('logger')->info($lastSQL);
134			array_push(self::$queries, $lastSQL);
135			return $statement;
136			}
137
138			/**
139			* medoo:exec()
140			*
141			* @param string $query
142			* @param array $map
143			* @return \PDOStatement
144			*/
145	4	View Code Duplication	public function exec($query, $map = [])
			0 ignored issues – show Duplication introduced 2017-11-30 07:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
146			{
147	4		$statement = parent::exec($query, $map);
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-12-03 09:38 UTC by Report Bug Copy Issue Report The expression `parent::exec($query, $map);` of type `false\|PDOStatement` adds `false` to the return on line 151 which is incompatible with the return type documented by `Kotori\Core\Database::exec` of type `PDOStatement`. It seems like you forgot to handle an error condition. Loading history...
148	4		$lastSQL = parent::last();
			0 ignored issues – show Comprehensibility Bug introduced 2017-05-14 09:30 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`last()` instead of `exec()`). Are you sure this is correct? If so, you might want to change this to `$this->last()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
149	4		Container::get('logger')->info($lastSQL);
150	4		array_push(self::$queries, $lastSQL);
151	4		return $statement;
152			}
153			}
154

kokororin / Kotori.php

GitHub Access Token became invalid

Database::getInstance() C last analyzed 2018-05-04 03:56 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Database::getInstance() C
last analyzed 2018-05-04 03:56 UTC