Kotori\Core\Database

Complexity

Total Complexity

12

Size/Duplication

Total Lines	114
Duplicated Lines	14.04 %

Coupling/Cohesion

Components	2
Dependencies	4

Test Coverage

Coverage

23.81%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	1
A	__clone()	0	4	1
C	getInstance()	0	28	8
A	query()	8	8	1
A	exec()	8	8	1

<?php
/**
 * Kotori.php
 *
 * A Tiny Model-View-Controller PHP Framework
 *
 * This content is released under the Apache 2 License
 *
 * Copyright (c) 2015-2017 Kotori Technology. All rights reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

/**
 * Database Class
 *
 * @package     Kotori
 * @subpackage  Core
 * @author      Kokororin
 * @link        https://kotori.love
 */
namespace Kotori\Core;

use Exception;
use Kotori\Debug\Hook;
use Kotori\Exception\DatabaseException;
use Medoo\Medoo;
use PDOException;

class Database extends Medoo
{
    /**
     * SQL queries
     *
     * @var array
     */
    public static $queries = [];

    /**
     * Instance Handle
     *
     * @var array
     */
    protected static $instance;

    /**
     * Disable Clone
     *
     * @return boolean
     */
    public function __clone()
    {
        return false;
    }

    /**
     * Get singleton
     *
     * @param  string  $key
     * @return object
     *
     * @throws \Kotori\Exception\DatabaseException
     */
    public static function getInstance($key = null)
    {
        $config = Container::get('config')->get('db');
        if (!is_array($config) || count($config) == 0) {
            return null;
        } elseif ($key == null) {

It seems like you are loosely comparing $key of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $dbKeys = array_keys($config);
            if (isset($dbKeys[0])) {
                $key = $dbKeys[0];
            } else {
                return null;
            }
        }

        Container::get('config')->set('selected_db_key', $key);

        if (!isset(self::$instance[$key])) {
            try {
                self::$instance[$key] = new self($config[$key]);
            } catch (PDOException $e) {
                throw new DatabaseException($e);
            } catch (Exception $e) {
                throw new DatabaseException($e);
            }
        }

        return self::$instance[$key];
    }

    /**
     * Class constructor
     *
     * Initialize Database.
     */
    public function __construct(array $options = [])
    {
        parent::__construct([
            'database_type' => $options['type'],
            'database_name' => $options['name'],
            'server' => $options['host'],
            'username' => $options['user'],
            'password' => $options['pwd'],
            'charset' => $options['charset'],
            'port' => $options['port'],
        ]);
        Hook::listen(__CLASS__);
    }

    /**
     * medoo::query()
     *
     * @param  string $query
     * @param  array  $map
     * @return \PDOStatement
     */
    public function query($query, $map = [])

This method seems to be duplicated in your project.

    {
        $statement = parent::exec($query, $map);

It seems like you call parent on a different method (exec() instead of query()). Are you sure this is correct? If so, you might want to change this to $this->exec().

The expression parent::exec($query, $map); of type false|PDOStatement adds false to the return on line 135 which is incompatible with the return type documented by Kotori\Core\Database::query of type PDOStatement. It seems like you forgot to handle an error condition.

        $lastSQL = parent::last();

It seems like you call parent on a different method (last() instead of query()). Are you sure this is correct? If so, you might want to change this to $this->last().

        Container::get('logger')->info($lastSQL);
        array_push(self::$queries, $lastSQL);
        return $statement;
    }

    /**
     * medoo:exec()
     *
     * @param  string $query
     * @param  array  $map
     * @return \PDOStatement
     */
    public function exec($query, $map = [])

This method seems to be duplicated in your project.

    {
        $statement = parent::exec($query, $map);

The expression parent::exec($query, $map); of type false|PDOStatement adds false to the return on line 151 which is incompatible with the return type documented by Kotori\Core\Database::exec of type PDOStatement. It seems like you forgot to handle an error condition.

        $lastSQL = parent::last();

It seems like you call parent on a different method (last() instead of exec()). Are you sure this is correct? If so, you might want to change this to $this->last().

        Container::get('logger')->info($lastSQL);
        array_push(self::$queries, $lastSQL);
        return $statement;
    }
}