Koded\Framework\Middleware\GzipMiddleware::process()

Complexity

Conditions	4
Paths	4

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	8.7414

Importance

Changes

0

<?php
    public function process(
        ServerRequestInterface $request,
        RequestHandlerInterface $handler): ResponseInterface
    {
        $response = $handler->handle($request);
        if ($response->hasHeader(self::CONTENT_ENCODING)) {
            return $response;
        }
        if (!$response->getBody()->getSize()) {

The expression $response->getBody()->getSize() of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            return $response;
        }
        if (false === $this->isAcceptable($request->getHeaderLine(self::ACCEPT_ENCODING))) {
            return $response;
        }
        $response->getBody()->rewind();
        return $response
            ->withHeader(self::CONTENT_ENCODING, 'gzip')
            ->withAddedHeader('Vary', self::ACCEPT_ENCODING)
            ->withBody(create_stream(
                gzencode($response->getBody()->getContents(), 7),
                $response->getBody()->getMetadata('mode')

It seems like $response->getBody()->getMetadata('mode') can also be of type array and null; however, parameter $mode of Koded\Http\create_stream() does only seem to accept string, maybe add an additional type check?

            ));