Koded\Framework\Middleware\GzipMiddleware

Complexity

Total Complexity

8

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Test Coverage

Coverage

20.83%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isAcceptable()	0	12	4
A	process()	0	21	4

<?php

namespace Koded\Framework\Middleware;

use Psr\Http\Message\{ResponseInterface, ServerRequestInterface};
use Psr\Http\Server\{MiddlewareInterface, RequestHandlerInterface};
use function gzencode;
use function Koded\Http\create_stream;
use function str_contains;

class GzipMiddleware implements MiddlewareInterface
{
    private const ACCEPT_ENCODING = 'Accept-Encoding';
    private const CONTENT_ENCODING = 'Content-Encoding';

    public function process(
        ServerRequestInterface $request,
        RequestHandlerInterface $handler): ResponseInterface
    {
        $response = $handler->handle($request);
        if ($response->hasHeader(self::CONTENT_ENCODING)) {
            return $response;
        }
        if (!$response->getBody()->getSize()) {

The expression $response->getBody()->getSize() of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            return $response;
        }
        if (false === $this->isAcceptable($request->getHeaderLine(self::ACCEPT_ENCODING))) {
            return $response;
        }
        $response->getBody()->rewind();
        return $response
            ->withHeader(self::CONTENT_ENCODING, 'gzip')
            ->withAddedHeader('Vary', self::ACCEPT_ENCODING)
            ->withBody(create_stream(
                gzencode($response->getBody()->getContents(), 7),
                $response->getBody()->getMetadata('mode')

It seems like $response->getBody()->getMetadata('mode') can also be of type array and null; however, parameter $mode of Koded\Http\create_stream() does only seem to accept string, maybe add an additional type check?

            ));
    }

    private function isAcceptable(string $encoding): bool
    {
        if (empty($encoding)) {
            return false;
        }
        if (str_contains($encoding, 'gzip')) {
            return true;
        }
        if (str_contains($encoding, '*')) {
            return true;
        }
        return false;
    }
}