Completed
Push — sf/last-boss ( 98c677 )
by Kiyotaka
23s
created
src/Eccube/Controller/Admin/AdminController.php 1 patch
Doc Comments   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -389,7 +389,6 @@  discard block
 block discarded – undo
389 389
     }
390 390
 
391 391
     /**
392
-     * @param \Doctrine\ORM\EntityManagerInterface $em
393 392
      * @param array $excludes
394 393
      *
395 394
      * @return null|Request
@@ -422,9 +421,9 @@  discard block
 block discarded – undo
422 421
     }
423 422
 
424 423
     /**
425
-     * @param $dateTime
424
+     * @param \DateTime $dateTime
426 425
      *
427
-     * @return array|mixed
426
+     * @return null|Request
428 427
      *
429 428
      * @throws \Doctrine\ORM\NonUniqueResultException
430 429
      */
@@ -460,9 +459,9 @@  discard block
 block discarded – undo
460 459
     }
461 460
 
462 461
     /**
463
-     * @param $dateTime
462
+     * @param \DateTime $dateTime
464 463
      *
465
-     * @return array|mixed
464
+     * @return null|Request
466 465
      *
467 466
      * @throws \Doctrine\ORM\NonUniqueResultException
468 467
      */
@@ -500,7 +499,7 @@  discard block
 block discarded – undo
500 499
     /**
501 500
      * 在庫切れ商品数を取得
502 501
      *
503
-     * @return mixed
502
+     * @return null|Request
504 503
      *
505 504
      * @throws \Doctrine\ORM\NonUniqueResultException
506 505
      */
@@ -518,7 +517,7 @@  discard block
 block discarded – undo
518 517
     /**
519 518
      * 商品数を取得
520 519
      *
521
-     * @return mixed
520
+     * @return null|Request
522 521
      *
523 522
      * @throws \Doctrine\ORM\NonUniqueResultException
524 523
      */
@@ -535,7 +534,7 @@  discard block
 block discarded – undo
535 534
     /**
536 535
      * 本会員数を取得
537 536
      *
538
-     * @return mixed
537
+     * @return null|Request
539 538
      *
540 539
      * @throws \Doctrine\ORM\NonUniqueResultException
541 540
      */
@@ -554,7 +553,7 @@  discard block
 block discarded – undo
554 553
      *
555 554
      * @param Carbon $fromDate
556 555
      * @param Carbon $toDate
557
-     * @param $format
556
+     * @param string $format
558 557
      *
559 558
      * @return array
560 559
      */
Please login to merge, or discard this patch.
src/Eccube/Controller/CartController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -126,7 +126,7 @@
 block discarded – undo
126 126
     }
127 127
 
128 128
     /**
129
-     * @param $Carts
129
+     * @param \Eccube\Entity\Cart[] $Carts
130 130
      *
131 131
      * @return \Symfony\Component\HttpFoundation\RedirectResponse
132 132
      */
Please login to merge, or discard this patch.
codeception/_support/Page/Admin/ProductManagePage.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@  discard block
 block discarded – undo
59 59
         return $this;
60 60
     }
61 61
 
62
+    /**
63
+     * @param integer $value
64
+     */
62 65
     public function 詳細検索_ステータス($value)
63 66
     {
64 67
         $this->tester->click(self::$詳細検索ボタン);
@@ -155,6 +158,9 @@  discard block
 block discarded – undo
155 158
         return $this;
156 159
     }
157 160
 
161
+    /**
162
+     * @param integer $rowNum
163
+     */
158 164
     public function Accept_複製する($rowNum)
159 165
     {
160 166
         $modalCssSelector = "#page_admin_product > div.c-container > div.c-contentsArea > div.c-contentsArea__cols > div > div > form > div.card.rounded.border-0.mb-4 > div.card-body.p-0 > table > tbody > tr:nth-child(${rowNum}) > td.align-middle.pr-3 > div > div:nth-child(2) div.modal";
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Order/MailController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
      * @param MailService $mailService
57 57
      * @param MailHistoryRepository $mailHistoryRepository
58 58
      * @param OrderRepository $orderRepository
59
-     * @param twig $twig
59
+     * @param Environment $twig
60 60
      */
61 61
     public function __construct(
62 62
         MailService $mailService,
Please login to merge, or discard this patch.
codeception/acceptance/_bootstrap.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -46,9 +46,9 @@  discard block
 block discarded – undo
46 46
 $faker = Faker::create('ja_JP');
47 47
 Fixtures::add('faker', $faker);
48 48
 
49
-$progress = (function() {
49
+$progress = (function () {
50 50
     $current = '';
51
-    return function($key) use (&$current) {
51
+    return function ($key) use (&$current) {
52 52
         if ($current !== $key) {
53 53
             if ($current !== '') {
54 54
                 echo PHP_EOL;
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 /* カテゴリ一覧の配列. */
204 204
 Fixtures::add('categories', $categories);
205 205
 
206
-$findOrders = function() use ($entityManager) {
206
+$findOrders = function () use ($entityManager) {
207 207
     return $entityManager->getRepository('Eccube\Entity\Order')
208 208
         ->createQueryBuilder('o')
209 209
         ->getQuery()
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 /* 受注を検索するクロージャ. */
213 213
 Fixtures::add('findOrders', $findOrders);
214 214
 
215
-$findShippings = function() use ($entityManager) {
215
+$findShippings = function () use ($entityManager) {
216 216
     return $entityManager->getRepository('Eccube\Entity\Shipping')
217 217
         ->createQueryBuilder('o')
218 218
         ->getQuery()
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 /* 出荷を検索するクロージャ. */
222 222
 Fixtures::add('findShippings', $findShippings);
223 223
 
224
-$resetShippingDate = function() use ($entityManager) {
224
+$resetShippingDate = function () use ($entityManager) {
225 225
     $Shippings = $entityManager->getRepository('Eccube\Entity\Shipping')
226 226
         ->findAll();
227 227
     foreach ($Shippings as $Shipping) {
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
 /* 出荷準備中に更新するクロージャ. */
235 235
 Fixtures::add('resetShippingDate', $resetShippingDate);
236 236
 
237
-$setShippingDate = function() use ($entityManager) {
237
+$setShippingDate = function () use ($entityManager) {
238 238
     $Shippings = $entityManager->getRepository('Eccube\Entity\Shipping')
239 239
         ->findAll();
240 240
     foreach ($Shippings as $Shipping) {
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 /* 出荷済みに更新するクロージャ. */
248 248
 Fixtures::add('setShippingDate', $setShippingDate);
249 249
 
250
-$deleteShippingNotExistsOfItem = function() use ($entityManager) {
250
+$deleteShippingNotExistsOfItem = function () use ($entityManager) {
251 251
 
252 252
     $Shippings = $entityManager->getRepository('Eccube\Entity\Shipping')->findAll();
253 253
 
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 /* OrderItemの存在しない出荷を削除するクロージャ. */
266 266
 Fixtures::add('deleteShippingNotExistsOfItem', $deleteShippingNotExistsOfItem);
267 267
 
268
-$findProducts = function() use ($entityManager) {
268
+$findProducts = function () use ($entityManager) {
269 269
     return $entityManager->getRepository('Eccube\Entity\Product')
270 270
         ->createQueryBuilder('p')
271 271
         ->getQuery()
@@ -274,12 +274,12 @@  discard block
 block discarded – undo
274 274
 /* 商品を検索するクロージャ. */
275 275
 Fixtures::add('findProducts', $findProducts);
276 276
 
277
-$createProduct = function($product_name = null, $product_class_num = 3) use ($container) {
277
+$createProduct = function ($product_name = null, $product_class_num = 3) use ($container) {
278 278
     return createProduct($container, $product_name, $product_class_num);
279 279
 };
280 280
 Fixtures::add('createProduct', $createProduct);
281 281
 
282
-$createCustomer = function($email = null, $active = true) use ($container, $faker) {
282
+$createCustomer = function ($email = null, $active = true) use ($container, $faker) {
283 283
     if (is_null($email)) {
284 284
         $email = microtime(true).'.'.$faker->safeEmail;
285 285
     }
@@ -319,19 +319,19 @@  discard block
 block discarded – undo
319 319
 /* 受注を生成するクロージャ. */
320 320
 Fixtures::add('createOrders', $createOrders);
321 321
 
322
-$findPlugins = function() use ($entityManager) {
322
+$findPlugins = function () use ($entityManager) {
323 323
     return $entityManager->getRepository('Eccube\Entity\Plugin')->findAll();
324 324
 };
325 325
 /* プラグインを検索するクロージャ */
326 326
 Fixtures::add('findPlugins', $findPlugins);
327 327
 
328
-$findPluginByCode = function($code = null) use ($entityManager) {
328
+$findPluginByCode = function ($code = null) use ($entityManager) {
329 329
     return $entityManager->getRepository('Eccube\Entity\Plugin')->findOneBy(['code' => $code]);
330 330
 };
331 331
 /* プラグインを検索するクロージャ */
332 332
 Fixtures::add('findPluginByCode', $findPluginByCode);
333 333
 
334
-$findCustomers = function() use ($entityManager) {
334
+$findCustomers = function () use ($entityManager) {
335 335
     return $entityManager->getRepository('Eccube\Entity\Customer')
336 336
         ->createQueryBuilder('c')
337 337
         ->getQuery()
@@ -341,13 +341,13 @@  discard block
 block discarded – undo
341 341
 Fixtures::add('findCustomers', $findCustomers);
342 342
 
343 343
 /** 新着情報を検索するクロージャ */
344
-Fixtures::add('findNews', function() use ($entityManager) {
344
+Fixtures::add('findNews', function () use ($entityManager) {
345 345
     return $entityManager->getRepository(\Eccube\Entity\News::class)
346 346
         ->findBy([], ['sort_no' => 'DESC']);
347 347
 });
348 348
 
349 349
 /** 新着情報を登録するクロージャ */
350
-Fixtures::add('createNews', function($publishDate, $title, $description, $url = null) use ($entityManager) {
350
+Fixtures::add('createNews', function ($publishDate, $title, $description, $url = null) use ($entityManager) {
351 351
     $TopNews = $entityManager->getRepository(\Eccube\Entity\News::class)
352 352
         ->findOneBy([], ['sort_no' => 'DESC']);
353 353
     $sortNo = $TopNews ? $TopNews->getSortNo() + 1 : 1;
Please login to merge, or discard this patch.
src/Eccube/Entity/Order.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1639,7 +1639,7 @@
 block discarded – undo
1639 1639
         /**
1640 1640
          * Set orderStatus.
1641 1641
          *
1642
-         * @param \Eccube\Entity\Master\OrderStatus|null|object $orderStatus
1642
+         * @param null|Master\OrderStatus $orderStatus
1643 1643
          *
1644 1644
          * @return Order
1645 1645
          */
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Store/PluginController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -270,14 +270,14 @@
 block discarded – undo
270 270
             // ストアからインストールしたプラグインは依存プラグインが有効化されているかを確認
271 271
             if ($Plugin->getSource()) {
272 272
                 $requires = $this->pluginService->getPluginRequired($Plugin);
273
-                $requires = array_filter($requires, function($req) {
273
+                $requires = array_filter($requires, function ($req) {
274 274
                     $code = preg_replace('/^ec-cube\//', '', $req['name']);
275 275
                     /** @var Plugin $DependPlugin */
276 276
                     $DependPlugin = $this->pluginRepository->findOneBy(['code' => $code]);
277 277
                     return $DependPlugin->isEnabled() == false;
278 278
                 });
279 279
                 if (!empty($requires)) {
280
-                    $names = array_map(function($req) {
280
+                    $names = array_map(function ($req) {
281 281
                         return "「${req['description']}」";
282 282
                     }, $requires);
283 283
                     $message = trans('%depend_name%を先に有効化してください。', ['%name%' => $Plugin->getName(), '%depend_name%' => implode(', ', $names)]);
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
         // 依存プラグインが有効になっていない場合はエラー
209 209
         $requires = $this->getPluginRequired($config);
210
-        $notInstalledOrDisabled = array_filter($requires, function($req) {
210
+        $notInstalledOrDisabled = array_filter($requires, function ($req) {
211 211
             $code = preg_replace('/^ec-cube\//', '', $req['name']);
212 212
             /** @var Plugin $DependPlugin */
213 213
             $DependPlugin = $this->pluginRepository->findOneBy(['code' => $code]);
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
         });
216 216
 
217 217
         if (!empty($notInstalledOrDisabled)) {
218
-            $names = array_map(function($p) { return $p['name']; }, $notInstalledOrDisabled);
218
+            $names = array_map(function ($p) { return $p['name']; }, $notInstalledOrDisabled);
219 219
             throw new PluginException(implode(', ', $names)."を有効化してください。");
220 220
         }
221 221
 
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
     {
275 275
         if ($plugin->isEnabled()) {
276 276
             $generatedFiles = $this->regenerateProxy($plugin, false);
277
-            $this->schemaService->updateSchema($generatedFiles, $this->projectRoot . '/app/proxy/entity');
277
+            $this->schemaService->updateSchema($generatedFiles, $this->projectRoot.'/app/proxy/entity');
278 278
         } else {
279 279
             // Proxyのクラスをロードせずにスキーマを更新するために、
280 280
             // インストール時には一時的なディレクトリにProxyを生成する
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
 
727 727
         $results = [];
728 728
 
729
-        $this->composerService->foreachRequires('ec-cube/'.$pluginCode, $pluginVersion, function($package) use(&$results) {
729
+        $this->composerService->foreachRequires('ec-cube/'.$pluginCode, $pluginVersion, function ($package) use(&$results) {
730 730
             $results[] = $package;
731 731
         }, 'eccube-plugin');
732 732
 
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/ComposerApiService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -251,7 +251,7 @@
 block discarded – undo
251 251
 
252 252
         if ($useBufferedOutput) {
253 253
             $output = new BufferedOutput();
254
-            ob_start(function($buffer) use ($output) {
254
+            ob_start(function ($buffer) use ($output) {
255 255
                 $output->write($buffer);
256 256
                 return null;
257 257
             });
Please login to merge, or discard this patch.