kitodo / kitodo-publication

Classes/Services/ProcessNumber/ProcessNumberGenerator.php

Braces +1 added lines, -2 removed lines

@@ -20,8 +20,7 @@
 use EWW\Dpf\Domain\Model\ProcessNumber;
 use EWW\Dpf\Domain\Repository\ClientRepository;
 
-class ProcessNumberGenerator
-{
+class ProcessNumberGenerator {
     public function getProcessNumber($ownerId = NULL) {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $processNumberRepository = $objectManager->get(ProcessNumberRepository::class);

Classes/Services/Transfer/ElasticsearchRepository.php

Braces +8 added lines, -16 removed lines

@@ -23,8 +23,7 @@ 
 use TYPO3\CMS\Extbase\Object\ObjectManager;
 use EWW\Dpf\Configuration\ClientConfigurationManager;
 
-class ElasticsearchRepository implements Repository
-{
+class ElasticsearchRepository implements Repository {
 
     /**
      * clientRepository
@@ -42,8 +41,7 @@ 
 
     protected $url;
 
-    public function __construct()
-    {
+    public function __construct() {
 
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
@@ -62,8 +60,7 @@ 
      * saves new document into elasticsearch local
      * @param \EWW\Dpf\Domain\Model\Document $document
      */
-    public function add($document, $json)
-    {
+    public function add($document, $json) {
 
         $client = $this->clientRepository->findAll()->current();
 
@@ -94,8 +91,7 @@ 
      * @param \EWW\Dpf\Domain\Model\Document $document
      * @param string $state
      */
-    public function delete($document, $state)
-    {
+    public function delete($document, $state) {
 
         try {
             $response = Request::delete($this->url . $document->getUid())
@@ -107,23 +103,19 @@ 
 
     }
 
-    public function retrieve($id)
-    {
+    public function retrieve($id) {
         # not implemented yet
     }
 
-    public function ingest($document, $metsXML)
-    {
+    public function ingest($document, $metsXML) {
         # not implemented yet
     }
 
-    public function update($document, $metsXml)
-    {
+    public function update($document, $metsXml) {
         # not implemented yet
     }
 
-    public function getNextDocumentId()
-    {
+    public function getNextDocumentId() {
         # not implemented yet
     }
 

Classes/Services/Transfer/DocumentTransferManager.php

Braces +7 added lines, -14 removed lines

@@ -18,8 +18,7 @@ 
 use EWW\Dpf\Services\Transfer\ElasticsearchRepository;
 use EWW\Dpf\Domain\Model\File;
 
-class DocumentTransferManager
-{
+class DocumentTransferManager {
 
     /**
      * documenRepository
@@ -73,8 +72,7 @@ 
      *
      * @param \EWW\Dpf\Services\Transfer\Repository $remoteRepository
      */
-    public function setRemoteRepository($remoteRepository)
-    {
+    public function setRemoteRepository($remoteRepository) {
 
         $this->remoteRepository = $remoteRepository;
 
@@ -86,8 +84,7 @@ 
      * @param \EWW\Dpf\Domain\Model\Document $document
      * @return boolean
      */
-    public function ingest($document)
-    {
+    public function ingest($document) {
 
         $document->setTransferStatus(Document::TRANSFER_QUEUED);
         $this->documentRepository->update($document);
@@ -143,8 +140,7 @@ 
      * @param \EWW\Dpf\Domain\Model\Document $document
      * @return boolean
      */
-    public function update($document)
-    {
+    public function update($document) {
 
         $document->setTransferStatus(Document::TRANSFER_QUEUED);
         $this->documentRepository->update($document);
@@ -196,8 +192,7 @@ 
      * @param string $remoteId
      * @return boolean
      */
-    public function retrieve($remoteId)
-    {
+    public function retrieve($remoteId) {
 
         $metsXml = $this->remoteRepository->retrieve($remoteId);
 
@@ -291,8 +286,7 @@ 
      * @param string $state
      * @return boolean
      */
-    public function delete($document, $state)
-    {
+    public function delete($document, $state) {
 
         $document->setTransferStatus(Document::TRANSFER_QUEUED);
         $this->documentRepository->update($document);
@@ -327,8 +321,7 @@ 
         }
     }
 
-    public function getNextDocumentId()
-    {
+    public function getNextDocumentId() {
         $nextDocumentIdXML = $this->remoteRepository->getNextDocumentId();
 
         if (empty($nextDocumentIdXML)) {

Upper-Lower-Casing +11 added lines, -11 removed lines

@@ -128,11 +128,11 @@ 
             $elasticsearchRepository = $this->objectManager->get(ElasticsearchRepository::class);
             $elasticsearchRepository->delete($document, "");
 
-            return true;
+            return TRUE;
         } else {
             $document->setTransferStatus(Document::TRANSFER_ERROR);
             $this->documentRepository->update($document);
-            return false;
+            return FALSE;
         }
 
     }
@@ -181,11 +181,11 @@ 
             $elasticsearchRepository = $this->objectManager->get(ElasticsearchRepository::class);
             $elasticsearchRepository->delete($document, "");
 
-            return true;
+            return TRUE;
         } else {
             $document->setTransferStatus(Document::TRANSFER_ERROR);
             $this->documentRepository->update($document);
-            return false;
+            return FALSE;
         }
 
     }
@@ -217,7 +217,7 @@ 
             $documentType     = $this->documentTypeRepository->findOneByName($documentTypeName);
 
             if (empty($title) || empty($documentType)) {
-                return false;
+                return FALSE;
             }
 
             $state = $mets->getState();
@@ -267,7 +267,7 @@ 
                 $file->setArchive($attachment['archive']);
 
                 if ($attachment['id'] == \EWW\Dpf\Domain\Model\File::PRIMARY_DATASTREAM_IDENTIFIER) {
-                    $file->setPrimaryFile(true);
+                    $file->setPrimaryFile(TRUE);
                 }
 
                 $file->setDocument($document);
@@ -275,13 +275,13 @@ 
                 $this->fileRepository->add($file);
             }
 
-            return true;
+            return TRUE;
 
         } else {
-            return false;
+            return FALSE;
         }
 
-        return false;
+        return FALSE;
     }
 
     /**
@@ -319,11 +319,11 @@ 
                     break;
             }
 
-            return true;
+            return TRUE;
         } else {
             $document->setTransferStatus(Document::TRANSFER_ERROR);
             $this->documentRepository->update($document);
-            return false;
+            return FALSE;
         }
     }
 

Classes/Services/Logger/TransferLogger.php

Braces +2 added lines, -4 removed lines

@@ -18,8 +18,7 @@ 
 use EWW\Dpf\Domain\Repository\DocumentTransferLogRepository;
 use EWW\Dpf\Domain\Model\DocumentTransferLog;
 
-class TransferLogger
-{
+class TransferLogger {
 
     /**
      * Logs the response of a document repository transfer
@@ -27,8 +26,7 @@ 
      * @param
      * @return void
      */
-    public static function log($action, $documentUid, $objectIdentifier, $response)
-    {
+    public static function log($action, $documentUid, $objectIdentifier, $response) {
 
         $objectManager                 = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $documentTransferLogRepository = $objectManager->get(DocumentTransferLogRepository::class);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         $documentTransferLogRepository = $objectManager->get(DocumentTransferLogRepository::class);
 
         $documentTransferLog = $objectManager->get(DocumentTransferLog::class);
-        $documentTransferLog->setResponse(print_r($response, true));
+        $documentTransferLog->setResponse(print_r($response, TRUE));
         $documentTransferLog->setAction($action);
         $documentTransferLog->setDocumentUid($documentUid);
         $documentTransferLog->setObjectIdentifier($objectIdentifier);

Classes/Services/ElasticSearch.php

Braces +4 added lines, -8 removed lines

@@ -21,8 +21,7 @@ 
 /**
  * ElasticSearch
  */
-class ElasticSearch
-{
+class ElasticSearch {
     protected $es;
 
     protected $server = ''; //127.0.0.1';
@@ -40,8 +39,7 @@ 
     /**
      * elasticsearch client constructor
      */
-    public function __construct()
-    {
+    public function __construct() {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
 
@@ -69,8 +67,7 @@ 
      * @param  array $query search query
      * @return array        result list
      */
-    public function search($query, $type)
-    {
+    public function search($query, $type) {
         // define type and index
         if (empty($query['index'])) {
             $query['index'] = $this->index;
@@ -94,8 +91,7 @@ 
      * returns the result list
      * @return [type] [description]
      */
-    public function getResults()
-    {
+    public function getResults() {
         // return results from the last search request
         return $this->resultList;
     }

Classes/Controller/AbstractSearchController.php

Braces +8 added lines, -16 removed lines

@@ -17,8 +17,7 @@ 
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use EWW\Dpf\Services\ElasticSearch;
 
-abstract class AbstractSearchController extends \EWW\Dpf\Controller\AbstractController
-{
+abstract class AbstractSearchController extends \EWW\Dpf\Controller\AbstractController {
     // search terms
     private static $terms   = ['_id', 'OWNER_ID', 'submitter', 'project'];
 
@@ -30,8 +29,7 @@ 
      * @param  array $query elasticsearch search query
      * @return array        results
      */
-    public function getResultList($query, $type)
-    {
+    public function getResultList($query, $type) {
 
         $elasticSearch = $this->objectManager->get(ElasticSearch::class);
         $results = $elasticSearch->search($query, $type);
@@ -44,8 +42,7 @@ 
      * @param  string $searchString
      * @return array query
      */
-    public function searchFulltext($searchString)
-    {
+    public function searchFulltext($searchString) {
         // don't return query if searchString is empty
         if (empty($searchString)) {
             return null;
@@ -68,8 +65,7 @@ 
      * build array for elasticsearch
      * @return array Elasticsearch query array
      */
-    public function extendedSearch($searchArray = array())
-    {
+    public function extendedSearch($searchArray = array()) {
 
         $query  = array();
         $filter = array();
@@ -116,8 +112,7 @@ 
      * @param array Elasticsearch query array
      * @return array Elasticsearch queryFilter array
      */
-    public function resultsFilter($query, $showDeleted = false)
-    {
+    public function resultsFilter($query, $showDeleted = false) {
 
         $queryFilter = array();
 
@@ -201,8 +196,7 @@ 
      * @param  bool      $intervalEnd Fills missing values with the maximum possible date if true
      * @return DateTime               Determined date
      */
-    public function convertFormDate($dateString, $intervalEnd = false)
-    {
+    public function convertFormDate($dateString, $intervalEnd = false) {
         try {
             if (strlen($dateString) == 4) {
                 // assuming year
@@ -223,8 +217,7 @@ 
      * @param $string
      * @return mixed
      */
-    private function escapeQuery($string)
-    {
+    private function escapeQuery($string) {
         $luceneReservedCharacters = preg_quote('+-&|!(){}[]^"~?:\\');
         $string                   = preg_replace_callback(
             '/([' . $luceneReservedCharacters . '])/',
@@ -242,8 +235,7 @@ 
      * @param $date
      * @return string
      */
-    public function formatDate($date)
-    {
+    public function formatDate($date) {
         // convert date from dd.mm.yyy to yyyy-dd-mm
         $date = explode(".", $date);
         return $date[2] . '-' . $date[1] . '-' . $date[0];

Classes/Controller/AbstractDocumentFormController.php

Braces +14 added lines, -28 removed lines

@@ -24,8 +24,7 @@ 
 /**
  * DocumentFormController
  */
-abstract class AbstractDocumentFormController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionController
-{
+abstract class AbstractDocumentFormController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionController {
 
     /**
      * documentRepository
@@ -80,8 +79,7 @@ 
      *
      * @return void
      */
-    public function listAction()
-    {
+    public function listAction() {
 
         $documents = $this->documentRepository->findAll();
 
@@ -130,8 +128,7 @@ 
      * @param \EWW\Dpf\Domain\Model\Document $document
      * @return void
      */
-    public function showAction(\EWW\Dpf\Domain\Model\Document $document)
-    {
+    public function showAction(\EWW\Dpf\Domain\Model\Document $document) {
 
         $this->view->assign('document', $document);
     }
@@ -141,8 +138,7 @@ 
      *
      * @return void
      */
-    public function initializeNewAction()
-    {
+    public function initializeNewAction() {
 
         $requestArguments = $this->request->getArguments();
 
@@ -170,13 +166,11 @@ 
      * @ignorevalidation $newDocumentForm
      * @return void
      */
-    public function newAction(\EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm = null)
-    {
+    public function newAction(\EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm = null) {
         $this->view->assign('documentForm', $newDocumentForm);
     }
 
-    public function initializeCreateAction()
-    {
+    public function initializeCreateAction() {
 
         $requestArguments = $this->request->getArguments();
 
@@ -210,8 +204,7 @@ 
      * @param \EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm
      * @return void
      */
-    public function createAction(\EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm)
-    {
+    public function createAction(\EWW\Dpf\Domain\Model\DocumentForm $newDocumentForm) {
 
         $documentMapper = $this->objectManager->get(DocumentMapper::class);
         $newDocument    = $documentMapper->getDocument($newDocumentForm);
@@ -259,8 +252,7 @@ 
         $this->redirectToList('CREATE_OK');
     }
 
-    public function initializeEditAction()
-    {
+    public function initializeEditAction() {
 
         $requestArguments = $this->request->getArguments();
 
@@ -284,13 +276,11 @@ 
      * @ignorevalidation $documentForm
      * @return void
      */
-    public function editAction(\EWW\Dpf\Domain\Model\DocumentForm $documentForm)
-    {
+    public function editAction(\EWW\Dpf\Domain\Model\DocumentForm $documentForm) {
         $this->view->assign('documentForm', $documentForm);
     }
 
-    public function initializeUpdateAction()
-    {
+    public function initializeUpdateAction() {
         $requestArguments = $this->request->getArguments();
 
         if ($this->request->hasArgument('documentData')) {
@@ -323,8 +313,7 @@ 
      * @param \EWW\Dpf\Domain\Model\DocumentForm $documentForm
      * @return void
      */
-    public function updateAction(\EWW\Dpf\Domain\Model\DocumentForm $documentForm)
-    {
+    public function updateAction(\EWW\Dpf\Domain\Model\DocumentForm $documentForm) {
 
         $requestArguments = $this->request->getArguments();
 
@@ -374,18 +363,15 @@ 
      *
      * @return void
      */
-    public function cancelAction()
-    {
+    public function cancelAction() {
         $this->redirectToList();
     }
 
-    public function initializeAction()
-    {
+    public function initializeAction() {
         parent::initializeAction();
     }
 
-    protected function redirectToList($message = null)
-    {
+    protected function redirectToList($message = null) {
         $this->redirect('list');
     }
 

Classes/Controller/ClientController.php

Spacing +4 added lines, -4 removed lines

@@ -57,7 +57,7 @@ 
     protected $persistenceManager;
 
     // TypoScript settings
-    protected $settings = array();
+    protected $settings = array ();
 
     // Id of the selected page in the page tree
     protected $selectedPageUid;
@@ -218,10 +218,10 @@ 
 
         if ($inputOptionTranslator->hasTranslation($inputOptionTranslator->getDefaultLanguage())) {
             $valueLabelList = $inputOptionTranslator->translate($iso6392b->getValues());
-            $displayName    = $inputOptionTranslator->translate(array('languageList'));
+            $displayName    = $inputOptionTranslator->translate(array ('languageList'));
         } else {
             $valueLabelList = $inputOptionTranslator->translate($iso6392b->getValues(), 'en');
-            $displayName    = $inputOptionTranslator->translate(array('languageList'), 'en');
+            $displayName    = $inputOptionTranslator->translate(array ('languageList'), 'en');
         }
         $languageOptionList->setDisplayName(implode('', $displayName));
         $languageOptionList->setValueLabelList(implode('|', $valueLabelList));
@@ -238,7 +238,7 @@ 
                     if ($inputOptionTranslator->hasTranslation($langIsoCode)) {
                         // only when a translation exists, a translation dataset is created
                         $valueLabelList = $inputOptionTranslator->translate($iso6392b->getValues(), $langIsoCode);
-                        $displayName    = $inputOptionTranslator->translate(array('languageList'), $langIsoCode);
+                        $displayName    = $inputOptionTranslator->translate(array ('languageList'), $langIsoCode);
 
                         $translatedOptionList = $this->objectManager->get(InputOptionList::class);
                         $translatedOptionList->setDisplayName(implode('', $displayName));

Braces +9 added lines, -18 removed lines

@@ -21,8 +21,7 @@ 
 /**
  * ClientController
  */
-class ClientController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionController
-{
+class ClientController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionController {
 
     /**
      * sysLanguageRepository
@@ -65,8 +64,7 @@ 
     // Page information of selected page
     protected $pageInfo;
 
-    protected function initializeAction()
-    {
+    protected function initializeAction() {
 
         $this->selectedPageUid = (int) \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('id');
 
@@ -80,13 +78,11 @@ 
         );
     }
 
-    protected function getPageInfo($pageUid)
-    {
+    protected function getPageInfo($pageUid) {
         return \TYPO3\CMS\Backend\Utility\BackendUtility::readPageAccess($pageUid, $GLOBALS['BE_USER']->getPagePermsClause(1));
     }
 
-    protected function initializeView(\TYPO3\CMS\Extbase\Mvc\View\ViewInterface $view)
-    {
+    protected function initializeView(\TYPO3\CMS\Extbase\Mvc\View\ViewInterface $view) {
         parent::initializeView($view);
 
     }
@@ -96,8 +92,7 @@ 
      *
      * @param \EWW\Dpf\Domain\Model\Client $newClient
      */
-    public function newAction(\EWW\Dpf\Domain\Model\Client $newClient = null)
-    {
+    public function newAction(\EWW\Dpf\Domain\Model\Client $newClient = null) {
         if ($this->isValidClientFolder()) {
 
             $this->addFlashMessage(
@@ -118,8 +113,7 @@ 
      *
      * @param \EWW\Dpf\Domain\Model\Client $newClient
      */
-    public function createAction(\EWW\Dpf\Domain\Model\Client $newClient)
-    {
+    public function createAction(\EWW\Dpf\Domain\Model\Client $newClient) {
 
         if ($this->isValidClientFolder()) {
             $newClient->setPid($this->selectedPageUid);
@@ -143,13 +137,11 @@ 
      * default action
      *
      */
-    public function defaultAction()
-    {
+    public function defaultAction() {
 
     }
 
-    protected function isValidClientFolder()
-    {
+    protected function isValidClientFolder() {
 
         if (!$this->selectedPageUid) {
             $this->addFlashMessage(
@@ -199,8 +191,7 @@ 
      *
      * @param integer $storagePid
      */
-    protected function addBaseInputOptionLists($storagePid)
-    {
+    protected function addBaseInputOptionLists($storagePid) {
 
         $iso6392b = $this->objectManager->get(Iso6392b::class);
 

Classes/Controller/AjaxDocumentFormController.php

Braces +7 added lines, -14 removed lines

@@ -21,8 +21,7 @@ 
 /**
  * DocumentFormController
  */
-class AjaxDocumentFormController extends \EWW\Dpf\Controller\AbstractController
-{
+class AjaxDocumentFormController extends \EWW\Dpf\Controller\AbstractController {
 
     /**
      * metadataGroupRepository
@@ -47,8 +46,7 @@ 
      * @param integer $groupIndex
      * @return void
      */
-    public function groupAction($pageUid, $groupUid, $groupIndex)
-    {
+    public function groupAction($pageUid, $groupUid, $groupIndex) {
 
         $group = $this->metadataGroupRepository->findByUid($groupUid);
 
@@ -91,8 +89,7 @@ 
      * @param integer $fieldIndex
      * @return void
      */
-    public function fieldAction($pageUid, $groupUid, $groupIndex, $fieldUid, $fieldIndex)
-    {
+    public function fieldAction($pageUid, $groupUid, $groupIndex, $fieldUid, $fieldIndex) {
 
         $field = $this->metadataObjectRepository->findByUid($fieldUid);
 
@@ -123,8 +120,7 @@ 
      *
      * @return void
      */
-    public function primaryUploadAction($groupIndex)
-    {
+    public function primaryUploadAction($groupIndex) {
     }
 
     /**
@@ -132,8 +128,7 @@ 
      * @param integer $groupIndex
      * @return void
      */
-    public function secondaryUploadAction($groupIndex)
-    {
+    public function secondaryUploadAction($groupIndex) {
         $this->view->assign('groupIndex', $groupIndex);
         //$this->view->assign('displayName','Sekundärdatei');
     }
@@ -144,8 +139,7 @@ 
      * @param integer $isPrimary
      * @return void
      */
-    public function deleteFileAction($fileUid, $isPrimary = 0)
-    {
+    public function deleteFileAction($fileUid, $isPrimary = 0) {
         $this->view->assign('fileUid', $fileUid);
         $this->view->assign('isPrimary', $isPrimary);
     }
@@ -155,8 +149,7 @@ 
      * @param string $qucosaId
      * @return string
      */
-    public function fillOutAction($qucosaId)
-    {
+    public function fillOutAction($qucosaId) {
 
         $urnService = $this->objectManager->get(Urn::class);