kitodo / kitodo-publication

Classes/Services/XPathXMLGenerator.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -38,7 +38,7 @@ 
         $i = 0;
         $predicateStack = 0;
         $tokenStack = 0;
-        $insidePredicate = false;
+        $insidePredicate = FALSE;
         $predicateString = "";
         $loopStack = array();
 
@@ -47,7 +47,7 @@ 
 
             if ($firstChar === '[' || $insidePredicate) {
                 // get corresponding bracket
-                $insidePredicate = true;
+                $insidePredicate = TRUE;
 
                 $predicateString .= $value;
 
@@ -56,7 +56,7 @@ 
 
                     if ($predicateStack === 0) {
                         // corresponding bracket found
-                        $insidePredicate = false;
+                        $insidePredicate = FALSE;
 
                         if (!empty($predicateString)) {
                             // recursive call with predicate string

Spacing +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
         $tokenStack = 0;
         $insidePredicate = false;
         $predicateString = "";
-        $loopStack = array();
+        $loopStack = array ();
 
         foreach ($matches[0] as $key => $value) {
             $firstChar = substr($value, 0, 1);
@@ -88,7 +88,7 @@ 
                 $this->endAttribute();
                 array_pop($loopStack);
                 $predicateStack--;
-            } else if ($firstChar !== '=' && $firstChar !== '[' && $firstChar !== '@' && $firstChar !== '/' && $firstChar!== '.') {
+            } else if ($firstChar !== '=' && $firstChar !== '[' && $firstChar !== '@' && $firstChar !== '/' && $firstChar !== '.') {
                 $this->startToken($value);
                 $loopStack[] = 'token';
                 if ($predicateStack > 0) {
@@ -106,7 +106,7 @@ 
                 $this->endToken();
             }
         }
-        $this->stack = array();
+        $this->stack = array ();
 
     }
 

Braces +10 added lines, -20 removed lines

@@ -19,14 +19,12 @@ 
  * Generates XML elements for a given xpath
  * Notice: Not all sytax from the original xpath is implemented
  */
-class XPathXMLGenerator
-{
+class XPathXMLGenerator {
     protected $regex = '/[a-zA-Z:]+|[<=>]|[@][a-zA-Z][a-zA-Z0-9_\-\:\.]*|\[|\'.*?\'|".*?"|\]|\//';
 
     private $xmlWriter;
 
-    public function __construct()
-    {
+    public function __construct() {
         $this->xmlWriter = new \XMLWriter();
         $this->xmlWriter->openMemory();
     }
@@ -39,8 +37,7 @@ 
         return str_replace("%%nl%%", "\n", $string);
     }
 
-    function generateXmlFromXPath($xpath)
-    {
+    function generateXmlFromXPath($xpath) {
         // split xpath to find predicates, attributes and texts
         preg_match_all($this->regex, $this->replaceLineBreaks($xpath), $matches);
         $i = 0;
@@ -115,16 +112,14 @@ 
      * Starts an XML element
      * <$value>
      */
-    function startToken($value)
-    {
+    function startToken($value) {
         $this->xmlWriter->startElement($value);
     }
 
     /**
      * Ends the last token
      */
-    function endToken()
-    {
+    function endToken() {
         $this->xmlWriter->endElement();
     }
 
@@ -133,8 +128,7 @@ 
      * Adds content to an XML element or attribute
      * <mods:mods>$value</mods:mods>
      */
-    function setText($value)
-    {
+    function setText($value) {
         $this->xmlWriter->text($value);
     }
 
@@ -144,8 +138,7 @@ 
      * It adds an attribute with name and value to an XML element
      * <mods:mods $name=$value>
      */
-    function addAttribute($name, $value)
-    {
+    function addAttribute($name, $value) {
         $this->xmlWriter->writeAttribute($name, $value);
     }
 
@@ -153,16 +146,14 @@ 
      * @param $name
      * Starts an attribute
      */
-    function startAttribute($name)
-    {
+    function startAttribute($name) {
         $this->xmlWriter->startAttribute($name);
     }
 
     /**
      * Ends the last started attribute
      */
-    function endAttribute()
-    {
+    function endAttribute() {
         $this->xmlWriter->endAttribute();
     }
 
@@ -170,8 +161,7 @@ 
      * @return string
      * Returns the created XML
      */
-    function getXML()
-    {
+    function getXML() {
         return $this->xmlWriter->outputMemory();
     }
 }

Tests/Unit/Services/XPathXMLGeneratorTest.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
     /**
      * @var XPathXMLGenerator
      */
-    private $xpathGenerator = null;
+    private $xpathGenerator = NULL;
 
     protected function setUp() {
         $this->xpathGenerator = new \EWW\Dpf\Services\XPathXMLGenerator();

Braces +5 added lines, -10 removed lines

@@ -17,8 +17,7 @@ 
 use Nimut\TestingFramework\TestCase\UnitTestCase;
 include_once 'Classes/Services/XPathXMLGenerator.php';
 
-class XPathXMLGeneratorTest extends UnitTestCase
-{
+class XPathXMLGeneratorTest extends UnitTestCase {
 
     /**
      * @var XPathXMLGenerator
@@ -32,8 +31,7 @@ 
     /**
      * @test
      */
-    public function testXMLGeneration1()
-    {
+    public function testXMLGeneration1() {
         $xpath = 'mods:name[mods:role/mods:roleTerm[@type="code"][@authority="marcrelator"]="edt"]/mods:displayForm';
         $expectedXml = '<mods:name><mods:role><mods:roleTerm type="code" authority="marcrelator">edt</mods:roleTerm></mods:role><mods:displayForm/></mods:name>';
 
@@ -48,8 +46,7 @@ 
     /**
      * @test
      */
-    public function testXMLGeneration2()
-    {
+    public function testXMLGeneration2() {
         $xpath = 'mods:language/mods:languageTerm[@authority="iso639-2b"][@type="code"]="ger"';
         $expectedXml = '<mods:language><mods:languageTerm authority="iso639-2b" type="code">ger</mods:languageTerm></mods:language>';
 
@@ -64,8 +61,7 @@ 
     /**
      * @test
      */
-    public function testXMLGeneration3()
-    {
+    public function testXMLGeneration3() {
         $xpath = 'mods:originInfo[@eventType="publication"]';
         $expectedXml = '<mods:originInfo eventType="publication"/>';
 
@@ -80,8 +76,7 @@ 
     /**
      * @test
      */
-    public function testXMLGeneration4()
-    {
+    public function testXMLGeneration4() {
         $xpath = "mods:originInfo[@eventType='publication']=\"A\nB\nC\n\"";
         $expectedXml = "<mods:originInfo eventType=\"publication\">A\nB\nC\n</mods:originInfo>";
 

Classes/Services/MetsExporter.php

Braces +24 added lines, -48 removed lines

@@ -17,8 +17,7 @@ 
 /**
  * MetsExporter
  */
-class MetsExporter
-{
+class MetsExporter {
     /**
      * formData
      *
@@ -96,8 +95,7 @@ 
     /**
      * Constructor
      */
-    public function __construct()
-    {
+    public function __construct() {
         // mets data beginning
         $this->metsHeader = '<mets:mets xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                             xmlns:mets="http://www.loc.gov/METS/" xmlns:xlink="http://www.w3.org/1999/xlink"
@@ -138,8 +136,7 @@ 
      * returns the mets xml string
      * @return string mets xml
      */
-    public function getMetsData()
-    {
+    public function getMetsData() {
         $xml = $this->metsData->saveXML();
 
         $xml = preg_replace("/eww=\"\d-\d-\d\"/", '${1}${2}${3}', $xml);
@@ -152,8 +149,7 @@ 
      * returns the mods xml string
      * @return string mods xml
      */
-    public function getModsData()
-    {
+    public function getModsData() {
         return $this->modsData->saveXML();
     }
 
@@ -161,8 +157,7 @@ 
      * Build mets data structure
      * @return string mets xml
      */
-    public function buildMets()
-    {
+    public function buildMets() {
         // get mods domDocument
         $modsWrap = $this->buildModsWrap();
         // get mets filesection
@@ -203,8 +198,7 @@ 
      * @param  xml $xml xml data which should be wrapped with mods
      * @return xml wrapped xml
      */
-    public function wrapMods($xml)
-    {
+    public function wrapMods($xml) {
         $newXML = $this->modsHeader;
 
         $newXML = str_replace("</mods:mods>", $xml . "</mods:mods>", $newXML);
@@ -212,8 +206,7 @@ 
         return $newXML;
     }
 
-    public function wrapSlub($xml)
-    {
+    public function wrapSlub($xml) {
         $newXML = $this->slubHeader;
 
         $newXML = str_replace("</slub:info>", $xml . "</slub:info>", $newXML);
@@ -225,8 +218,7 @@ 
      * build mods from form array
      * @param array $array structured form data array
      */
-    public function buildModsFromForm($array)
-    {
+    public function buildModsFromForm($array) {
         $this->xmlData = $this->modsData;
         // Build xml mods from form fields
         // loop each group
@@ -308,8 +300,7 @@ 
      * @param  xpath $xPath xPath expression
      * @return xml
      */
-    public function parseXPath($xPath)
-    {
+    public function parseXPath($xPath) {
 
         $this->parser->generateXmlFromXPath($xPath);
         $xml = $this->parser->getXML();
@@ -323,8 +314,7 @@ 
      * @param  string $value form value
      * @return xml    created xml
      */
-    public function customXPath($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false)
-    {
+    public function customXPath($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false) {
         if (!$attributeOnly) {
             // Explode xPath
             $newPath = explode('%', $xPath);
@@ -495,8 +485,7 @@ 
         return $this->xmlData->saveXML();
     }
 
-    public function customXPathSlub($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false)
-    {
+    public function customXPathSlub($xPath, $newGroupFlag = false, $value = '', $attributeOnly = false) {
         if (!$attributeOnly) {
             // Explode xPath
             $newPath = explode('%', $xPath);
@@ -610,8 +599,7 @@ 
      * Builds the xml wrapping part for mods
      * @return xml
      */
-    public function buildModsWrap()
-    {
+    public function buildModsWrap() {
         // Build wrap for mod
 
         $domDocument = new \DOMDocument();
@@ -649,8 +637,7 @@ 
      * Builds xml amdSection
      * @return xml
      */
-    public function buildAmdSection()
-    {
+    public function buildAmdSection() {
         // Build xml amd:sec
 
         $domDocument = new \DOMDocument();
@@ -661,8 +648,7 @@ 
         $amdSec = $domDocument->createElement('mets:amdSec');
     }
 
-    public function setMods($value = '')
-    {
+    public function setMods($value = '') {
         $domDocument = new \DOMDocument();
         if (is_null(@$domDocument->loadXML($value))) {
             throw new \Exception("Couldn't load MODS data");
@@ -670,13 +656,11 @@ 
         $this->modsData = $domDocument;
     }
 
-    public function setFileData($value = '')
-    {
+    public function setFileData($value = '') {
         $this->files = $value;
     }
 
-    public function loopFiles($array, $domElement, $domDocument)
-    {
+    public function loopFiles($array, $domElement, $domDocument) {
         $i = 0;
         // set xml for uploded files
         foreach ($array as $key => $value) {
@@ -721,8 +705,7 @@ 
      * Builds the xml fileSection part if files are uploaded
      * @return xml
      */
-    public function buildFileSection()
-    {
+    public function buildFileSection() {
         if (empty($this->files['original']) && empty($this->files['download'])) {
             return;
         }
@@ -769,8 +752,7 @@ 
      * Builds the xml structMap part if files are uploaded
      * @return xml
      */
-    public function buildStructureMap()
-    {
+    public function buildStructureMap() {
         // Build xml Mets:structMap
 
         $domDocument = new \DOMDocument();
@@ -809,8 +791,7 @@ 
         return $domDocument;
     }
 
-    public function setSlubInfo($value = '')
-    {
+    public function setSlubInfo($value = '') {
         // build DOMDocument with slub xml
         $domDocument = new \DOMDocument();
         $domDocument->loadXML($value);
@@ -822,8 +803,7 @@ 
      * @param  Array $array Array with slub information
      * @return xml        xml slubInfo
      */
-    public function buildMetsSlub()
-    {
+    public function buildMetsSlub() {
         $domDocument = new \DOMDocument();
         $domDocument->loadXML('<mets:amdSec ID="AMD_000" xmlns:mets="http://www.loc.gov/METS/"></mets:amdSec>');
         $domWrapElement = $domDocument->firstChild;
@@ -864,8 +844,7 @@ 
      * returns the mods xml string
      * @return string mods xml
      */
-    public function getSlubData()
-    {
+    public function getSlubData() {
         return $this->slubData->saveXML();
     }
 
@@ -873,8 +852,7 @@ 
      *
      * @param string $slubInfoData
      */
-    public function buildSlubInfoFromForm($slubInfoData, $documentType, $processNumber)
-    {
+    public function buildSlubInfoFromForm($slubInfoData, $documentType, $processNumber) {
         $this->xmlData = $this->slubData;
         if (is_array($slubInfoData['metadata'])) {
             foreach ($slubInfoData['metadata'] as $key => $group) {
@@ -957,8 +935,7 @@ 
      *
      * @return string slub info xml
      */
-    public function getSlubInfoData()
-    {
+    public function getSlubInfoData() {
         return $this->slubData->saveXML();
     }
 
@@ -967,8 +944,7 @@ 
      * @param string $objId
      * @return void
      */
-    public function setObjId($objId)
-    {
+    public function setObjId($objId) {
         $this->objId = $objId;
     }
 }