Passed
Push — master ( 19f06a...8d1e35 )
by Ralf
24:17
created
ext_localconf.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -22,13 +22,13 @@  discard block
 block discarded – undo
22 22
     require_once $composerAutoloadFile;
23 23
 }
24 24
 
25
-$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['EWW\Dpf\Tasks\TransferTask'] = array(
25
+$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['EWW\Dpf\Tasks\TransferTask'] = array (
26 26
     'extension'   => $_EXTKEY,
27 27
     'title'       => 'Kitodo.Publication-Dokumente ans Repository übertragen.',
28 28
     'description' => '',
29 29
 );
30 30
 
31
-$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['EWW\Dpf\Tasks\EmbargoTask'] = array(
31
+$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks']['EWW\Dpf\Tasks\EmbargoTask'] = array (
32 32
     'extension' => $_EXTKEY,
33 33
     'title' => 'Kitodo.Publication Embargo Task',
34 34
     'description' => 'Embargo task for sending information to admins or publish files automatically if the embargo date is expired',
@@ -37,13 +37,13 @@  discard block
 block discarded – undo
37 37
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
38 38
     'EWW.' . $_EXTKEY,
39 39
     'KitodoPublicationForm',
40
-    array(
40
+    array (
41 41
         'DocumentForm'     => 'list,new,create,edit,update,delete,cancel',
42 42
         'AjaxDocumentForm' => 'group,fileGroup,field,deleteFile,primaryUpload,secondaryUpload,fillOut',
43 43
         'Gnd'              => 'search',
44 44
     ),
45 45
     // non-cacheable actions
46
-    array(
46
+    array (
47 47
         'DocumentForm'     => 'list,new,create,edit,update,delete,cancel,ajaxGroup,ajaxFileGroup,ajaxField',
48 48
         'AjaxDocumentForm' => 'group,fileGroup,field,deleteFile,primaryUpload,secondaryUpload,fillOut',
49 49
         'Gnd'              => 'search',
@@ -55,11 +55,11 @@  discard block
 block discarded – undo
55 55
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
56 56
     'EWW.' . $_EXTKEY,
57 57
     'Frontendsearch',
58
-    array(
58
+    array (
59 59
         'SearchFE' => 'search,extendedSearch,showSearchForm',
60 60
     ),
61 61
     // non-cacheable actions
62
-    array(
62
+    array (
63 63
         'SearchFE' => 'search,extendedSearch'
64 64
     )
65 65
 );
@@ -67,11 +67,11 @@  discard block
 block discarded – undo
67 67
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
68 68
     'EWW.' . $_EXTKEY,
69 69
     'Getfile',
70
-    array(
70
+    array (
71 71
         'GetFile'     => 'attachment',
72 72
     ),
73 73
     // non-cacheable actions
74
-    array(
74
+    array (
75 75
         'GetFile'     => 'attachment',
76 76
     )
77 77
 );
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin(
91 91
     'EWW.' . $_EXTKEY,
92 92
     'Backoffice',
93
-    array(
93
+    array (
94 94
         'Workspace'        => 'listWorkspace, initIndex, '
95 95
             .'batch, batchRegister, batchRemove, batchReleaseValidated, batchReleaseUnvalidated, editDocument, batchSetInProgress',
96 96
         'Document'         => 'logout, showDetails, discard, postpone, deleteLocally, deleteLocallySuggestion, register, releasePublish, '
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         'User'             => 'settings, saveSettings',
116 116
     ),
117 117
     // non-cacheable actions
118
-    array(
118
+    array (
119 119
         'Workspace'        => 'listWorkspace, initIndex, '
120 120
             .'batch, batchRegister, batchRemove, batchReleaseValidated, batchReleaseUnvalidated, editDocument, batchSetInProgress',
121 121
         'Document'         => 'logout, showDetails, discard, postpone, deleteLocally, deleteLocallySuggestion, register, releasePublish, '
Please login to merge, or discard this patch.
Classes/ViewHelpers/IsFisIdMissingViewHelper.php 2 patches
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,8 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
 use \EWW\Dpf\Security\Security;
18 18
 
19
-class IsFisIdMissingViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper
20
-{
19
+class IsFisIdMissingViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper {
21 20
     /**
22 21
      * security
23 22
      *
@@ -29,8 +28,7 @@  discard block
 block discarded – undo
29 28
     /**
30 29
      * @return string
31 30
      */
32
-    public function render()
33
-    {
31
+    public function render() {
34 32
         return  !(
35 33
             $this->security->getFisPersId() ||
36 34
             $this->security->getUserRole() != Security::ROLE_RESEARCHER
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
      * @var \EWW\Dpf\Security\Security
25 25
      * @TYPO3\CMS\Extbase\Annotation\Inject
26 26
      */
27
-    protected $security = null;
27
+    protected $security = NULL;
28 28
 
29 29
     /**
30 30
      * @return string
Please login to merge, or discard this patch.
Classes/ViewHelpers/GetTypo3ModeViewHelper.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,14 +14,12 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-class GetTypo3ModeViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper
18
-{
17
+class GetTypo3ModeViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper {
19 18
 
20 19
     /**
21 20
       * @return string
22 21
      */
23
-    public function render()
24
-    {
22
+    public function render() {
25 23
         return TYPO3_MODE;
26 24
     }
27 25
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/ShowDocumentTypeViewHelper.php 2 patches
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -14,8 +14,7 @@  discard block
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-class ShowDocumentTypeViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper
18
-{
17
+class ShowDocumentTypeViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper {
19 18
     /**
20 19
      * documentTypeRepository
21 20
      *
@@ -24,8 +23,7 @@  discard block
 block discarded – undo
24 23
      */
25 24
     protected $documentTypeRepository = null;
26 25
 
27
-    public function initializeArguments()
28
-    {
26
+    public function initializeArguments() {
29 27
         parent::initializeArguments();
30 28
 
31 29
         $this->registerArgument('docType', 'string', 'The document type name', true);
@@ -35,8 +33,7 @@  discard block
 block discarded – undo
35 33
      * Gets the localized display name of the given document type.
36 34
      * @return string
37 35
      */
38
-    public function render()
39
-    {
36
+    public function render() {
40 37
         $docType = $this->arguments['docType'];
41 38
 
42 39
         /** @var \EWW\Dpf\Domain\Model\DocumentType $documentType */
Please login to merge, or discard this patch.
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,13 +22,13 @@
 block discarded – undo
22 22
      * @var \EWW\Dpf\Domain\Repository\DocumentTypeRepository
23 23
      * @TYPO3\CMS\Extbase\Annotation\Inject
24 24
      */
25
-    protected $documentTypeRepository = null;
25
+    protected $documentTypeRepository = NULL;
26 26
 
27 27
     public function initializeArguments()
28 28
     {
29 29
         parent::initializeArguments();
30 30
 
31
-        $this->registerArgument('docType', 'string', 'The document type name', true);
31
+        $this->registerArgument('docType', 'string', 'The document type name', TRUE);
32 32
     }
33 33
 
34 34
     /**
Please login to merge, or discard this patch.
Classes/ViewHelpers/ShowDocumentCounterViewHelper.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
         $currentPage = $this->arguments['currentPage'];
42 42
         $itemsPerPage = $this->arguments['itemsPerPage'];
43 43
 
44
-        $from = ($currentPage > 1)? (($currentPage-1) * $itemsPerPage) + 1 : $currentPage;
44
+        $from = ($currentPage > 1) ? (($currentPage - 1) * $itemsPerPage) + 1 : $currentPage;
45 45
 
46 46
         if ($currentPage >= 1) {
47 47
             if ($currentPage * $itemsPerPage > $documentCount) {
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -14,11 +14,9 @@  discard block
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-class ShowDocumentCounterViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper
18
-{
17
+class ShowDocumentCounterViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper {
19 18
 
20
-    public function initializeArguments()
21
-    {
19
+    public function initializeArguments() {
22 20
         parent::initializeArguments();
23 21
 
24 22
         $this->registerArgument('documentCount', 'int',
@@ -35,8 +33,7 @@  discard block
 block discarded – undo
35 33
     /**
36 34
      * @return string|null
37 35
      */
38
-    public function render()
39
-    {
36
+    public function render() {
40 37
         $documentCount = $this->arguments['documentCount'];
41 38
         $currentPage = $this->arguments['currentPage'];
42 39
         $itemsPerPage = $this->arguments['itemsPerPage'];
Please login to merge, or discard this patch.
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -22,13 +22,13 @@
 block discarded – undo
22 22
         parent::initializeArguments();
23 23
 
24 24
         $this->registerArgument('documentCount', 'int',
25
-            'The number of documents.', true
25
+            'The number of documents.', TRUE
26 26
         );
27 27
         $this->registerArgument('currentPage', 'int',
28
-            'The current page uid.', true
28
+            'The current page uid.', TRUE
29 29
         );
30 30
         $this->registerArgument('itemsPerPage', 'int',
31
-            'The number of items per page.', true
31
+            'The number of items per page.', TRUE
32 32
         );
33 33
     }
34 34
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/IsUrnViewHelper.php 2 patches
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -14,10 +14,8 @@  discard block
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-class IsUrnViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper
18
-{
19
-    public function initializeArguments()
20
-    {
17
+class IsUrnViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper {
18
+    public function initializeArguments() {
21 19
         parent::initializeArguments();
22 20
 
23 21
         $this->registerArgument('value', 'string', '', true);
@@ -26,8 +24,7 @@  discard block
 block discarded – undo
26 24
     /**
27 25
      * @return string
28 26
      */
29
-    public function render()
30
-    {
27
+    public function render() {
31 28
         $value = $this->arguments['value'];
32 29
 
33 30
         if (strpos(strtolower($value), 'urn') === 0) {
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
     {
21 21
         parent::initializeArguments();
22 22
 
23
-        $this->registerArgument('value', 'string', '', true);
23
+        $this->registerArgument('value', 'string', '', TRUE);
24 24
     }
25 25
 
26 26
     /**
Please login to merge, or discard this patch.
Classes/ViewHelpers/IsAccessGrantedViewHelper.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
             list($class, $uid) = explode(":", $subject);
69 69
         }
70 70
 
71
-        $repositoryClass = str_replace("Model", "Repository", $class)."Repository";
71
+        $repositoryClass = str_replace("Model", "Repository", $class) . "Repository";
72 72
 
73 73
         $repository = $objectManager->get($repositoryClass);
74 74
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -19,10 +19,8 @@  discard block
 block discarded – undo
19 19
 use TYPO3\CMS\Extbase\Object\ObjectManager;
20 20
 use EWW\Dpf\Security\AuthorizationChecker;
21 21
 
22
-class IsAccessGrantedViewHelper extends AbstractViewHelper
23
-{
24
-    public function initializeArguments()
25
-    {
22
+class IsAccessGrantedViewHelper extends AbstractViewHelper {
23
+    public function initializeArguments() {
26 24
         parent::initializeArguments();
27 25
 
28 26
         $this->registerArgument('attribute', 'string', '', true);
@@ -40,8 +38,7 @@  discard block
 block discarded – undo
40 38
      *
41 39
      * @return bool
42 40
      */
43
-    public function render()
44
-    {
41
+    public function render() {
45 42
         $attribute = $this->arguments['attribute'];
46 43
         $subject = $this->arguments['subject'];
47 44
         $class = $this->arguments['class'];
Please login to merge, or discard this patch.
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@
 block discarded – undo
25 25
     {
26 26
         parent::initializeArguments();
27 27
 
28
-        $this->registerArgument('attribute', 'string', '', true);
29
-        $this->registerArgument('subject', 'mixed', 'A model object or a UID.', true);
28
+        $this->registerArgument('attribute', 'string', '', TRUE);
29
+        $this->registerArgument('subject', 'mixed', 'A model object or a UID.', TRUE);
30 30
         $this->registerArgument(
31 31
             'class',
32 32
             'string',
33 33
             'Model class name, in case of parameter 2 is a UID.',
34
-            false, "EWW\\Dpf\\Domain\\Model\\Document"
34
+            FALSE, "EWW\\Dpf\\Domain\\Model\\Document"
35 35
         );
36 36
     }
37 37
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/Security/KitodoRoleViewHelper.php 2 patches
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,8 +14,7 @@  discard block
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-class KitodoRoleViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper
18
-{
17
+class KitodoRoleViewHelper extends \TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper {
19 18
     /**
20 19
      * security
21 20
      *
@@ -29,8 +28,7 @@  discard block
 block discarded – undo
29 28
      *
30 29
      * @return string
31 30
      */
32
-    public function render()
33
-    {
31
+    public function render() {
34 32
         return $this->security->getUserRole();
35 33
     }
36 34
 }
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
      * @var \EWW\Dpf\Security\Security
23 23
      * @TYPO3\CMS\Extbase\Annotation\Inject
24 24
      */
25
-    protected $security = null;
25
+    protected $security = NULL;
26 26
 
27 27
     /**
28 28
      * Shows the frontend user name of the given frontenduser user id.
Please login to merge, or discard this patch.
Classes/ViewHelpers/IsDocumentBookmarkableViewHelper.php 2 patches
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,10 +21,8 @@  discard block
 block discarded – undo
21 21
 use \EWW\Dpf\Security\Security;
22 22
 use \EWW\Dpf\Domain\Repository\BookmarkRepository;
23 23
 
24
-class IsDocumentBookmarkableViewHelper extends AbstractViewHelper
25
-{
26
-    public function initializeArguments()
27
-    {
24
+class IsDocumentBookmarkableViewHelper extends AbstractViewHelper {
25
+    public function initializeArguments() {
28 26
         parent::initializeArguments();
29 27
 
30 28
         $this->registerArgument('identifier', 'string', '', true);
@@ -35,8 +33,7 @@  discard block
 block discarded – undo
35 33
     /**
36 34
      * @return bool
37 35
      */
38
-    public function render()
39
-    {
36
+    public function render() {
40 37
         $identifier = $this->arguments['identifier'];
41 38
         $creator = $this->arguments['creator'];
42 39
         $state = $this->arguments['state'];
Please login to merge, or discard this patch.
Upper-Lower-Casing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -27,9 +27,9 @@  discard block
 block discarded – undo
27 27
     {
28 28
         parent::initializeArguments();
29 29
 
30
-        $this->registerArgument('identifier', 'string', '', true);
31
-        $this->registerArgument('creator', 'int', '', true);
32
-        $this->registerArgument('state', 'string', '', true);
30
+        $this->registerArgument('identifier', 'string', '', TRUE);
31
+        $this->registerArgument('creator', 'int', '', TRUE);
32
+        $this->registerArgument('state', 'string', '', TRUE);
33 33
     }
34 34
 
35 35
     /**
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         $bookmarkRepository = $objectManager->get(BookmarkRepository::class);
50 50
 
51 51
         if ($bookmarkRepository->findBookmark($security->getUser()->getUid(), $identifier)) {
52
-            return false;
52
+            return FALSE;
53 53
         }
54 54
 
55 55
         if ($security->getUser()->getUserRole() === Security::ROLE_LIBRARIAN) {
@@ -64,6 +64,6 @@  discard block
 block discarded – undo
64 64
             );
65 65
         }
66 66
 
67
-        return false;
67
+        return FALSE;
68 68
     }
69 69
 }
Please login to merge, or discard this patch.