kitodo / kitodo-publication

Configuration/TCA/tx_dpf_domain_model_storedsearch.php

Spacing +34 added lines, -34 removed lines

@@ -16,8 +16,8 @@ 
     die('Access denied.');
 }
 
-return array(
-    'ctrl' => array(
+return array (
+    'ctrl' => array (
         'title'                    => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_storedsearch',
         'label'                    => 'name',
         'tstamp'                   => 'tstamp',
@@ -28,7 +28,7 @@ 
         'transOrigPointerField'    => 'l10n_parent',
         'transOrigDiffSourceField' => 'l10n_diffsource',
         'delete'                   => 'deleted',
-        'enablecolumns'            => array(
+        'enablecolumns'            => array (
             'disabled'  => 'hidden',
             'starttime' => 'starttime',
             'endtime'   => 'endtime',
@@ -36,97 +36,97 @@ 
         'searchFields'             => 'title',
         'iconfile'                 => 'EXT:dpf/Resources/Public/Icons/tx_dpf_domain_model_editinglock.gif',
     ),
-    'interface' => array(
+    'interface' => array (
         'showRecordFieldList' => 'name, query',
     ),
-    'types'     => array(
-        '1' => array('showitem' => ',--palette--;;1, 
+    'types'     => array (
+        '1' => array ('showitem' => ',--palette--;;1, 
         name, query,      
         --div--;LLL:EXT:cms/locallang_ttc.xlf:tabs.access'),
     ),
-    'palettes'  => array(
-        '1' => array('showitem' => ''),
+    'palettes'  => array (
+        '1' => array ('showitem' => ''),
     ),
-    'columns'   => array(
+    'columns'   => array (
 
-        'sys_language_uid'           => array(
+        'sys_language_uid'           => array (
             'exclude' => 1,
             'label'   => 'LLL:EXT:lang/locallang_general.xlf:LGL.language',
-            'config'  => array(
+            'config'  => array (
                 'type'                => 'select',
                 'renderType'          => 'selectSingle',
                 'foreign_table'       => 'sys_language',
                 'foreign_table_where' => 'ORDER BY sys_language.title',
-                'items'               => array(
-                    array('LLL:EXT:lang/locallang_general.xlf:LGL.allLanguages', -1),
-                    array('LLL:EXT:lang/locallang_general.xlf:LGL.default_value', 0),
+                'items'               => array (
+                    array ('LLL:EXT:lang/locallang_general.xlf:LGL.allLanguages', -1),
+                    array ('LLL:EXT:lang/locallang_general.xlf:LGL.default_value', 0),
                 ),
             ),
         ),
-        'l10n_parent'                => array(
+        'l10n_parent'                => array (
             'displayCond' => 'FIELD:sys_language_uid:>:0',
             'exclude'     => 1,
             'label'       => 'LLL:EXT:lang/locallang_general.xlf:LGL.l18n_parent',
-            'config'      => array(
+            'config'      => array (
                 'type'                => 'select',
                 'renderType'          => 'selectSingle',
-                'items'               => array(
-                    array('', 0),
+                'items'               => array (
+                    array ('', 0),
                 ),
                 'foreign_table'       => 'tx_dpf_domain_model_storedsearch',
                 'foreign_table_where' => 'AND tx_dpf_domain_model_storedsearch.pid=###CURRENT_PID### AND tx_dpf_domain_model_storedsearch.sys_language_uid IN (-1,0)',
             ),
         ),
-        'l10n_diffsource'            => array(
-            'config' => array(
+        'l10n_diffsource'            => array (
+            'config' => array (
                 'type' => 'passthrough',
             ),
         ),
 
-        't3ver_label'                => array(
+        't3ver_label'                => array (
             'label'  => 'LLL:EXT:lang/locallang_general.xlf:LGL.versionLabel',
-            'config' => array(
+            'config' => array (
                 'type' => 'input',
                 'size' => 30,
                 'max'  => 255,
             ),
         ),
 
-        'hidden'                     => array(
+        'hidden'                     => array (
             'exclude' => 1,
             'label'   => 'LLL:EXT:lang/locallang_general.xlf:LGL.hidden',
-            'config'  => array(
+            'config'  => array (
                 'type' => 'check',
             ),
         ),
-        'starttime'                  => array(
+        'starttime'                  => array (
             'exclude'   => 1,
             'l10n_mode' => 'mergeIfNotBlank',
             'label'     => 'LLL:EXT:lang/locallang_general.xlf:LGL.starttime',
-            'config'    => array(
+            'config'    => array (
                 'type'     => 'input',
                 'renderType' => 'inputDateTime',
                 'size'     => 13,
                 'eval'     => 'datetime',
                 'checkbox' => 0,
                 'default'  => 0,
-                'range'    => array(
+                'range'    => array (
                     'lower' => mktime(0, 0, 0, date('m'), date('d'), date('Y')),
                 ),
             ),
         ),
-        'endtime'                    => array(
+        'endtime'                    => array (
             'exclude'   => 1,
             'l10n_mode' => 'mergeIfNotBlank',
             'label'     => 'LLL:EXT:lang/locallang_general.xlf:LGL.endtime',
-            'config'    => array(
+            'config'    => array (
                 'type'     => 'input',
                 'renderType' => 'inputDateTime',
                 'size'     => 13,
                 'eval'     => 'datetime',
                 'checkbox' => 0,
                 'default'  => 0,
-                'range'    => array(
+                'range'    => array (
                     'lower' => mktime(0, 0, 0, date('m'), date('d'), date('Y')),
                 ),
             ),
@@ -138,20 +138,20 @@ 
             ],
         ],
 
-        'name'                      => array(
+        'name'                      => array (
             'exclude' => 1,
             'label'   => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_storedsearch.name',
-            'config'  => array(
+            'config'  => array (
                 'type' => 'input',
                 'size' => 30,
                 'eval' => 'trim',
             ),
         ),
 
-        'query'                      => array(
+        'query'                      => array (
             'exclude' => 1,
             'label'   => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_storedsearch.query',
-            'config'  => array(
+            'config'  => array (
                 'type' => 'text',
                 'cols' => 40,
                 'rows' => 15,

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
         'tstamp'                   => 'tstamp',
         'crdate'                   => 'crdate',
         'cruser_id'                => 'cruser_id',
-        'versioningWS'             => true,
+        'versioningWS'             => TRUE,
         'languageField'            => 'sys_language_uid',
         'transOrigPointerField'    => 'l10n_parent',
         'transOrigDiffSourceField' => 'l10n_diffsource',

Configuration/TCA/Overrides/fe_users.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     ],
 */
     'stored_searches' => [
-        'exclude' => true,
+        'exclude' => TRUE,
         'label' => 'stored_searches',
         'config' => [
             'type' => 'inline',

Classes/ViewHelpers/Security/KitodoRoleViewHelper.php

Braces +2 added lines, -4 removed lines

@@ -14,8 +14,7 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class KitodoRoleViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper
-{
+class KitodoRoleViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper {
     /**
      * security
      *
@@ -29,8 +28,7 @@ 
      *
      * @return string
      */
-    public function render()
-    {
+    public function render() {
         return $this->security->getUser()->getUserRole();
     }
 }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
      * @var \EWW\Dpf\Security\Security
      * @inject
      */
-    protected $security = null;
+    protected $security = NULL;
 
     /**
      * Shows the frontend user name of the given frontenduser user id.

Classes/Session/SearchSessionData.php

Braces +16 added lines, -32 removed lines

@@ -16,8 +16,7 @@ 
 
 use EWW\Dpf\Domain\Workflow\DocumentWorkflow;
 
-class SearchSessionData
-{
+class SearchSessionData {
     /**
      * @var array
      */
@@ -54,8 +53,7 @@ 
      *
      * @return array
      */
-    public function getExcludeFilters()
-    {
+    public function getExcludeFilters() {
         return $this->excludeFilters;
     }
 
@@ -64,8 +62,7 @@ 
      * Toggles the discarded documents filter.
      *
      */
-    public function toggleExcludeDiscardedFilter()
-    {
+    public function toggleExcludeDiscardedFilter() {
         if (array_key_exists('aliasState', $this->excludeFilters)) {
             unset($this->excludeFilters['aliasState']);
         } else {
@@ -78,8 +75,7 @@ 
      * Toggles the hide bookmarks filter.
      *
      */
-    public function toggleBookmarksOnlyFilter()
-    {
+    public function toggleBookmarksOnlyFilter() {
         if (array_key_exists('bookmarks', $this->excludeFilters)) {
             unset($this->excludeFilters['bookmarks']);
         } else {
@@ -93,8 +89,7 @@ 
      * @param $name
      * @param array $values
      */
-    public function setFilter($name, $values = [])
-    {
+    public function setFilter($name, $values = []) {
         if ($name && $values && is_array($values)) {
             $this->filters[$name] = $values;
         } elseif ($name) {
@@ -108,8 +103,7 @@ 
      *
      * @return array
      */
-    public function clearFilters()
-    {
+    public function clearFilters() {
         $this->filters = [];
     }
 
@@ -119,8 +113,7 @@ 
      *
      * @return array
      */
-    public function getFilters()
-    {
+    public function getFilters() {
         return $this->filters;
     }
 
@@ -129,8 +122,7 @@ 
      * Removes the sort information
      *
      */
-    public function clearSort()
-    {
+    public function clearSort() {
         $this->sortField = '';
         $this->sortOrder = '';
     }
@@ -140,8 +132,7 @@ 
      *
      * @return string
      */
-    public function getSortField()
-    {
+    public function getSortField() {
         return $this->sortField;
     }
 
@@ -150,8 +141,7 @@ 
      *
      * @param string $fieldName
      */
-    public function setSortField($fieldName)
-    {
+    public function setSortField($fieldName) {
         $this->sortField = $fieldName;
     }
 
@@ -160,8 +150,7 @@ 
      *
      * @return string
      */
-    public function getSortOrder()
-    {
+    public function getSortOrder() {
         return $this->sortOrder;
     }
 
@@ -170,8 +159,7 @@ 
      *
      * @param string $order
      */
-    public function setSortOrder($order)
-    {
+    public function setSortOrder($order) {
         $this->sortOrder = $order;
     }
 
@@ -180,8 +168,7 @@ 
      *
      * @return string
      */
-    public function getSimpleQuery()
-    {
+    public function getSimpleQuery() {
         return $this->simpleQuery;
     }
 
@@ -190,8 +177,7 @@ 
      *
      * @param string $query
      */
-    public function setSimpleQuery($query)
-    {
+    public function setSimpleQuery($query) {
         $this->simpleQuery = $query;
     }
 
@@ -200,8 +186,7 @@ 
      *
      * @return int
      */
-    public function getItemsPerPage()
-    {
+    public function getItemsPerPage() {
         return $this->itemsPerPage;
     }
 
@@ -210,8 +195,7 @@ 
      *
      * @param int $itemsPerPage
      */
-    public function setItemsPerPage($itemsPerPage)
-    {
+    public function setItemsPerPage($itemsPerPage) {
         $this->itemsPerPage = $itemsPerPage;
     }
 

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
     /**
      * @var string
      */
-    protected $simpleQuery = null;
+    protected $simpleQuery = NULL;
 
     /**
      * @var int
@@ -83,7 +83,7 @@ 
         if (array_key_exists('bookmarks', $this->excludeFilters)) {
             unset($this->excludeFilters['bookmarks']);
         } else {
-            $this->excludeFilters['bookmarks'] = true;
+            $this->excludeFilters['bookmarks'] = TRUE;
         }
     }
 

Classes/Helper/Mods.php

Braces +19 added lines, -38 removed lines

@@ -15,8 +15,7 @@ 
  */
 
 
-class Mods
-{
+class Mods {
     /**
      * metadataObjectRepository
      *
@@ -36,13 +35,11 @@ 
 
     protected $modsDom;
 
-    public function __construct($modsXml)
-    {
+    public function __construct($modsXml) {
         $this->setModsXml($modsXml);
     }
 
-    public function setModsXml($modsXml)
-    {
+    public function setModsXml($modsXml) {
         $modsDom = new \DOMDocument();
         if (!empty($modsXml)) {
             if (is_null(@$modsDom->loadXML($modsXml))) {
@@ -52,19 +49,16 @@ 
         $this->modsDom = $modsDom;
     }
 
-    public function getModsXml()
-    {
+    public function getModsXml() {
         return $this->modsDom->saveXML();
     }
 
-    public function getModsXpath()
-    {
+    public function getModsXpath() {
         $xpath = \EWW\Dpf\Helper\XPath::create($this->modsDom);
         return $xpath;
     }
 
-    public function getTitle()
-    {
+    public function getTitle() {
         $titleNode = $this->getModsXpath()->query('/mods:mods/mods:titleInfo[@usage="primary"]/mods:title');
 
         if ($titleNode->length == 0) {
@@ -73,13 +67,11 @@ 
         return $titleNode->item(0)->nodeValue;
     }
 
-    public function getAuthors()
-    {
+    public function getAuthors() {
         return $this->getPersons("aut");
     }
 
-    public function getPublishers()
-    {
+    public function getPublishers() {
         return $this->getPersons("edt");
     }
 
@@ -89,8 +81,7 @@ 
      * @param $role
      * @return array
      */
-    protected function getPersons($role)
-    {
+    protected function getPersons($role) {
         $xpath = $this->getModsXpath();
 
         $authorNode = $xpath->query('/mods:mods/mods:name[mods:role/mods:roleTerm[@type="code"]="'.$role.'"]');
@@ -119,8 +110,7 @@ 
         return $authors;
     }
 
-    public function setDateIssued($date)
-    {
+    public function setDateIssued($date) {
 
         $originInfo = $this->getModsXpath()->query('/mods:mods/mods:originInfo[@eventType="distribution"]');
 
@@ -160,8 +150,7 @@ 
     }
 
 
-    public function getPublishingYear()
-    {
+    public function getPublishingYear() {
         $year = $this->getModsXpath()->query('/mods:mods/mods:originInfo[@eventType="publication"]/mods:dateIssued[@encoding="iso8601"]');
         if ($year->length > 0) {
             return $year->item(0)->nodeValue;
@@ -170,8 +159,7 @@ 
         return null;
     }
 
-    public function getOriginalSourceTitle()
-    {
+    public function getOriginalSourceTitle() {
         $node= $this->getModsXpath()->query('/mods:mods/mods:relatedItem[@type="original"]/mods:titleInfo/mods:title');
         if ($node->length > 0) {
             return $node->item(0)->nodeValue;
@@ -180,8 +168,7 @@ 
         return null;
     }
 
-    public function getDateIssued()
-    {
+    public function getDateIssued() {
 
         $dateIssued = $this->getModsXpath()->query('/mods:mods/mods:originInfo[@eventType="distribution"]/mods:dateIssued[@encoding="iso8601"][@keyDate="yes"]');
         if ($dateIssued->length > 0) {
@@ -191,8 +178,7 @@ 
         return null;
     }
 
-    public function removeDateIssued()
-    {
+    public function removeDateIssued() {
 
         $dateIssued = $this->getModsXpath()->query('/mods:mods/mods:originInfo[@eventType="distribution"]/mods:dateIssued[@encoding="iso8601"][@keyDate="yes"]');
         if ($dateIssued->length > 0) {
@@ -201,8 +187,7 @@ 
 
     }
 
-    public function hasQucosaUrn()
-    {
+    public function hasQucosaUrn() {
         $urnNodeList = $this->getModsXpath()->query('/mods:mods/mods:identifier[@type="qucosa:urn"]');
 
         $hasUrn = false;
@@ -215,8 +200,7 @@ 
         return $hasUrn;
     }
 
-    public function getQucosaUrn()
-    {
+    public function getQucosaUrn() {
         $urnNodeList = $this->getModsXpath()->query('/mods:mods/mods:identifier[@type="qucosa:urn"]');
         $urnList     = '';
 
@@ -228,8 +212,7 @@ 
         return $urnList;
     }
 
-    public function addQucosaUrn($urn)
-    {
+    public function addQucosaUrn($urn) {
         $rootNode = $this->getModsXpath()->query('/mods:mods');
 
         if ($rootNode->length == 1) {
@@ -243,8 +226,7 @@ 
 
     }
 
-    public function clearAllUrn()
-    {
+    public function clearAllUrn() {
         $urnNodeList = $this->getModsXpath()->query('/mods:mods/mods:identifier[@type="urn"]');
 
         foreach ($urnNodeList as $urnNode) {
@@ -260,8 +242,7 @@ 
     /**
      * @return string
      */
-    public function getSourceDetails()
-    {
+    public function getSourceDetails() {
         $data = [];
 
         $dataNodes[] = $this->getModsXpath()->query('/mods:mods/mods:relatedItem[@type="original"]');

Upper-Lower-Casing +7 added lines, -7 removed lines

@@ -23,7 +23,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\MetadataObjectRepository
      * @inject
      */
-    protected $metadataObjectRepository = null;
+    protected $metadataObjectRepository = NULL;
 
     /**
      * metadatGroupRepository
@@ -31,7 +31,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\MetadataGroupRepository
      * @inject
      */
-    protected $metadataGroupRepository = null;
+    protected $metadataGroupRepository = NULL;
 
 
     protected $modsDom;
@@ -167,7 +167,7 @@ 
             return $year->item(0)->nodeValue;
         }
 
-        return null;
+        return NULL;
     }
 
     public function getOriginalSourceTitle()
@@ -177,7 +177,7 @@ 
             return $node->item(0)->nodeValue;
         }
 
-        return null;
+        return NULL;
     }
 
     public function getDateIssued()
@@ -188,7 +188,7 @@ 
             return $dateIssued->item(0)->nodeValue;
         }
 
-        return null;
+        return NULL;
     }
 
     public function removeDateIssued()
@@ -205,7 +205,7 @@ 
     {
         $urnNodeList = $this->getModsXpath()->query('/mods:mods/mods:identifier[@type="qucosa:urn"]');
 
-        $hasUrn = false;
+        $hasUrn = FALSE;
 
         foreach ($urnNodeList as $urnNode) {
             $value  = $urnNode->nodeValue;
@@ -220,7 +220,7 @@ 
         $urnNodeList = $this->getModsXpath()->query('/mods:mods/mods:identifier[@type="qucosa:urn"]');
         $urnList     = '';
 
-        if ($urnNodeList != null) {
+        if ($urnNodeList != NULL) {
             foreach ($urnNodeList as $urnNode) {
                 $urnList = $urnNode->nodeValue;
             }

Classes/Domain/Repository/StoredSearchRepository.php

Braces +1 added lines, -2 removed lines

@@ -1,6 +1,5 @@
 <?php
 namespace EWW\Dpf\Domain\Repository;
 
-class StoredSearchRepository extends \TYPO3\CMS\Extbase\Persistence\Repository
-{
+class StoredSearchRepository extends \TYPO3\CMS\Extbase\Persistence\Repository {
 }

Classes/Domain/Model/FrontendUser.php

Braces +7 added lines, -14 removed lines

@@ -19,8 +19,7 @@ 
 /**
 * Frontend user
 */
-class FrontendUser extends \TYPO3\CMS\Extbase\Domain\Model\FrontendUser
-{
+class FrontendUser extends \TYPO3\CMS\Extbase\Domain\Model\FrontendUser {
     /**
      * storedSearches
      *
@@ -40,8 +39,7 @@ 
     /**
      * __construct
      */
-    public function __construct()
-    {
+    public function __construct() {
         parent::__construct();
 
         //Do not remove the next line: It would break the functionality
@@ -53,8 +51,7 @@ 
      *
      * @return void
      */
-    protected function initStorageObjects()
-    {
+    protected function initStorageObjects() {
         $this->storedSearches = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage();
     }
 
@@ -64,8 +61,7 @@ 
      *
      * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\StoredSearch>
      */
-    public function getStoredSearches()
-    {
+    public function getStoredSearches() {
         return $this->storedSearches;
     }
 
@@ -75,16 +71,14 @@ 
      * @param  \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\StoredSearch> $storedSearches
      * @return void
      */
-    public function setStoredSearches(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $storedSearches)
-    {
+    public function setStoredSearches(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $storedSearches) {
         $this->storedSearches = $storedSearches;
     }
 
     /**
      * @param \EWW\Dpf\Domain\Model\StoredSearch $storedSearch
      */
-    public function addStoredSearch(\EWW\Dpf\Domain\Model\StoredSearch $storedSearch)
-    {
+    public function addStoredSearch(\EWW\Dpf\Domain\Model\StoredSearch $storedSearch) {
         $this->storedSearches->attach($storedSearch);
     }
 
@@ -93,8 +87,7 @@ 
      *
      * @return string
      */
-    public function getUserRole()
-    {
+    public function getUserRole() {
         // Get frontend user groups of the client.
         $clientFrontendGroups = array();
         foreach ($this->frontendUserGroupRepository->findAll() as $clientGroup) {

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
      * @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\StoredSearch>
      * @cascade remove
      */
-    protected $storedSearches = null;
+    protected $storedSearches = NULL;
 
     /**
      * frontendUserGroupRepository
@@ -35,7 +35,7 @@ 
      * @var \EWW\Dpf\Domain\Repository\FrontendUserGroupRepository
      * @inject
      */
-    protected $frontendUserGroupRepository = null;
+    protected $frontendUserGroupRepository = NULL;
 
     /**
      * __construct

Classes/Domain/Model/Document.php

Spacing +11 added lines, -11 removed lines

@@ -324,7 +324,7 @@ 
     public function setObjectIdentifier($objectIdentifier)
     {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
-        $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
+        $this->objectIdentifier = empty($objectIdentifier) ? null : $objectIdentifier;
     }
 
     /**
@@ -506,14 +506,14 @@ 
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
-        $files = array();
+        $files = array ();
 
         if (is_a($this->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {
             foreach ($this->getFile() as $file) {
 
                 if (!$file->isFileGroupDeleted()) {
 
-                    $tmpFile = array(
+                    $tmpFile = array (
                         'path' => $file->getLink(),
                         'type' => $file->getContentType(),
                         'title' => (($file->getLabel()) ? $file->getLabel() : $file->getTitle()),
@@ -557,12 +557,12 @@ 
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
-        $files = array();
+        $files = array ();
 
         if (is_a($this->getFile(), '\TYPO3\CMS\Extbase\Persistence\ObjectStorage')) {
             foreach ($this->getFile() as $file) {
 
-                $tmpFile = array(
+                $tmpFile = array (
                     'path' => $file->getLink(),
                     'type' => $file->getContentType(),
                     'title' => (($file->getLabel()) ? $file->getLabel() : $file->getTitle()),
@@ -715,7 +715,7 @@ 
      */
     public function getCreator()
     {
-        return $this->creator? $this->creator : 0;
+        return $this->creator ? $this->creator : 0;
     }
 
     /**
@@ -861,7 +861,7 @@ 
 
         foreach ($availableProperties as $propertyName) {
             if (\TYPO3\CMS\Extbase\Reflection\ObjectAccess::isPropertySettable($newDocument, $propertyName)
-                && !in_array($propertyName, array('uid','pid', 'file', 'comment', 'linkedUid', 'suggestion', 'creator'))) {
+                && !in_array($propertyName, array ('uid', 'pid', 'file', 'comment', 'linkedUid', 'suggestion', 'creator'))) {
 
                 $propertyValue = \TYPO3\CMS\Extbase\Reflection\ObjectAccess::getProperty($documentToCopy, $propertyName);
                 \TYPO3\CMS\Extbase\Reflection\ObjectAccess::setProperty($newDocument, $propertyName, $propertyValue);
@@ -883,7 +883,7 @@ 
      */
     public function getDocumentIdentifier()
     {
-        return $this->getObjectIdentifier()? $this->getObjectIdentifier() : $this->getUid();
+        return $this->getObjectIdentifier() ? $this->getObjectIdentifier() : $this->getUid();
     }
 
     /**
@@ -916,8 +916,8 @@ 
     public function getPublicationYear()
     {
         $mods = new Mods($this->getXmlData());
-        $year =  $mods->getPublishingYear();
-        return $year? $year : "";
+        $year = $mods->getPublishingYear();
+        return $year ? $year : "";
     }
 
     /**
@@ -929,7 +929,7 @@ 
     {
         $mods = new Mods($this->getXmlData());
         $title = $mods->getTitle();
-        return $title? $title : "";
+        return $title ? $title : "";
     }
 
 

Braces +61 added lines, -122 removed lines

@@ -20,8 +20,7 @@ 
 /**
  * Document
  */
-class Document extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
-{
+class Document extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
     /**
      * title
      *
@@ -183,8 +182,7 @@ 
     /**
      * __construct
      */
-    public function __construct()
-    {
+    public function __construct() {
         //Do not remove the next line: It would break the functionality
         $this->initStorageObjects();
     }
@@ -194,8 +192,7 @@ 
      *
      * @return void
      */
-    protected function initStorageObjects()
-    {
+    protected function initStorageObjects() {
         $this->file = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage();
     }
 
@@ -204,8 +201,7 @@ 
      *
      * @return string $title
      */
-    public function getTitle()
-    {
+    public function getTitle() {
         return $this->title;
     }
 
@@ -215,8 +211,7 @@ 
      * @param string $title
      * @return void
      */
-    public function setTitle($title)
-    {
+    public function setTitle($title) {
         $this->title = $title;
         //htmlspecialchars_decode($title,ENT_QUOTES);
     }
@@ -226,8 +221,7 @@ 
      *
      * @return array $authors
      */
-    public function getAuthors()
-    {
+    public function getAuthors() {
         return array_map('trim', explode(";", $this->authors));
     }
 
@@ -237,8 +231,7 @@ 
      * @param array $authors
      * @return void
      */
-    public function setAuthors($authors)
-    {
+    public function setAuthors($authors) {
         $authors = implode("; ", $authors);
         $this->authors = $authors;
     }
@@ -248,8 +241,7 @@ 
      *
      * @return string $xmlData
      */
-    public function getXmlData()
-    {
+    public function getXmlData() {
         return $this->xmlData;
     }
 
@@ -259,8 +251,7 @@ 
      * @param string $xmlData
      * @return void
      */
-    public function setXmlData($xmlData)
-    {
+    public function setXmlData($xmlData) {
         $this->xmlData = $xmlData;
     }
 
@@ -269,8 +260,7 @@ 
      *
      * @return string $slubInfoData
      */
-    public function getSlubInfoData()
-    {
+    public function getSlubInfoData() {
         return $this->slubInfoData;
     }
 
@@ -279,8 +269,7 @@ 
      *
      * @return string $slubInfoData
      */
-    public function setSlubInfoData($slubInfoData)
-    {
+    public function setSlubInfoData($slubInfoData) {
         $this->slubInfoData = $slubInfoData;
     }
 
@@ -289,8 +278,7 @@ 
      *
      * @return \EWW\Dpf\Domain\Model\DocumentType $documentType
      */
-    public function getDocumentType()
-    {
+    public function getDocumentType() {
         return $this->documentType;
     }
 
@@ -300,8 +288,7 @@ 
      * @param \EWW\Dpf\Domain\Model\DocumentType $documentType
      * @return void
      */
-    public function setDocumentType(\EWW\Dpf\Domain\Model\DocumentType $documentType)
-    {
+    public function setDocumentType(\EWW\Dpf\Domain\Model\DocumentType $documentType) {
         $this->documentType = $documentType;
     }
 
@@ -310,8 +297,7 @@ 
      *
      * @return string
      */
-    public function getObjectIdentifier()
-    {
+    public function getObjectIdentifier() {
         return $this->objectIdentifier;
     }
 
@@ -321,8 +307,7 @@ 
      * @param string $objectIdentifier
      * @return void
      */
-    public function setObjectIdentifier($objectIdentifier)
-    {
+    public function setObjectIdentifier($objectIdentifier) {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
         $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
     }
@@ -332,8 +317,7 @@ 
      *
      * @return string
      */
-    public function getReservedObjectIdentifier()
-    {
+    public function getReservedObjectIdentifier() {
         return $this->reservedObjectIdentifier;
     }
 
@@ -343,8 +327,7 @@ 
      * @param string $reservedObjectIdentifier
      * @return void
      */
-    public function setReservedObjectIdentifier($reservedObjectIdentifier)
-    {
+    public function setReservedObjectIdentifier($reservedObjectIdentifier) {
         $this->reservedObjectIdentifier = $reservedObjectIdentifier;
     }
 
@@ -353,8 +336,7 @@ 
      *
      * @return string
      */
-    public function getTransferStatus()
-    {
+    public function getTransferStatus() {
         return $this->transferStatus;
     }
 
@@ -364,8 +346,7 @@ 
      * @param string
      * @return void
      */
-    public function setTransferStatus($transferStatus)
-    {
+    public function setTransferStatus($transferStatus) {
         $this->transferStatus = $transferStatus;
     }
 
@@ -374,8 +355,7 @@ 
      *
      * @return integer
      */
-    public function getTransferDate()
-    {
+    public function getTransferDate() {
         return $this->transferDate;
     }
 
@@ -385,8 +365,7 @@ 
      * @param integer $transferDate
      * @return void
      */
-    public function setTransferDate($transferDate)
-    {
+    public function setTransferDate($transferDate) {
         $this->transferDate = $transferDate;
     }
 
@@ -395,8 +374,7 @@ 
      *
      * @var integer
      */
-    public function getTransferErrorCode()
-    {
+    public function getTransferErrorCode() {
         return $this->transferErrorCode;
     }
 
@@ -406,8 +384,7 @@ 
      * @param integer $transferErrorCode
      * @return void
      */
-    public function setTransferErrorCode($transferErrorCode)
-    {
+    public function setTransferErrorCode($transferErrorCode) {
         $this->transferErrorCode = $transferErrorCode;
     }
 
@@ -416,8 +393,7 @@ 
      *
      * @var string
      */
-    public function getTransferResponse()
-    {
+    public function getTransferResponse() {
         return $this->transferResponse;
     }
 
@@ -427,8 +403,7 @@ 
      * @param string $transferResponse
      * @return void
      */
-    public function setTransferResponse($transferResponse)
-    {
+    public function setTransferResponse($transferResponse) {
         $this->transferResponse = $transferResponse;
     }
 
@@ -437,8 +412,7 @@ 
      *
      * @var integer
      */
-    public function getTransferHttpStatus()
-    {
+    public function getTransferHttpStatus() {
         return $this->transferHttpStatus;
     }
 
@@ -448,8 +422,7 @@ 
      * @param integer $transferHttpStatus
      * @return void
      */
-    public function setTransferHttpStatus($transferHttpStatus)
-    {
+    public function setTransferHttpStatus($transferHttpStatus) {
         $this->transferHttpStatus = $transferHttpStatus;
     }
 
@@ -459,8 +432,7 @@ 
      * @param \EWW\Dpf\Domain\Model\File $file
      * @return void
      */
-    public function addFile(\EWW\Dpf\Domain\Model\File $file)
-    {
+    public function addFile(\EWW\Dpf\Domain\Model\File $file) {
         $this->file->attach($file);
     }
 
@@ -470,8 +442,7 @@ 
      * @param \EWW\Dpf\Domain\Model\File $fileToRemove The File to be removed
      * @return void
      */
-    public function removeFile(\EWW\Dpf\Domain\Model\File $fileToRemove)
-    {
+    public function removeFile(\EWW\Dpf\Domain\Model\File $fileToRemove) {
         $this->file->detach($fileToRemove);
     }
 
@@ -480,8 +451,7 @@ 
      *
      * @return \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File> $file
      */
-    public function getFile()
-    {
+    public function getFile() {
         return $this->file;
     }
 
@@ -491,8 +461,7 @@ 
      * @param \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File> $file
      * @return void
      */
-    public function setFile(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $file)
-    {
+    public function setFile(\TYPO3\CMS\Extbase\Persistence\ObjectStorage $file) {
         $this->file = $file;
     }
 
@@ -501,8 +470,7 @@ 
      *
      * @return array
      */
-    public function getFileData()
-    {
+    public function getFileData() {
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
@@ -552,8 +520,7 @@ 
      *
      * @return array
      */
-    public function getCurrentFileData()
-    {
+    public function getCurrentFileData() {
 
         $fileId = new \EWW\Dpf\Services\Transfer\FileId($this);
 
@@ -601,8 +568,7 @@ 
      *
      * @return boolean $changed
      */
-    public function getChanged()
-    {
+    public function getChanged() {
         return $this->changed;
     }
 
@@ -612,8 +578,7 @@ 
      * @param boolean $changed
      * @return void
      */
-    public function setChanged($changed)
-    {
+    public function setChanged($changed) {
         $this->changed = $changed;
     }
 
@@ -622,8 +587,7 @@ 
      *
      * @return boolean $valid
      */
-    public function getValid()
-    {
+    public function getValid() {
         return $this->valid;
     }
 
@@ -633,8 +597,7 @@ 
      * @param boolean $valid
      * @return void
      */
-    public function setValid($valid)
-    {
+    public function setValid($valid) {
         $this->valid = $valid;
     }
 
@@ -643,8 +606,7 @@ 
      *
      * @return string
      */
-    public function getDateIssued()
-    {
+    public function getDateIssued() {
         return empty($this->dateIssued) ? '' : $this->dateIssued;
     }
 
@@ -654,8 +616,7 @@ 
      * @param string $dateIssued
      * @return void
      */
-    public function setDateIssued($dateIssued)
-    {
+    public function setDateIssued($dateIssued) {
         $this->dateIssued = empty($dateIssued) ? '' : $dateIssued;
     }
 
@@ -665,8 +626,7 @@ 
      *
      * @return string
      */
-    public function getProcessNumber()
-    {
+    public function getProcessNumber() {
         return $this->processNumber;
     }
 
@@ -676,8 +636,7 @@ 
      * @param string $processNumber
      * @return void
      */
-    public function setProcessNumber($processNumber)
-    {
+    public function setProcessNumber($processNumber) {
         $this->processNumber = trim($processNumber);
     }
 
@@ -687,8 +646,7 @@ 
      *
      * @return string
      */
-    public function getSubmitterName()
-    {
+    public function getSubmitterName() {
         try {
             $slub = new \EWW\Dpf\Helper\Slub($this->getSlubInfoData());
             return $slub->getSubmitterName();
@@ -702,8 +660,7 @@ 
      *
      * @return string
      */
-    public function getQucosaUrn()
-    {
+    public function getQucosaUrn() {
         $mods = new \EWW\Dpf\Helper\Mods($this->getXmlData());
         return $mods->getQucosaUrn();
     }
@@ -713,8 +670,7 @@ 
      *
      * @return int
      */
-    public function getCreator()
-    {
+    public function getCreator() {
         return $this->creator? $this->creator : 0;
     }
 
@@ -724,23 +680,19 @@ 
      * @param int $creator
      * @return void
      */
-    public function setCreator($creator)
-    {
+    public function setCreator($creator) {
         $this->creator = $creator;
     }
 
-    public function getState()
-    {
+    public function getState() {
         return $this->state;
     }
 
-    public function setState($state)
-    {
+    public function setState($state) {
         $this->state = $state;
     }
 
-    public function getRemoteState()
-    {
+    public function getRemoteState() {
         $state = explode(':', $this->state);
         if (is_array($state) && array_key_exists(1, $state)) {
             return $state[1];
@@ -778,8 +730,7 @@ 
     /**
      * @return string
      */
-    public function getRemoteLastModDate()
-    {
+    public function getRemoteLastModDate() {
         return $this->remoteLastModDate;
     }
 
@@ -787,16 +738,14 @@ 
      * @param string $remoteLastModDate
      * @return void
      */
-    public function setRemoteLastModDate($remoteLastModDate)
-    {
+    public function setRemoteLastModDate($remoteLastModDate) {
         $this->remoteLastModDate = $remoteLastModDate;
     }
 
     /**
      * @return integer
      */
-    public function getTstamp()
-    {
+    public function getTstamp() {
         return $this->tstamp;
     }
 
@@ -811,8 +760,7 @@ 
     /**
      * @param bool $suggestion
      */
-    public function setSuggestion(bool $suggestion)
-    {
+    public function setSuggestion(bool $suggestion) {
         $this->suggestion = $suggestion;
     }
 
@@ -827,8 +775,7 @@ 
     /**
      * @param string $linkedUid
      */
-    public function setLinkedUid(string $linkedUid)
-    {
+    public function setLinkedUid(string $linkedUid) {
         $this->linkedUid = $linkedUid;
     }
 
@@ -843,8 +790,7 @@ 
     /**
      * @param string $comment
      */
-    public function setComment(string $comment)
-    {
+    public function setComment(string $comment) {
         $this->comment = $comment;
     }
 
@@ -881,8 +827,7 @@ 
      *
      * @return string|int
      */
-    public function getDocumentIdentifier()
-    {
+    public function getDocumentIdentifier() {
         return $this->getObjectIdentifier()? $this->getObjectIdentifier() : $this->getUid();
     }
 
@@ -891,8 +836,7 @@ 
      *
      * @return bool
      */
-    public function isWorkingCopy()
-    {
+    public function isWorkingCopy() {
         return $this->getObjectIdentifier() && !$this->isTemporary() && !$this->isSuggestion();
     }
 
@@ -902,8 +846,7 @@ 
      *
      * @return bool
      */
-    public function isTemporaryCopy()
-    {
+    public function isTemporaryCopy() {
         return $this->getObjectIdentifier() && $this->isTemporary() && !$this->isSuggestion();
     }
 
@@ -913,8 +856,7 @@ 
      *
      * @return string|null
      */
-    public function getPublicationYear()
-    {
+    public function getPublicationYear() {
         $mods = new Mods($this->getXmlData());
         $year =  $mods->getPublishingYear();
         return $year? $year : "";
@@ -925,8 +867,7 @@ 
      *
      * @return string|null
      */
-    public function getMainTitle()
-    {
+    public function getMainTitle() {
         $mods = new Mods($this->getXmlData());
         $title = $mods->getTitle();
         return $title? $title : "";
@@ -938,8 +879,7 @@ 
      *
      * @return string|null
      */
-    public function getSourceDetails()
-    {
+    public function getSourceDetails() {
         $mods = new Mods($this->getXmlData());
         $data = $mods->getSourceDetails();
         return $data;
@@ -956,8 +896,7 @@ 
     /**
      * @param \DateTime|null $embargoDate
      */
-    public function setEmbargoDate(?\DateTime $embargoDate)
-    {
+    public function setEmbargoDate(?\DateTime $embargoDate) {
         $this->embargoDate = $embargoDate;
     }
 

Upper-Lower-Casing +10 added lines, -10 removed lines

@@ -55,14 +55,14 @@ 
      *
      * @var \EWW\Dpf\Domain\Model\DocumentType
      */
-    protected $documentType = null;
+    protected $documentType = NULL;
 
     /**
      * objectIdentifier
      *
      * @var string
      */
-    protected $objectIdentifier = null;
+    protected $objectIdentifier = NULL;
 
     /**
      * reservedObjectIdentifier
@@ -90,14 +90,14 @@ 
      *
      * @var boolean
      */
-    protected $changed = false;
+    protected $changed = FALSE;
 
     /**
      * valid
      *
      * @var boolean
      */
-    protected $valid = false;
+    protected $valid = FALSE;
 
     /**
      *
@@ -114,7 +114,7 @@ 
     /**
      * @var bool $suggestion
      */
-    protected $suggestion = false;
+    protected $suggestion = FALSE;
 
     /**
      * creator
@@ -166,7 +166,7 @@ 
      *
      * @var \DateTime
      */
-    protected $embargoDate = null;
+    protected $embargoDate = NULL;
 
     /**
      * file
@@ -174,7 +174,7 @@ 
      * @var \TYPO3\CMS\Extbase\Persistence\ObjectStorage<\EWW\Dpf\Domain\Model\File>
      * @cascade remove
      */
-    protected $file = null;
+    protected $file = NULL;
 
     const TRANSFER_ERROR = "ERROR";
     const TRANSFER_QUEUED = "QUEUED";
@@ -324,7 +324,7 @@ 
     public function setObjectIdentifier($objectIdentifier)
     {
         // Due to uniqe key uc_object_identifier, which should ignore empty object identifiers.
-        $this->objectIdentifier = empty($objectIdentifier)? null : $objectIdentifier;
+        $this->objectIdentifier = empty($objectIdentifier)? NULL : $objectIdentifier;
     }
 
     /**
@@ -520,7 +520,7 @@ 
                         'download' => $file->getDownload(),
                         'archive' => $file->getArchive(),
                         'use' => '',
-                        'id' => null,
+                        'id' => NULL,
                         'hasFLocat' => ($file->getStatus() == \EWW\Dpf\Domain\Model\File::STATUS_ADDED ||
                             $file->getStatus() == \EWW\Dpf\Domain\Model\File::STATUS_CHANGED),
                     );
@@ -569,7 +569,7 @@ 
                     'download' => $file->getDownload(),
                     'archive' => $file->getArchive(),
                     'use' => '',
-                    'id' => null,
+                    'id' => NULL,
                     'hasFLocat' => ($file->getStatus() == \EWW\Dpf\Domain\Model\File::STATUS_ADDED ||
                         $file->getStatus() == \EWW\Dpf\Domain\Model\File::STATUS_CHANGED),
                 );

Classes/Domain/Model/StoredSearch.php

Braces +5 added lines, -10 removed lines

@@ -17,8 +17,7 @@ 
 /**
  * StoredSearch
  */
-class StoredSearch extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
-{
+class StoredSearch extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity {
 
     /**
      * name
@@ -42,8 +41,7 @@ 
      *
      * @return string $name
      */
-    public function getName()
-    {
+    public function getName() {
         return $this->name;
     }
 
@@ -53,8 +51,7 @@ 
      * @param string $name
      * @return void
      */
-    public function setName($name)
-    {
+    public function setName($name) {
         $this->name = $name;
     }
 
@@ -64,8 +61,7 @@ 
      *
      * @return string $query
      */
-    public function getQuery()
-    {
+    public function getQuery() {
         return $this->query;
     }
 
@@ -76,8 +72,7 @@ 
      * @param string $query
      * @return void
      */
-    public function setQuery($query)
-    {
+    public function setQuery($query) {
         $this->query = $query;
     }