kitodo / kitodo-publication

src/Configuration/TCA/Overrides/fe_users.php

Spacing +6 added lines, -6 removed lines

@@ -86,28 +86,28 @@
             ),
         )
     ),
-    'fis_pers_id' => array(
+    'fis_pers_id' => array (
         'exclude' => 0,
         'label'   => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_feuser.fis_pers_id',
-        'config'  => array(
+        'config'  => array (
             'type' => 'input',
             'size' => '30',
             'eval' => 'trim',
         ),
     ),
-    'orga_name' => array(
+    'orga_name' => array (
         'exclude' => 0,
         'label'   => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_feuser.orga_name',
-        'config'  => array(
+        'config'  => array (
             'type' => 'input',
             'size' => '30',
             'eval' => 'trim',
         ),
     ),
-    'api_token' => array(
+    'api_token' => array (
         'exclude' => 0,
         'label'   => 'LLL:EXT:dpf/Resources/Private/Language/locallang_db.xlf:tx_dpf_domain_model_feuser.api_token',
-        'config'  => array(
+        'config'  => array (
             'type' => 'input',
             'size' => '30',
             'eval' => 'trim',

src/Classes/Session/BulkImportSessionData.php

Braces +1 added lines, -2 removed lines

@@ -15,8 +15,7 @@
  */
 
 
-class BulkImportSessionData
-{
+class BulkImportSessionData {
     /**
      * @var string
      */

src/Classes/Session/Session.php

Braces +10 added lines, -20 removed lines

@@ -14,8 +14,7 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class Session
-{
+class Session {
     const ROOT_KEY = "tx_dpf";
     const LIST_ACTION_KEY = "list_action";
     const WORKSPACE = "workspace";
@@ -25,8 +24,7 @@ 
     /**
      * @return SearchSessionData $data
      */
-    public function getWorkspaceData()
-    {
+    public function getWorkspaceData() {
         $sessionData = $this->getData();
         if (array_key_exists(self::WORKSPACE, $sessionData)) {
             return unserialize($sessionData[self::WORKSPACE]);
@@ -38,8 +36,7 @@ 
     /**
      * @param SearchSessionData $data
      */
-    public function setWorkspaceData(SearchSessionData $data)
-    {
+    public function setWorkspaceData(SearchSessionData $data) {
         $sessionData[self::WORKSPACE] = serialize($data);
         $this->setData($sessionData);
     }
@@ -47,8 +44,7 @@ 
     /**
      * @return BulkImportSessionData
      */
-    public function getBulkImportData()
-    {
+    public function getBulkImportData() {
         $sessionData = $this->getData();
         if (array_key_exists(self::BULKIMPORT, $sessionData)) {
             return unserialize($sessionData[self::BULKIMPORT]);
@@ -60,8 +56,7 @@ 
     /**
      * @param BulkImportSessionData $data
      */
-    public function setBulkImportData(BulkImportSessionData $data)
-    {
+    public function setBulkImportData(BulkImportSessionData $data) {
         $sessionData = $this->getData();
         $sessionData[self::BULKIMPORT] = serialize($data);
         $this->setData($sessionData);
@@ -73,8 +68,7 @@ 
      * @param $action
      * @param $controller
      */
-    public function setStoredAction($action, $controller, $uri = null)
-    {
+    public function setStoredAction($action, $controller, $uri = null) {
         $sessionData = $this->getData();
         $sessionData[self::LIST_ACTION_KEY] = [$action, $controller, $uri];
         $this->setData($sessionData);
@@ -86,8 +80,7 @@ 
      *
      * @return array|mixed
      */
-    public function getStoredAction()
-    {
+    public function getStoredAction() {
         $sessionData = $this->getData();
         if (is_array($sessionData) && array_key_exists(self::LIST_ACTION_KEY, $sessionData)) {
             return $sessionData[self::LIST_ACTION_KEY];
@@ -101,8 +94,7 @@ 
      *
      * @param array $data
      */
-    public function setData($data)
-    {
+    public function setData($data) {
         $userGlobals = $this->getUserGlobals();
 
         if ($userGlobals) {
@@ -117,8 +109,7 @@ 
      *
      * @return array
      */
-    public function getData()
-    {
+    public function getData() {
         $userGlobals = $this->getUserGlobals();
 
         $sessionData = null;
@@ -139,8 +130,7 @@ 
      *
      * @return mixed|null
      */
-    protected function getUserGlobals()
-    {
+    protected function getUserGlobals() {
         $userGlobals = null;
 
         if (!empty($GLOBALS['TSFE']) && is_object($GLOBALS['TSFE'])) {

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -73,7 +73,7 @@ 
      * @param $action
      * @param $controller
      */
-    public function setStoredAction($action, $controller, $uri = null)
+    public function setStoredAction($action, $controller, $uri = NULL)
     {
         $sessionData = $this->getData();
         $sessionData[self::LIST_ACTION_KEY] = [$action, $controller, $uri];
@@ -121,7 +121,7 @@ 
     {
         $userGlobals = $this->getUserGlobals();
 
-        $sessionData = null;
+        $sessionData = NULL;
 
         if ($userGlobals) {
             $sessionData = $userGlobals->getSessionData(self::ROOT_KEY);
@@ -141,7 +141,7 @@ 
      */
     protected function getUserGlobals()
     {
-        $userGlobals = null;
+        $userGlobals = NULL;
 
         if (!empty($GLOBALS['TSFE']) && is_object($GLOBALS['TSFE'])) {
 

src/Classes/Configuration/ClientConfigurationManager.php

Spacing +3 added lines, -3 removed lines

@@ -43,7 +43,7 @@ 
      *
      * @var array
      */
-    protected $settings = array();
+    protected $settings = array ();
 
 
     /**
@@ -58,7 +58,7 @@ 
      *
      * @var array
      */
-    protected $extensionConfiguration = array();
+    protected $extensionConfiguration = array ();
 
     public function __construct()
     {
@@ -66,7 +66,7 @@ 
         $clientRepository = $objectManager->get(ClientRepository::class);
 
         if (TYPO3_MODE === 'BE') {
-            $selectedPageId = (int)\TYPO3\CMS\Core\Utility\GeneralUtility::_GP('id');
+            $selectedPageId = (int) \TYPO3\CMS\Core\Utility\GeneralUtility::_GP('id');
             if ($selectedPageId) {
                 $this->client = $clientRepository->findAll()->current();
 

Braces +53 added lines, -106 removed lines

@@ -19,8 +19,7 @@ 
 use TYPO3\CMS\Extbase\Object\ObjectManager;
 use EWW\Dpf\Domain\Repository\ClientRepository;
 
-class ClientConfigurationManager
-{
+class ClientConfigurationManager {
 
     /**
      * objectManager
@@ -60,8 +59,7 @@ 
      */
     protected $extensionConfiguration = array();
 
-    public function __construct()
-    {
+    public function __construct() {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $clientRepository = $objectManager->get(ClientRepository::class);
 
@@ -88,8 +86,7 @@ 
         $this->extensionConfiguration = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf']['dpf']);
     }
 
-    public function setConfigurationPid($pid)
-    {
+    public function setConfigurationPid($pid) {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $clientRepository = $objectManager->get(ClientRepository::class);
 
@@ -102,8 +99,7 @@ 
      *
      * @var array
      */
-    public function getSetting($settingName, $extConfig = null)
-    {
+    public function getSetting($settingName, $extConfig = null) {
         $setting = null;
         if ($this->client) {
             $setting = trim($this->client->{"get" . ucfirst($settingName)}());
@@ -118,248 +114,199 @@ 
     }
 
 
-    public function getOwnerId()
-    {
+    public function getOwnerId() {
         return $this->getSetting("ownerId");
     }
 
-    public function getSwordHost()
-    {
+    public function getSwordHost() {
         return $this->getSetting("swordHost", "swordHost");
     }
 
-    public function getSwordUser()
-    {
+    public function getSwordUser() {
         return $this->getSetting("swordUser", "swordUser");
     }
 
-    public function getSwordPassword()
-    {
+    public function getSwordPassword() {
         return $this->getSetting("swordPassword", "swordPassword");
     }
 
-    public function getSwordCollectionNamespace()
-    {
+    public function getSwordCollectionNamespace() {
         return $this->getSetting("swordCollectionNamespace", "swordCollectionNamespace");
     }
 
-    public function getFedoraHost()
-    {
+    public function getFedoraHost() {
         return $this->getSetting("fedoraHost", "fedoraHost");
     }
 
-    public function getFedoraUser()
-    {
+    public function getFedoraUser() {
         return $this->getSetting("fedoraUser", "fedoraUser");
     }
 
-    public function getFedoraPassword()
-    {
+    public function getFedoraPassword() {
         return $this->getSetting("fedoraPassword", "fedoraPassword");
     }
 
-    public function getElasticSearchHost()
-    {
+    public function getElasticSearchHost() {
         return $this->getSetting("elasticSearchHost", "elasticSearchHost");
     }
 
-    public function getElasticSearchPort()
-    {
+    public function getElasticSearchPort() {
         return $this->getSetting("elasticSearchPort", "elasticSearchPort");
     }
 
-    public function getUploadDirectory()
-    {
+    public function getUploadDirectory() {
         return $this->getSetting("uploadDirectory", "uploadDirectory");
     }
 
-    public function getUploadDomain()
-    {
+    public function getUploadDomain() {
         return $this->getSetting("uploadDomain", "uploadDomain");
     }
 
-    public function getSuggestionFlashMessage()
-    {
+    public function getSuggestionFlashMessage() {
         return $this->getSetting("suggestionFlashmessage", "suggestionFlashmessage");
     }
 
-    public function getFileXpath()
-    {
+    public function getFileXpath() {
         return $this->getSetting("fileXpath", "fileXpath");
     }
 
-    public function getStateXpath()
-    {
+    public function getStateXpath() {
         return $this->getSetting("stateXpath", "stateXpath");
     }
 
-    public function getTypeXpath()
-    {
+    public function getTypeXpath() {
         return $this->getSetting("typeXpath", "typeXpath");
     }
 
-    public function getTypeXpathInput()
-    {
+    public function getTypeXpathInput() {
         return $this->getSetting("typeXpathInput", "typeXpathInput");
     }
 
-    public function getUrnXpath()
-    {
+    public function getUrnXpath() {
         return $this->getSetting("urnXpath", "urnXpath");
     }
 
-    public function getQucosaUrnXpath()
-    {
+    public function getQucosaUrnXpath() {
         return $this->getSetting("qucosaUrnXpath", "qucosaUrnXpath");
     }
 
-    public function getDateXpath()
-    {
+    public function getDateXpath() {
         return $this->getSetting("dateXpath", "dateXpath");
     }
 
-    public function getPublishingYearXpath()
-    {
+    public function getPublishingYearXpath() {
         return $this->getSetting("publishingYearXpath", "publishingYearXpath");
     }
 
-    public function getNamespaces()
-    {
+    public function getNamespaces() {
         return $this->getSetting("namespaces", "namespaces");
     }
 
-    public function getTitleXpath()
-    {
+    public function getTitleXpath() {
         return $this->getSetting("titleXpath", "titleXpath");
     }
 
-    public function getOriginalSourceTitleXpath()
-    {
+    public function getOriginalSourceTitleXpath() {
         return $this->getSetting("originalSourceTitleXpath", "originalSourceTitleXpath");
     }
 
-    public function getProcessNumberXpath()
-    {
+    public function getProcessNumberXpath() {
         return $this->getSetting("processnumberXpath", "processnumberXpath");
     }
 
-    public function getSubmitterNameXpath()
-    {
+    public function getSubmitterNameXpath() {
         return $this->getSetting("submitterNameXpath", "submitterNameXpath");
     }
 
-    public function getSubmitterEmailXpath()
-    {
+    public function getSubmitterEmailXpath() {
         return $this->getSetting("submitterEmailXpath", "submitterEmailXpath");
     }
 
-    public function getSubmitterNoticeXpath()
-    {
+    public function getSubmitterNoticeXpath() {
         return $this->getSetting("submitterNoticeXpath", "submitterNoticeXpath");
     }
 
-    public function getCreatorXpath()
-    {
+    public function getCreatorXpath() {
         return $this->getSetting("creatorXpath", "creatorXpath");
     }
 
-    public function getCreationDateXpath()
-    {
+    public function getCreationDateXpath() {
         return $this->getSetting("creationDateXpath", "creationDateXpath");
     }
 
-    public function getRepositoryCreationDateXpath()
-    {
+    public function getRepositoryCreationDateXpath() {
         return $this->getSetting("repositoryCreationDateXpath", "repositoryCreationDateXpath");
     }
 
-    public function getRepositoryLastModDateXpath()
-    {
+    public function getRepositoryLastModDateXpath() {
         return $this->getSetting("repositoryLastModDateXpath", "repositoryLastModDateXpath");
     }
 
-    public function getDepositLicenseXpath()
-    {
+    public function getDepositLicenseXpath() {
         return $this->getSetting("depositLicenseXpath", "depositLicenseXpath");
     }
 
-    public function getAllNotesXpath()
-    {
+    public function getAllNotesXpath() {
         return $this->getSetting("allNotesXpath", "allNotesXpath");
     }
 
-    public function getPrivateNotesXpath()
-    {
+    public function getPrivateNotesXpath() {
         return $this->getSetting("privateNotesXpath", "privateNotesXpath");
     }
 
-    public function getInputTransformation()
-    {
+    public function getInputTransformation() {
         return $this->client->getInputTransformation()->current();
     }
 
-    public function getOutputTransformation()
-    {
+    public function getOutputTransformation() {
         return $this->client->getOutputTransformation()->current();
     }
 
-    public function getPersonXpath()
-    {
+    public function getPersonXpath() {
         return $this->getSetting("personXpath", "personXpath");
     }
 
-    public function getPersonFamilyXpath()
-    {
+    public function getPersonFamilyXpath() {
         return $this->getSetting("personFamilyXpath", "personFamilyXpath");
     }
 
-    public function getPersonGivenXpath()
-    {
+    public function getPersonGivenXpath() {
         return $this->getSetting("personGivenXpath", "personGivenXpath");
     }
 
-    public function getPersonRoleXpath()
-    {
+    public function getPersonRoleXpath() {
         return $this->getSetting("personRoleXpath", "personRoleXpath");
     }
 
-    public function getPersonFisIdentifierXpath()
-    {
+    public function getPersonFisIdentifierXpath() {
         return $this->getSetting("personFisIdentifierXpath", "personFisIdentifierXpath");
     }
 
-    public function getPersonAffiliationXpath()
-    {
+    public function getPersonAffiliationXpath() {
         return $this->getSetting("personAffiliationXpath", "personAffiliationXpath");
     }
 
-    public function getPersonAffiliationIdentifierXpath()
-    {
+    public function getPersonAffiliationIdentifierXpath() {
         return $this->getSetting("personAffiliationIdentifierXpath", "personAffiliationIdentifierXpath");
     }
 
-    public function getPersonAuthorRole()
-    {
+    public function getPersonAuthorRole() {
         return $this->getSetting("personAuthorRole", "personAuthorRole");
     }
 
-    public function getPersonPublisherRole()
-    {
+    public function getPersonPublisherRole() {
         return $this->getSetting("personPublisherRole", "personPublisherRole");
     }
 
-    public function getValidationXpath()
-    {
+    public function getValidationXpath() {
         return $this->getSetting("validationXpath", "validationXpath");
     }
 
-    public function fisIdXpath()
-    {
+    public function fisIdXpath() {
         return $this->getSetting("fisIdXpath", "fisIdXpath");
     }
 
-    public function getSourceDetailsXpaths()
-    {
+    public function getSourceDetailsXpaths() {
         return $this->getSetting("sourceDetailsXpaths", "sourceDetailsXpaths");
     }
 

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -51,7 +51,7 @@ 
      *
      * @var \EWW\Dpf\Domain\Model\Client
      */
-    protected $client = null;
+    protected $client = NULL;
 
     /**
      * extensionConfiguration
@@ -71,7 +71,7 @@ 
                 $this->client = $clientRepository->findAll()->current();
 
                 $configurationManager = $objectManager->get(BackendConfigurationManager::class);
-                $settings = $configurationManager->getConfiguration(null, null);
+                $settings = $configurationManager->getConfiguration(NULL, NULL);
                 $this->settings = $settings; //['settings'];
             }
 
@@ -102,9 +102,9 @@ 
      *
      * @var array
      */
-    public function getSetting($settingName, $extConfig = null)
+    public function getSetting($settingName, $extConfig = NULL)
     {
-        $setting = null;
+        $setting = NULL;
         if ($this->client) {
             $setting = trim($this->client->{"get" . ucfirst($settingName)}());
         }

src/Classes/Helper/XPath.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
 
-        $namespaceConfiguration = explode(";",$clientConfigurationManager->getNamespaces());
+        $namespaceConfiguration = explode(";", $clientConfigurationManager->getNamespaces());
 
         $xpath = new \DOMXPath($dom);
 

Braces +2 added lines, -4 removed lines

@@ -17,8 +17,7 @@ 
 use EWW\Dpf\Configuration\ClientConfigurationManager;
 use TYPO3\CMS\Extbase\Object\ObjectManager;
 
-class XPath
-{
+class XPath {
 
     /**
      * clientConfigurationManager
@@ -35,8 +34,7 @@ 
      * @param \DOMDocument $dom
      * @return \DOMXPath
      */
-    public static function create($dom)
-    {
+    public static function create($dom) {
 
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);

src/Classes/Helper/XSLTransformator.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
      * @param \EWW\Dpf\Domain\Model\Document $document
      * @return string The transformed xml
      */
-    public function getTransformedOutputXML($document, $xmlData = false)
+    public function getTransformedOutputXML($document, $xmlData = FALSE)
     {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);

Braces +2 added lines, -4 removed lines

@@ -23,8 +23,7 @@ 
 use \TYPO3\CMS\Core\Log\LogLevel;
 use \TYPO3\CMS\Core\Log\LogManager;
 
-class XSLTransformator
-{
+class XSLTransformator {
 
     /**
      * clientConfigurationManager
@@ -97,8 +96,7 @@ 
      * @param \EWW\Dpf\Domain\Model\Document $document
      * @return string The transformed xml
      */
-    public function getTransformedOutputXML($document, $xmlData = false)
-    {
+    public function getTransformedOutputXML($document, $xmlData = false) {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
 

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
             $logger->log(
                 LogLevel::WARNING,
                 "Input XML: No transformation file is present. The given xml data was taken over as it is",
-                array(
+                array (
                     'documentTypeName' => $documentTypeName
                 )
             );
@@ -114,7 +114,7 @@ 
             $filePath = $transformationFile->getFile()->getOriginalResource()->getIdentifier();
             $documentTransformer = new DocumentTransformer();
 
-            if ( !$document->getRemoteState() || $document->getRemoteState() == 'NONE' ) {
+            if (!$document->getRemoteState() || $document->getRemoteState() == 'NONE') {
                 $remoteState = 'ACTIVE';
             } else {
                 $remoteState = $document->getRemoteState();
@@ -145,7 +145,7 @@ 
             $logger->log(
                 LogLevel::WARNING,
                 "Output XML: No transformation file is present. The generated xml data was taken over as it is",
-                array(
+                array (
                     'documentTypeName' => $documentTypeName
                 )
             );

src/Classes/Helper/Mets.php

Braces +11 added lines, -22 removed lines

@@ -14,8 +14,7 @@ 
  * The TYPO3 project - inspiring people to share!
  */
 
-class Mets
-{
+class Mets {
 
     /**
      * mets
@@ -24,30 +23,25 @@ 
      */
     protected $metsDom;
 
-    public function __construct($metsXml)
-    {
+    public function __construct($metsXml) {
         $this->setMetsXml($metsXml);
     }
 
-    public function setMetsXml($metsXml)
-    {
+    public function setMetsXml($metsXml) {
         $metsDom = new \DOMDocument();
         $metsDom->loadXML($metsXml);
         $this->metsDom = $metsDom;
     }
 
-    public function getMetsXml()
-    {
+    public function getMetsXml() {
         return $this->metsDom->saveXML();
     }
 
-    public function getMetsXpath()
-    {
+    public function getMetsXpath() {
         return new \DOMXPath($this->metsDom);
     }
 
-    public function getMods()
-    {
+    public function getMods() {
         $xpath = $this->getMetsXpath();
 
         $xpath->registerNamespace("mods", "http://www.loc.gov/mods/v3");
@@ -60,8 +54,7 @@ 
         return $mods;
     }
 
-    public function getSlub()
-    {
+    public function getSlub() {
         $xpath = $this->getMetsXpath();
 
         $xpath->registerNamespace("slub", "http://slub-dresden.de/");
@@ -74,8 +67,7 @@ 
         return $slub;
     }
 
-    public function getState()
-    {
+    public function getState() {
 
         $xpath = $this->getMetsXpath();
         $xpath->registerNamespace("mets", "http://www.loc.gov/METS/");
@@ -84,8 +76,7 @@ 
         return $dmdSec->item(0)->getAttribute("STATUS");
     }
 
-    public function getLastModDate()
-    {
+    public function getLastModDate() {
         $xpath = $this->getMetsXpath();
         $xpath->registerNamespace("mets", "http://www.loc.gov/METS/");
 
@@ -93,8 +84,7 @@ 
         return $dmdSec->item(0)->getAttribute("LASTMODDATE");
     }
 
-    public function getCreationDate()
-    {
+    public function getCreationDate() {
         $xpath = $this->getMetsXpath();
         $xpath->registerNamespace("mets", "http://www.loc.gov/METS/");
 
@@ -102,8 +92,7 @@ 
         return $dmdSec->item(0)->getAttribute("CREATEDATE");
     }
 
-    public function getFiles()
-    {
+    public function getFiles() {
         $xpath = $this->getMetsXpath();
 
         $xpath->registerNamespace("xlink", "http://www.w3.org/1999/xlink");

src/Classes/Helper/Mods.php

Spacing +3 added lines, -3 removed lines

@@ -135,8 +135,8 @@ 
 
             $identifierNode = $xpath->query('mods:nameIdentifier[@type="FOBID"]', $personNode);
 
-            $affiliationNodes  = $xpath->query('mods:affiliation', $personNode);
-            $affiliationIdentifierNodes  = $xpath->query(
+            $affiliationNodes = $xpath->query('mods:affiliation', $personNode);
+            $affiliationIdentifierNodes = $xpath->query(
                 'mods:nameIdentifier[@type="ScopusAuthorID"][@typeURI="http://www.scopus.com/authid"]',
                 $personNode
             );
@@ -282,7 +282,7 @@ 
 
     public function getOriginalSourceTitle()
     {
-        $node= $this->getModsXpath()->query('/mods:mods/mods:relatedItem[@type="original"]/mods:titleInfo/mods:title');
+        $node = $this->getModsXpath()->query('/mods:mods/mods:relatedItem[@type="original"]/mods:titleInfo/mods:title');
         if ($node->length > 0) {
             return $node->item(0)->nodeValue;
         }

Braces +23 added lines, -42 removed lines

@@ -15,8 +15,7 @@ 
  */
 
 
-class Mods
-{
+class Mods {
     /**
      * metadataObjectRepository
      *
@@ -36,13 +35,11 @@ 
 
     protected $modsDom;
 
-    public function __construct($modsXml)
-    {
+    public function __construct($modsXml) {
         $this->setModsXml($modsXml);
     }
 
-    public function setModsXml($modsXml)
-    {
+    public function setModsXml($modsXml) {
         $modsDom = new \DOMDocument();
         if (!empty($modsXml)) {
 
@@ -66,19 +63,16 @@ 
         $this->modsDom = $modsDom;
     }
 
-    public function getModsXml()
-    {
+    public function getModsXml() {
         return $this->modsDom->saveXML();
     }
 
-    public function getModsXpath()
-    {
+    public function getModsXpath() {
         $xpath = \EWW\Dpf\Helper\XPath::create($this->modsDom);
         return $xpath;
     }
 
-    public function getTitle()
-    {
+    public function getTitle() {
         $titleNode = $this->getModsXpath()->query('/data/titleInfo/title');
 
         if ($titleNode->length == 0) {
@@ -88,8 +82,7 @@ 
     }
 
 
-    public function setTitle($title)
-    {
+    public function setTitle($title) {
         $titleNode = $this->getModsXpath()->query('/mods:mods/mods:titleInfo[@usage="primary"]/mods:title');
 
         if ($titleNode->length == 0) {
@@ -102,13 +95,11 @@ 
     }
 
 
-    public function getAuthors()
-    {
+    public function getAuthors() {
         return $this->getPersons("aut");
     }
 
-    public function getPublishers()
-    {
+    public function getPublishers() {
         return $this->getPersons("edt");
     }
 
@@ -118,8 +109,7 @@ 
      * @param string $role
      * @return array
      */
-    public function getPersons($role = '')
-    {
+    public function getPersons($role = '') {
         $xpath = $this->getModsXpath();
         $personNodes = $xpath->query('/mods:mods/mods:name[@type="personal"]');
 
@@ -193,8 +183,9 @@ 
         if ($role) {
             $result = [];
             foreach ($persons as $person) {
-                if ($person['role'] == $role)
-                $result[] = $person;
+                if ($person['role'] == $role) {
+                                $result[] = $person;
+                }
             }
             return $result;
         } else {
@@ -229,8 +220,7 @@ 
     }
 
 
-    public function setDateIssued($date)
-    {
+    public function setDateIssued($date) {
 
         $originInfo = $this->getModsXpath()->query('/mods:mods/mods:originInfo[@eventType="distribution"]');
 
@@ -270,8 +260,7 @@ 
     }
 
 
-    public function getPublishingYear()
-    {
+    public function getPublishingYear() {
         $year = $this->getModsXpath()->query('/mods:mods/mods:originInfo[@eventType="publication"]/mods:dateIssued[@encoding="iso8601"]');
         if ($year->length > 0) {
             return $year->item(0)->nodeValue;
@@ -280,8 +269,7 @@ 
         return null;
     }
 
-    public function getOriginalSourceTitle()
-    {
+    public function getOriginalSourceTitle() {
         $node= $this->getModsXpath()->query('/mods:mods/mods:relatedItem[@type="original"]/mods:titleInfo/mods:title');
         if ($node->length > 0) {
             return $node->item(0)->nodeValue;
@@ -290,8 +278,7 @@ 
         return null;
     }
 
-    public function getDateIssued()
-    {
+    public function getDateIssued() {
 
         $dateIssued = $this->getModsXpath()->query('/mods:mods/mods:originInfo[@eventType="distribution"]/mods:dateIssued[@encoding="iso8601"][@keyDate="yes"]');
         if ($dateIssued->length > 0) {
@@ -301,8 +288,7 @@ 
         return null;
     }
 
-    public function removeDateIssued()
-    {
+    public function removeDateIssued() {
 
         $dateIssued = $this->getModsXpath()->query('/mods:mods/mods:originInfo[@eventType="distribution"]/mods:dateIssued[@encoding="iso8601"][@keyDate="yes"]');
         if ($dateIssued->length > 0) {
@@ -311,8 +297,7 @@ 
 
     }
 
-    public function hasQucosaUrn()
-    {
+    public function hasQucosaUrn() {
         $urnNodeList = $this->getModsXpath()->query('/mods:mods/mods:identifier[@type="qucosa:urn"]');
 
         $hasUrn = false;
@@ -325,8 +310,7 @@ 
         return $hasUrn;
     }
 
-    public function getQucosaUrn()
-    {
+    public function getQucosaUrn() {
         $urnNodeList = $this->getModsXpath()->query('/mods:mods/mods:identifier[@type="qucosa:urn"]');
         $urnList     = '';
 
@@ -338,8 +322,7 @@ 
         return $urnList;
     }
 
-    public function addQucosaUrn($urn)
-    {
+    public function addQucosaUrn($urn) {
         $rootNode = $this->getModsXpath()->query('/mods:mods');
 
         if ($rootNode->length == 1) {
@@ -353,8 +336,7 @@ 
 
     }
 
-    public function clearAllUrn()
-    {
+    public function clearAllUrn() {
         $urnNodeList = $this->getModsXpath()->query('/mods:mods/mods:identifier[@type="urn"]');
 
         foreach ($urnNodeList as $urnNode) {
@@ -370,8 +352,7 @@ 
     /**
      * @return string
      */
-    public function getSourceDetails()
-    {
+    public function getSourceDetails() {
         $data = [];
 
         $dataNodes[] = $this->getModsXpath()->query('/mods:mods/mods:relatedItem[@type="original"]');

src/Classes/Helper/InternalFormat.php

Spacing +16 added lines, -16 removed lines

@@ -86,7 +86,7 @@ 
     public function setRepositoryState($state)
     {
         $stateXpath = $this->clientConfigurationManager->getStateXpath();
-        $this->setValue($stateXpath,$state);
+        $this->setValue($stateXpath, $state);
     }
 
     public function getProcessNumber()
@@ -314,7 +314,7 @@ 
         $xpath = $this->getXpath();
         $data = [];
         $sourceDetailsXpaths = $this->clientConfigurationManager->getSourceDetailsXpaths();
-        $sourceDetailsXpathList = explode(";", trim($sourceDetailsXpaths," ;"));
+        $sourceDetailsXpathList = explode(";", trim($sourceDetailsXpaths, " ;"));
         $dataNodes = [];
 
         foreach ($sourceDetailsXpathList as $sourceDetailsXpathItem) {
@@ -347,7 +347,7 @@ 
     {
         $xpath = $this->getXpath();
         $personXpath = $this->clientConfigurationManager->getPersonXpath();
-        $fisIdentifierXpath =  $this->clientConfigurationManager->getPersonFisIdentifierXpath();
+        $fisIdentifierXpath = $this->clientConfigurationManager->getPersonFisIdentifierXpath();
         $personNodes = $xpath->query(self::rootNode . $personXpath);
         $identifiers = [];
         foreach ($personNodes as $key => $node) {
@@ -379,9 +379,9 @@ 
         $xpath = $this->getXpath();
         $notesNodes = $xpath->query(self::rootNode . $notesXpath);
 
-        $notes = array();
+        $notes = array ();
 
-        for ($i=0; $i < $notesNodes->length; $i++)
+        for ($i = 0; $i < $notesNodes->length; $i++)
         {
             $notes[] = $notesNodes->item($i)->nodeValue;
         }
@@ -395,7 +395,7 @@ 
 
         $parserGenerator = new ParserGenerator();
         $parserGenerator->setXml($this->xml->saveXML());
-        $parserGenerator->customXPath($notesXpath,true, $noteContent);
+        $parserGenerator->customXPath($notesXpath, true, $noteContent);
         $this->xml = new \DOMDocument();
         $this->xml->loadXML($parserGenerator->getXMLData());
     }
@@ -422,9 +422,9 @@ 
         $familyXpath = $this->clientConfigurationManager->getPersonFamilyXpath();
         $givenXpath = $this->clientConfigurationManager->getPersonGivenXpath();
         $roleXpath = $this->clientConfigurationManager->getPersonRoleXpath();
-        $fisIdentifierXpath =  $this->clientConfigurationManager->getPersonFisIdentifierXpath();
-        $affiliationXpath =  $this->clientConfigurationManager->getPersonAffiliationXpath();
-        $affiliationIdentifierXpath =  $this->clientConfigurationManager->getPersonAffiliationIdentifierXpath();
+        $fisIdentifierXpath = $this->clientConfigurationManager->getPersonFisIdentifierXpath();
+        $affiliationXpath = $this->clientConfigurationManager->getPersonAffiliationXpath();
+        $affiliationIdentifierXpath = $this->clientConfigurationManager->getPersonAffiliationIdentifierXpath();
 
         $xpath = $this->getXpath();
         $personNodes = $xpath->query(self::rootNode . $personXpath);
@@ -504,9 +504,9 @@ 
      */
     public function getValidation()
     {
-        $validationXpath =  $this->clientConfigurationManager->getValidationXpath();
+        $validationXpath = $this->clientConfigurationManager->getValidationXpath();
         $validation = $this->getValue($validationXpath);
-        return (strtolower($validation) === 'true')? true : false;
+        return (strtolower($validation) === 'true') ? true : false;
     }
 
     /**
@@ -514,8 +514,8 @@ 
      */
     public function setValidation($validated)
     {
-        $validationXpath =  $this->clientConfigurationManager->getValidationXpath();
-        $this->setValue($validationXpath, ($validated? 'true' : 'false'));
+        $validationXpath = $this->clientConfigurationManager->getValidationXpath();
+        $this->setValue($validationXpath, ($validated ? 'true' : 'false'));
     }
 
     /**
@@ -523,7 +523,7 @@ 
      */
     public function setFisId($fisId)
     {
-        $fisIdXpath =  $this->clientConfigurationManager->getFisIdXpath();
+        $fisIdXpath = $this->clientConfigurationManager->getFisIdXpath();
         $this->setValue($fisIdXpath, $fisId);
     }
 
@@ -548,10 +548,10 @@ 
         $nodes = $xpath->query(self::rootNode . $xpathString);
         if ($nodes->length > 0) {
             $nodes->item(0)->nodeValue = $value;
-        } elseif(!empty($value)) {
+        } elseif (!empty($value)) {
             $parserGenerator = new ParserGenerator();
             $parserGenerator->setXml($this->xml->saveXML());
-            $parserGenerator->customXPath($xpathString,true, $value);
+            $parserGenerator->customXPath($xpathString, true, $value);
             $this->xml = new \DOMDocument();
             $this->xml->loadXML($parserGenerator->getXMLData());
         }

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -177,9 +177,9 @@ 
 
         $urnNodes = $xpath->query(self::rootNode . $qucosaUrnXpath);
         if ($urnNodes->length > 0) {
-            return true;
+            return TRUE;
         } else {
-            return false;
+            return FALSE;
         }
     }
 
@@ -192,7 +192,7 @@ 
         if ($urnNodes->length > 0) {
             return $urnNodes->item(0)->nodeValue;
         } else {
-            return false;
+            return FALSE;
         }
     }
 
@@ -395,7 +395,7 @@ 
 
         $parserGenerator = new ParserGenerator();
         $parserGenerator->setXml($this->xml->saveXML());
-        $parserGenerator->customXPath($notesXpath,true, $noteContent);
+        $parserGenerator->customXPath($notesXpath,TRUE, $noteContent);
         $this->xml = new \DOMDocument();
         $this->xml->loadXML($parserGenerator->getXMLData());
     }
@@ -506,7 +506,7 @@ 
     {
         $validationXpath =  $this->clientConfigurationManager->getValidationXpath();
         $validation = $this->getValue($validationXpath);
-        return (strtolower($validation) === 'true')? true : false;
+        return (strtolower($validation) === 'true')? TRUE : FALSE;
     }
 
     /**
@@ -551,7 +551,7 @@ 
         } elseif(!empty($value)) {
             $parserGenerator = new ParserGenerator();
             $parserGenerator->setXml($this->xml->saveXML());
-            $parserGenerator->customXPath($xpathString,true, $value);
+            $parserGenerator->customXPath($xpathString,TRUE, $value);
             $this->xml = new \DOMDocument();
             $this->xml->loadXML($parserGenerator->getXMLData());
         }

Braces +43 added lines, -82 removed lines

@@ -18,8 +18,7 @@ 
 use EWW\Dpf\Services\ParserGenerator;
 use TYPO3\CMS\Extbase\Object\ObjectManager;
 
-class InternalFormat
-{
+class InternalFormat {
     const rootNode = '//data/';
 
     /**
@@ -36,16 +35,14 @@ 
      */
     protected $xml;
 
-    public function __construct($xml)
-    {
+    public function __construct($xml) {
         $objectManager = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance(ObjectManager::class);
         $this->clientConfigurationManager = $objectManager->get(ClientConfigurationManager::class);
 
         $this->setXml($xml);
     }
 
-    public function setXml($xml)
-    {
+    public function setXml($xml) {
         if (empty($xml)) {
             $xml = "<data></data>";
         }
@@ -55,8 +52,7 @@ 
         $this->xml = $dom;
     }
 
-    public function getXml()
-    {
+    public function getXml() {
         return $this->xml->saveXML();
     }
 
@@ -64,37 +60,31 @@ 
         return $this->xml;
     }
 
-    public function getXpath()
-    {
+    public function getXpath() {
         return $domXPath = \EWW\Dpf\Helper\XPath::create($this->xml);
     }
 
-    public function getDocumentType()
-    {
+    public function getDocumentType() {
         $typeXpath = $this->clientConfigurationManager->getTypeXpath();
         return $this->getValue($typeXpath);
     }
 
-    public function setDocumentType($type)
-    {
+    public function setDocumentType($type) {
         $typeXpath = $this->clientConfigurationManager->getTypeXpath();
         $this->setValue($typeXpath, $type);
     }
 
-    public function getRepositoryState()
-    {
+    public function getRepositoryState() {
         $stateXpath = $this->clientConfigurationManager->getStateXpath();
         return $this->getValue($stateXpath);
     }
 
-    public function setRepositoryState($state)
-    {
+    public function setRepositoryState($state) {
         $stateXpath = $this->clientConfigurationManager->getStateXpath();
         $this->setValue($stateXpath,$state);
     }
 
-    public function getProcessNumber()
-    {
+    public function getProcessNumber() {
         $processNumberXpath = $this->clientConfigurationManager->getProcessNumberXpath();
         if ($processNumberXpath) {
             return $this->getValue($processNumberXpath);
@@ -103,14 +93,12 @@ 
         }
     }
 
-    public function setProcessNumber($processNumber)
-    {
+    public function setProcessNumber($processNumber) {
         $processNumberXpath = $this->clientConfigurationManager->getProcessNumberXpath();
         $this->setValue($processNumberXpath, $processNumber);
     }
 
-    public function getTitle()
-    {
+    public function getTitle() {
         $titleXpath = $this->clientConfigurationManager->getTitleXpath();
         $xpath = $this->getXpath();
 
@@ -125,14 +113,12 @@ 
     /**
      * @param string $title
      */
-    public function setTitle($title)
-    {
+    public function setTitle($title) {
         $titleXpath = $this->clientConfigurationManager->getTitleXpath();
         $this->setValue($titleXpath, $title);
     }
 
-    public function getFiles()
-    {
+    public function getFiles() {
         $xpath = $this->getXpath();
 
         $fileXpath = $this->clientConfigurationManager->getFileXpath();
@@ -162,8 +148,7 @@ 
         return $this->getValue($dateXpath);
     }
 
-    public function removeDateIssued()
-    {
+    public function removeDateIssued() {
         $xpath = $this->getXpath();
         $dateXpath = $this->clientConfigurationManager->getDateXpath();
 
@@ -174,8 +159,7 @@ 
 
     }
 
-    public function hasQucosaUrn()
-    {
+    public function hasQucosaUrn() {
         $xpath = $this->getXpath();
         $qucosaUrnXpath = $this->clientConfigurationManager->getQucosaUrnXpath();
 
@@ -187,8 +171,7 @@ 
         }
     }
 
-    public function getQucosaUrn()
-    {
+    public function getQucosaUrn() {
         $xpath = $this->getXpath();
         $qucosaUrnXpath = $this->clientConfigurationManager->getQucosaUrnXpath();
 
@@ -200,14 +183,12 @@ 
         }
     }
 
-    public function setQucosaUrn($urn)
-    {
+    public function setQucosaUrn($urn) {
         $qucosaUrnXpath = $this->clientConfigurationManager->getQucosaUrnXpath();
         $this->setValue($qucosaUrnXpath, $urn);
     }
 
-    public function clearAllUrn()
-    {
+    public function clearAllUrn() {
         $xpath = $this->getXpath();
         $urnXpath = $this->clientConfigurationManager->getUrnXpath();
         $qucosaUrnXpath = $this->clientConfigurationManager->getQucosaUrnXpath();
@@ -262,50 +243,42 @@ 
         }
     }
 
-    public function getCreator()
-    {
+    public function getCreator() {
         $creatorXpath = $this->clientConfigurationManager->getCreatorXpath();
         return $this->getValue($creatorXpath);
     }
 
-    public function setCreator($creator)
-    {
+    public function setCreator($creator) {
         $creatorXpath = $this->clientConfigurationManager->getCreatorXpath();
         $this->setValue($creatorXpath, $creator);
     }
 
-    public function getCreationDate()
-    {
+    public function getCreationDate() {
         $xpath = $this->clientConfigurationManager->getCreationDateXpath();
         return $this->getValue($xpath);
     }
 
-    public function setCreationDate($creationDate)
-    {
+    public function setCreationDate($creationDate) {
         $xpath = $this->clientConfigurationManager->getCreationDateXpath();
         $this->setValue($xpath, $creationDate);
     }
 
-    public function getRepositoryCreationDate()
-    {
+    public function getRepositoryCreationDate() {
         $xpath = $this->clientConfigurationManager->getRepositoryCreationDateXpath();
         return $this->getValue($xpath);
     }
 
-    public function getRepositoryLastModDate()
-    {
+    public function getRepositoryLastModDate() {
         $xpath = $this->clientConfigurationManager->getRepositoryLastModDateXpath();
         return $this->getValue($xpath);
     }
 
-    public function getPublishingYear()
-    {
+    public function getPublishingYear() {
         $publishingYearXpath = $this->clientConfigurationManager->getPublishingYearXpath();
         return $this->getValue($publishingYearXpath);
     }
 
-    public function getOriginalSourceTitle()
-    {
+    public function getOriginalSourceTitle() {
         $originalSourceTitleXpath = $this->clientConfigurationManager->getOriginalSourceTitleXpath();
         return $this->getValue($originalSourceTitleXpath);
     }
@@ -313,8 +286,7 @@ 
     /**
      * @return string
      */
-    public function getSourceDetails()
-    {
+    public function getSourceDetails() {
         $xpath = $this->getXpath();
         $data = [];
         $sourceDetailsXpaths = $this->clientConfigurationManager->getSourceDetailsXpaths();
@@ -367,8 +339,7 @@ 
     /**
      * @return string
      */
-    public function getDepositLicense()
-    {
+    public function getDepositLicense() {
         $depositLicenseXpath = $this->clientConfigurationManager->getDepositLicenseXpath();
         return $this->getValue($depositLicenseXpath);
     }
@@ -376,8 +347,7 @@ 
     /**
      * @return array
      */
-    public function getNotes()
-    {
+    public function getNotes() {
         $notesXpath = $this->clientConfigurationManager->getAllNotesXpath();
 
         $xpath = $this->getXpath();
@@ -385,16 +355,14 @@ 
 
         $notes = array();
 
-        for ($i=0; $i < $notesNodes->length; $i++)
-        {
+        for ($i=0; $i < $notesNodes->length; $i++) {
             $notes[] = $notesNodes->item($i)->nodeValue;
         }
 
         return $notes;
     }
 
-    public function addNote($noteContent)
-    {
+    public function addNote($noteContent) {
         $notesXpath = $this->clientConfigurationManager->getPrivateNotesXpath();
 
         $parserGenerator = new ParserGenerator();
@@ -404,13 +372,11 @@ 
         $this->xml->loadXML($parserGenerator->getXMLData());
     }
 
-    public function getAuthors()
-    {
+    public function getAuthors() {
         return $this->getPersons($this->clientConfigurationManager->getPersonAuthorRole());
     }
 
-    public function getPublishers()
-    {
+    public function getPublishers() {
         return $this->getPersons($this->clientConfigurationManager->getPersonPublisherRole());
     }
 
@@ -420,8 +386,7 @@ 
      * @param string $role
      * @return array
      */
-    public function getPersons($role = '')
-    {
+    public function getPersons($role = '') {
         $personXpath = $this->clientConfigurationManager->getPersonXpath();
         $familyXpath = $this->clientConfigurationManager->getPersonFamilyXpath();
         $givenXpath = $this->clientConfigurationManager->getPersonGivenXpath();
@@ -494,8 +459,9 @@ 
         if ($role) {
             $result = [];
             foreach ($persons as $person) {
-                if ($person['role'] == $role)
-                    $result[] = $person;
+                if ($person['role'] == $role) {
+                                    $result[] = $person;
+                }
             }
             return $result;
         } else {
@@ -506,8 +472,7 @@ 
     /**
      * @return bool
      */
-    public function getValidation()
-    {
+    public function getValidation() {
         $validationXpath =  $this->clientConfigurationManager->getValidationXpath();
         $validation = $this->getValue($validationXpath);
         return (strtolower($validation) === 'true')? true : false;
@@ -516,8 +481,7 @@ 
     /**
      * @param bool $validated
      */
-    public function setValidation($validated)
-    {
+    public function setValidation($validated) {
         $validationXpath =  $this->clientConfigurationManager->getValidationXpath();
         $this->setValue($validationXpath, ($validated? 'true' : 'false'));
     }
@@ -525,8 +489,7 @@ 
     /**
      * @param string $fisId
      */
-    public function setFisId($fisId)
-    {
+    public function setFisId($fisId) {
         $fisIdXpath =  $this->clientConfigurationManager->getFisIdXpath();
         $this->setValue($fisIdXpath, $fisId);
     }
@@ -535,8 +498,7 @@ 
      * @param string $xpathString
      * @return string
      */
-    protected function getValue($xpathString)
-    {
+    protected function getValue($xpathString) {
         $xpath = $this->getXpath();
         $nodeList = $xpath->query(self::rootNode . $xpathString);
         return $nodeList->item(0)->nodeValue;
@@ -546,8 +508,7 @@ 
      * @param string $xpathString
      * @param string $value
      */
-    protected function setValue($xpathString, $value)
-    {
+    protected function setValue($xpathString, $value) {
         $xpath = $this->getXpath();
         $nodes = $xpath->query(self::rootNode . $xpathString);
         if ($nodes->length > 0) {